From patchwork Thu May 9 19:57:55 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Edward Liaw X-Patchwork-Id: 13660310 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5ADB6C10F1A for ; Thu, 9 May 2024 20:01:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=2vIyrVGyoVZJwGIHg5oJdEHi4dJwIMNzdlwFK6/lzHk=; b=JZLCqSnBMDcs+C1ubLUEPLbZiT P6AwzBCBqHFEYU0bFXNvgdykJabEq7H7QUQ/xlawY3gR5YMdbsh0aKeX5yiJCi5+AbtXquc9PLzXM dEqT/RGE7tJAj9hOmKTcDqbXiTgy4ahbLehHMdRt2Hmh7lirOrt0i5n3vu5HPP4L61cVZjslmVmzS cz8T1L+M6OKZ2Z23AxQSFrWUubyWUnKKJ5RChJRZeT9Otz3Ynbz24yOeG0XTtYPovAYCv+GveAjjI 7H/42lV9ZYfvUPpliNxgPaB5DXmgPvb3svzMrv+ye2ME0kaFJjnR6zeSruAO4eTheE/6Pah8Vhw3Q dA0yl1jA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1s59wo-00000002an1-2Y75; Thu, 09 May 2024 20:00:58 +0000 Received: from mail-yw1-x114a.google.com ([2607:f8b0:4864:20::114a]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1s59wi-00000002ahW-0yHs for linux-riscv@lists.infradead.org; Thu, 09 May 2024 20:00:54 +0000 Received: by mail-yw1-x114a.google.com with SMTP id 00721157ae682-61c9e36888bso20702007b3.2 for ; Thu, 09 May 2024 13:00:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1715284849; x=1715889649; darn=lists.infradead.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=8CLdotFEq8j908dUbT6RbcvFD+YTCI0iXOlq7nFkwSk=; b=0uI6gSYN9SBcqaDP6dp+pZ9jlTVgfY3m3J1LpQHIiIakh/pZ+JK8CnqkI+GnzSUCpM Q9Qnsx1KGfGcHIqSV2ev1aYrs0W2m07myf7lBz+QBXpM+QVtx+BuzCJXm3xdhqKEN31n m8nPZY61wfHXBD5SYmHeIGMp8jcU+fuzV2D3HHlvBBQ6wzlnI9YgXMpG43ofupO0OzDV b/Tlep3yq7jyvMQYjLHCFAqRoCD3GQRFedqBO/Tk509poU45Cgw3bZgWBpZpm2Jo0QKZ FfOb8XdxIKuRGiXDFb8wGA4hI7fXCPmymEzKw84b4nvOzSXFxYQQ2FgMmQuiXFZPUuye fOEw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1715284849; x=1715889649; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=8CLdotFEq8j908dUbT6RbcvFD+YTCI0iXOlq7nFkwSk=; b=QtLYkw9TPv/80cXYclQe1z8NDgn/gFmzvc/PRGoiN5hEzgUSDXogocNyqlMisAZp3n jJZkC3OlY40rjOh/Ef/v6ExcY82t6lvI2UFCpBOaKWkdAD3Ug0X2+VXng8o4G7tJDmbm Ngingl7legD73bm8XD6AMxt8BpD3aD15r0nXk9DSV00bDUZCLV6rN1YK5PiViY/7EaYk JLmqNMm2dP1l5089zFMo3AHRxz0shB1UBZ8LbocEHvaPpwwr6nLSIQheKqV9sh1h7pVa Lj3jYg85Sr+htgzgt3OvqJV+Q1EtKRRpQVCPAW9GZRmMZNNVAFxHV2UQr4MYbydZ/81j pMTg== X-Forwarded-Encrypted: i=1; AJvYcCVlXjM+Qx0nyOtcMyFaBwXr8xrGYkRYC5XZ4K8C94MybvTZNBVWvWHRDE9ekBhXktWtIp1HMj34glbEYDu26bKAfN8aLPm2Bjx1z9zWTOuS X-Gm-Message-State: AOJu0YykkO6zcARB4BzNXoK43WuPm9rcX9daXXFhxldMJSsxfdrqos7+ JW1BgnhYirgiYQaXXKcRIX69ybudnOEu7pw2TuddQ60AB8Mea5Mg4rYRREoWxxC0IcCM7oRHO1V 9mQ== X-Google-Smtp-Source: AGHT+IGZb1++ccVRLEMIHpSPN2qAQJXid7wFD4piJoYbkIu2XX8BrfoTxjJ3q5NtoiGCFIfHJDyo+fBfXww= X-Received: from edliaw.c.googlers.com ([fda3:e722:ac3:cc00:24:72f4:c0a8:305d]) (user=edliaw job=sendgmr) by 2002:a05:6902:705:b0:de4:5ce5:2656 with SMTP id 3f1490d57ef6-dee4f301355mr46992276.8.1715284848710; Thu, 09 May 2024 13:00:48 -0700 (PDT) Date: Thu, 9 May 2024 19:57:55 +0000 In-Reply-To: <20240509200022.253089-1-edliaw@google.com> Mime-Version: 1.0 References: <20240509200022.253089-1-edliaw@google.com> X-Mailer: git-send-email 2.45.0.118.g7fe29c98d7-goog Message-ID: <20240509200022.253089-4-edliaw@google.com> Subject: [PATCH v3 03/68] selftests: Compile with -D_GNU_SOURCE when including lib.mk From: Edward Liaw To: shuah@kernel.org, " =?utf-8?q?Micka=C3=ABl_Sala=C3=BCn?= " , " =?utf-8?q?G?= =?utf-8?q?=C3=BCnther_Noack?= " , Christian Brauner , Richard Cochran , Paul Walmsley , Palmer Dabbelt , Albert Ou , Alexei Starovoitov , Daniel Borkmann , "David S. Miller" , Jakub Kicinski , Jesper Dangaard Brouer , John Fastabend , Andrew Morton , Edward Liaw , Muhammad Usama Anjum Cc: linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, kernel-team@android.com, linux-security-module@vger.kernel.org, netdev@vger.kernel.org, linux-riscv@lists.infradead.org, bpf@vger.kernel.org, John Hubbard X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240509_130052_424925_EB339255 X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org lib.mk will add -D_GNU_SOURCE to CFLAGS by default. This will make it unnecessary to add #define _GNU_SOURCE in the source code. Fixes: 809216233555 ("selftests/harness: remove use of LINE_MAX") Suggested-by: John Hubbard Signed-off-by: Edward Liaw --- tools/testing/selftests/Makefile | 4 ++-- tools/testing/selftests/lib.mk | 5 ++++- 2 files changed, 6 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftests/Makefile b/tools/testing/selftests/Makefile index f0431e6cb67e..9039f3709aff 100644 --- a/tools/testing/selftests/Makefile +++ b/tools/testing/selftests/Makefile @@ -170,11 +170,11 @@ ifneq ($(KBUILD_OUTPUT),) # $(realpath ...) resolves symlinks abs_objtree := $(realpath $(abs_objtree)) BUILD := $(abs_objtree)/kselftest - KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_objtree}/usr/include + KHDR_INCLUDES := -isystem ${abs_objtree}/usr/include else BUILD := $(CURDIR) abs_srctree := $(shell cd $(top_srcdir) && pwd) - KHDR_INCLUDES := -D_GNU_SOURCE -isystem ${abs_srctree}/usr/include + KHDR_INCLUDES := -isystem ${abs_srctree}/usr/include DEFAULT_INSTALL_HDR_PATH := 1 endif diff --git a/tools/testing/selftests/lib.mk b/tools/testing/selftests/lib.mk index 3023e0e2f58f..e782f4c96aee 100644 --- a/tools/testing/selftests/lib.mk +++ b/tools/testing/selftests/lib.mk @@ -67,7 +67,7 @@ MAKEFLAGS += --no-print-directory endif ifeq ($(KHDR_INCLUDES),) -KHDR_INCLUDES := -D_GNU_SOURCE -isystem $(top_srcdir)/usr/include +KHDR_INCLUDES := -isystem $(top_srcdir)/usr/include endif # In order to use newer items that haven't yet been added to the user's system @@ -188,6 +188,9 @@ endef clean: $(if $(TEST_GEN_MODS_DIR),clean_mods_dir) $(CLEAN) +# Build with _GNU_SOURCE by default +CFLAGS += -D_GNU_SOURCE + # Enables to extend CFLAGS and LDFLAGS from command line, e.g. # make USERCFLAGS=-Werror USERLDFLAGS=-static CFLAGS += $(USERCFLAGS)