From patchwork Thu May 23 15:47:48 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kanak Shilledar X-Patchwork-Id: 13671994 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7FA59C25B7D for ; Thu, 23 May 2024 15:49:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=pUhtBVIwt4oh2qHhCnhl0Z2sxThpcr8XCG5bIDeJJ7c=; b=1/n0NBeEJu0u4a hUdz7H6CN0Cw7yM9twydqMVy6S9zgW2SuHHnCfODqxgmZjT3SFzmlmcTSNc3OQdnaE5oov9wdZHfa w0iXiJ5U2gHxJ3isp/be4Gm/kP2f9O2qHDfuE0BOcj7VlGsTmOjRAv9lT8QVECP8vxT1K6XXyQGbL DWzsW3erYTOLGDzxlCYHjDbKf9Pc4MtgirUUCFTl/hMDFZ0Zty98HMXbVffmpM+whrnTXvH5DKyEy as8jZjadWK9yiKjfBrIjYMTZjGElOdro75UsW13I2ir2rKGTjOGd7jc3IvYwLnyR+pl47XtPDya7n dC05/oXdoNU5XRtZ9gww==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1sAAgW-00000006hWO-01qs; Thu, 23 May 2024 15:48:52 +0000 Received: from mail-pl1-x62b.google.com ([2607:f8b0:4864:20::62b]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1sAAgS-00000006hUx-2fph for linux-riscv@lists.infradead.org; Thu, 23 May 2024 15:48:50 +0000 Received: by mail-pl1-x62b.google.com with SMTP id d9443c01a7336-1f32448e8fbso15029395ad.1 for ; Thu, 23 May 2024 08:48:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1716479327; x=1717084127; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=7BhK75bXFq9QXiZkl3Cdcd/j/Js9FIe4nw/sI4pfEyc=; b=Ar/SPRAyCt2Tz42drSQ7vROicAE+Jt70E/aDKl37J1bA/zwmEOgWOjb3JdQBE8+qiB NCSI87oCzz898z2BK1iajaBhtu7gEo4l7Z7pjjD1VNNGWtTBe2HCsDeNqtljd4X3Q6bs dOQPXdvHZWyd/T6OCrLG/m5VSd1qhULmUdNgw5oZKvNTmm/ylY46TJYWpUnqcuQRNAQ/ hUesemtj1jY+IoWMw5e3yTtxd9T/iSGZFEvkRMpVDJ+i74kquu93waUZkefuhVr29QCu z10/IIxqzUWYRU8EWhcrcvg2fNNpHxyCkW3R1+I9BcrspcU6kuUQ4wYRq+ua/KJuPwUn N+/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1716479327; x=1717084127; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=7BhK75bXFq9QXiZkl3Cdcd/j/Js9FIe4nw/sI4pfEyc=; b=pWGCHI7gfhogcEOmCLddsebUdg8zVVMskojqaMda9UwyXBy0hMcbvV5YqXNvs+77JL +Ne3kI60u90l2/wBPHV8tYilTLdskF3SnO9B30dsSJNPbupYiiRmTysJxP/X6x6lqyS1 5Dkbnk8tWRf4pOqlnUK2P181bL7/uAlQsR0kSdh83r5zoyLloy9ROBRcKrGZdPXM0lzD DMDPXRpH0aYjPH5AsLfvKc30v6CJQ3ajy4Tdw6GeIMq6wZ9B7Whkbbz8qjGtyMHhIppU DcVKMr83TgRjH8m/q/aXiEjyT2Q0NDK4JVholIJDquikF2IGeAgGp9fXdF+ntaj76YKC quwg== X-Forwarded-Encrypted: i=1; AJvYcCUtjNGzl7Nk5UUR4Wg9Hjv8Jcg8gQCDwpzo2hhYnm0siW7JmbZ39lhwM59f3XyT3v/OJfGSogWYlLDxteiNZ9gQqcLsPSn4OvAt0AE1O3Fq X-Gm-Message-State: AOJu0YyoE9NGjC6I4Z62JYM9NoYTiLqwqFlNaGU/yWmg25qK3T670ITD F2/l2gMs0i/rRMaIBqFyv+hKAqk0PtiGK158Xxrh7SlioaV5TC2V X-Google-Smtp-Source: AGHT+IGMrkF69XcX/hXDLGXVQARSXHzwB0jz+sHvRGlqseKuvh+dumXN7fxyMa+ckV+c6mzDbqoY3A== X-Received: by 2002:a17:902:e5c5:b0:1e4:4ade:f504 with SMTP id d9443c01a7336-1f31c9e48d3mr57360905ad.46.1716479327137; Thu, 23 May 2024 08:48:47 -0700 (PDT) Received: from localhost.localdomain ([223.178.81.93]) by smtp.googlemail.com with ESMTPSA id d9443c01a7336-1f3361a6678sm18321085ad.178.2024.05.23.08.48.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 23 May 2024 08:48:46 -0700 (PDT) From: Kanak Shilledar X-Google-Original-From: Kanak Shilledar To: Cc: Kanak Shilledar , Thomas Gleixner , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Paul Walmsley , Palmer Dabbelt , Albert Ou , Samuel Holland , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-riscv@lists.infradead.org, Conor Dooley Subject: [RESEND v3 1/2] dt-bindings: interrupt-controller: riscv,cpu-intc: convert to dtschema Date: Thu, 23 May 2024 21:17:48 +0530 Message-Id: <20240523154748.22670-2-kanakshilledar111@protonmail.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20240523154748.22670-1-kanakshilledar111@protonmail.com> References: <20240523154748.22670-1-kanakshilledar111@protonmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240523_084848_703943_02C27791 X-CRM114-Status: GOOD ( 24.55 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Convert the RISC-V Hart-Level Interrupt Controller (HLIC) to newer DT schema, Created DT schema based on the .txt file which had `compatible`, `#interrupt-cells` and `interrupt-controller` as required properties. Changes made with respect to original file: - Changed the example to just use interrupt-controller instead of using the whole cpu block - Changed the example compatible string. Reviewed-by: Conor Dooley Signed-off-by: Kanak Shilledar --- Changes in v3: - Remove reference to `interrupt-controller` in `riscv/cpus.yaml`. Changes in v2: - Update the maintainers list. - Add reference to `interrupt-controller` in `riscv/cpus.yaml`. - Update compatible property with the reference in `cpus.yaml`. - Include description for '#interrupt-cells' property. - Change '#interrupt-cells' property to have `const: 1` as per the text binding. - Fixed the warning thrown by `/renesas/r9a07g043f01-smarc.dtb`. --- .../interrupt-controller/riscv,cpu-intc.txt | 52 ------------- .../interrupt-controller/riscv,cpu-intc.yaml | 73 +++++++++++++++++++ 2 files changed, 73 insertions(+), 52 deletions(-) delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt create mode 100644 Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.yaml diff --git a/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt deleted file mode 100644 index 265b223cd978..000000000000 --- a/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.txt +++ /dev/null @@ -1,52 +0,0 @@ -RISC-V Hart-Level Interrupt Controller (HLIC) ---------------------------------------------- - -RISC-V cores include Control Status Registers (CSRs) which are local to each -CPU core (HART in RISC-V terminology) and can be read or written by software. -Some of these CSRs are used to control local interrupts connected to the core. -Every interrupt is ultimately routed through a hart's HLIC before it -interrupts that hart. - -The RISC-V supervisor ISA manual specifies three interrupt sources that are -attached to every HLIC: software interrupts, the timer interrupt, and external -interrupts. Software interrupts are used to send IPIs between cores. The -timer interrupt comes from an architecturally mandated real-time timer that is -controlled via Supervisor Binary Interface (SBI) calls and CSR reads. External -interrupts connect all other device interrupts to the HLIC, which are routed -via the platform-level interrupt controller (PLIC). - -All RISC-V systems that conform to the supervisor ISA specification are -required to have a HLIC with these three interrupt sources present. Since the -interrupt map is defined by the ISA it's not listed in the HLIC's device tree -entry, though external interrupt controllers (like the PLIC, for example) will -need to define how their interrupts map to the relevant HLICs. This means -a PLIC interrupt property will typically list the HLICs for all present HARTs -in the system. - -Required properties: -- compatible : "riscv,cpu-intc" -- #interrupt-cells : should be <1>. The interrupt sources are defined by the - RISC-V supervisor ISA manual, with only the following three interrupts being - defined for supervisor mode: - - Source 1 is the supervisor software interrupt, which can be sent by an SBI - call and is reserved for use by software. - - Source 5 is the supervisor timer interrupt, which can be configured by - SBI calls and implements a one-shot timer. - - Source 9 is the supervisor external interrupt, which chains to all other - device interrupts. -- interrupt-controller : Identifies the node as an interrupt controller - -Furthermore, this interrupt-controller MUST be embedded inside the cpu -definition of the hart whose CSRs control these local interrupts. - -An example device tree entry for a HLIC is show below. - - cpu1: cpu@1 { - compatible = "riscv"; - ... - cpu1-intc: interrupt-controller { - #interrupt-cells = <1>; - compatible = "sifive,fu540-c000-cpu-intc", "riscv,cpu-intc"; - interrupt-controller; - }; - }; diff --git a/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.yaml new file mode 100644 index 000000000000..c9c79e0870ff --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/riscv,cpu-intc.yaml @@ -0,0 +1,73 @@ +# SPDX-License-Identifier: GPL-2.0 OR BSD-2-Clause +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/riscv,cpu-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: RISC-V Hart-Level Interrupt Controller (HLIC) + +description: + RISC-V cores include Control Status Registers (CSRs) which are local to + each CPU core (HART in RISC-V terminology) and can be read or written by + software. Some of these CSRs are used to control local interrupts connected + to the core. Every interrupt is ultimately routed through a hart's HLIC + before it interrupts that hart. + + The RISC-V supervisor ISA manual specifies three interrupt sources that are + attached to every HLIC namely software interrupts, the timer interrupt, and + external interrupts. Software interrupts are used to send IPIs between + cores. The timer interrupt comes from an architecturally mandated real- + time timer that is controlled via Supervisor Binary Interface (SBI) calls + and CSR reads. External interrupts connect all other device interrupts to + the HLIC, which are routed via the platform-level interrupt controller + (PLIC). + + All RISC-V systems that conform to the supervisor ISA specification are + required to have a HLIC with these three interrupt sources present. Since + the interrupt map is defined by the ISA it's not listed in the HLIC's device + tree entry, though external interrupt controllers (like the PLIC, for + example) will need to define how their interrupts map to the relevant HLICs. + This means a PLIC interrupt property will typically list the HLICs for all + present HARTs in the system. + +maintainers: + - Palmer Dabbelt + - Paul Walmsley + +properties: + compatible: + oneOf: + - items: + - const: andestech,cpu-intc + - const: riscv,cpu-intc + - const: riscv,cpu-intc + + interrupt-controller: true + + '#interrupt-cells': + const: 1 + description: | + The interrupt sources are defined by the RISC-V supervisor ISA manual, + with only the following three interrupts being defined for + supervisor mode: + - Source 1 is the supervisor software interrupt, which can be sent by + an SBI call and is reserved for use by software. + - Source 5 is the supervisor timer interrupt, which can be configured + by SBI calls and implements a one-shot timer. + - Source 9 is the supervisor external interrupt, which chains to all + other device interrupts. + +required: + - compatible + - '#interrupt-cells' + - interrupt-controller + +additionalProperties: false + +examples: + - | + interrupt-controller { + #interrupt-cells = <1>; + compatible = "riscv,cpu-intc"; + interrupt-controller; + };