From patchwork Wed Feb 5 00:58:19 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960293 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 49147C02193 for ; Wed, 5 Feb 2025 01:02:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=u1MqOcxc7Ept8RpqTvUsN9447oFmsVf6SXjYOKFVgWo=; b=baIxKQss0idftet0isp4yD31s+ YjYszXmntJFQZ4MJvWFOG29LiaQ0jaa2aXuCfKaRPuNpxA/mJZKZ0VajSMWYdnDqH2BF6VSV5iaaW uKiHtW3LfQH1gCDcuwrAiORBOJ1KJqBtIN4yYeOX7rvWu/sYXzkTBjitL/us9aCnC1ZhQl+DC094x VmGLTfXUzwltLSdWSLczLENFrMsYN6NeZkJcqLnIxZVmKCSCzUrV+2kegn6PPBjljx6BtrJl8fFKA idxEZcVO71hl/gmun+hdiYTTO+H7Gzz0uMZuwPJyrxRUJKacKwk7/peaf+YuxLKOeysOXon7DRqS/ b8N+v4gg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTnm-00000001yqB-2Wg5; Wed, 05 Feb 2025 01:02:02 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTl9-00000001yLX-0j6z; Wed, 05 Feb 2025 00:59:20 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=Hgz+tF5bRZ5pi15daCNM+b9SL0SkV2QBZaSxWPz/DF9zkQ52mZCOWJgahUhf+vZeZ2FemrLT4ieIXElQpkW52bV7ySfwf2FCLyk0HcSjiu8M+55OyCkn/lk84cPOtUuGN7T2THhrlVo+cfDOjhYTXHEYNQM1J14+qbHfjCwggJDc1me/O82LqzLQKsWW2xIpgiuHk8kRfPQrmasWrDvVgHaUmWx7/ut/1tWlOfzhvGHBQcFpV4ebda9XBjtxG0xxZ2YUUDdHOQoRzBNa62qMEd+8fqj+rjNafq7rXP/loCZV9E8h3vdTC9Ni3lXQ8cmA6tMGUPltSWLX0RfeMKLLxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=cXhN8yZODNUAFFzTvDXueHauX0spZjv+doLw4DqIRFA=; b=hRDcZlbQYgnPziO1TpwRtfNywnXZbvM7uZk1Z8ui0cGvS132Xb4j0PTIKE2eS1n+eXjEMha2HmCtoLCQkCxnTyJ6WMsCawj0vjZbMQ8gDbbW7S9z8gngYEG193MYtBlj+AUS/Akokjp+CN3whU1+i4HxGbYcqBZDl8dwk1HbKQ9pKwYkGZlbVLVFBTjsYnP0/za31xz79dz0vHCBtfnh+AdBZdrT2lNcc0InQ/KckJZThWAp2ZwmvpoHlnUeJcCAu3DGlPtizR3FlZNXJDQlIfz8ewgJQILp+GzlNepGjK6lsOnDi575+RAEFisIlX8U3kbd2j+B4vwIoqGgHOIFbQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=cXhN8yZODNUAFFzTvDXueHauX0spZjv+doLw4DqIRFA=; b=SSRj6NMITme3BmCQyggX91rD+xXzcDvoYjOvKWZAREPcgnQNLeVXZNv5M+1lb0f4ag42srQcvcDdpMHjIAeHTiy+0lcwh1SVGz2+kN89LW+gzUK6p81EDi4t9KNl9QRss5b/L2jF9gM6tDmahATootyq9wfh1zgJ/gcIe8EXyHVC7uMiYOY/nmen101sYeRSgjfricu9C+f8y6UlyxqB7XHQIKafarnOBSNfpDyzV5F3IJP+V/IL1Hz58xWVvufxsxCJJEezTxM09CtMLwkDSwqdZQm8eann3dU2/c4UWywTU4sZz18TbYEkAB614lcHxbBq24ibzIOytzDKAYDxoQ== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:14 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:13 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:19 +0800 Subject: [PATCH 1/7] rtc: stm32: Use resource managed API to simplify code Message-Id: <20250205-rtc-cleanup-v1-1-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan , Antonio Borneo X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1587; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=mSTCl6oCfnAa45eZZ0ce81+vqGl5rBwE3yA3RKdgxSo=; b=Lk2a2rVgsQVbE64qePKxXCkNhWNVGlTJaj4JEupetcuunmnR/EErmB3/D3wwreSFhSh+WzdaX WTLr3G09U4QAFHak6Ng+ayGTwEopXQOaC+KXtjNT6urJ+uuLKBqHa1h X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 99d3215b-3ecc-4065-7f04-08dd45804ee1 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?7jzUzVRt+y7uI5unLTfg9ghFoB7SWMW?= =?utf-8?q?DXIJ+kE4ZNRX89xdyaSQ5tJKLjUUHLfvxl8+3PozCkzSQnWcHJDmubZjn8nAzSYIs?= =?utf-8?q?Nxvl+v+No3JLt7ipKfkgbuZttlky/Ion31KAEU6BB8iTmPWZnmEcnSQ+cvjZWv3be?= =?utf-8?q?6cdDsAcnAcfnLj9+AB8EUmcEmkv0tAUUNCX3GpV5zgH9aoPQglGfPWEP/+tx5JOqx?= =?utf-8?q?7gYsp0Mj0HCWrPhDP3MQdPKkpW661meebn8etVNEU3OeazGr+wPKWDOjTnHHeV3lg?= =?utf-8?q?eGprNBh1j37aMqWLKXta7k7RF2q3puQ7GQ33NCQAEPCSqKH3fzIhz2PQK3pFzaqeV?= =?utf-8?q?8tKrQs+d2mvqaFLMgWgZDxouo1YbJB1r5CmwTrEBFtCkifbAAHn655srODteMUxmF?= =?utf-8?q?UXNIp/soXbJm6Ak1u2jFRsNkeOF4A0GK8HaqmUhjn6N2UT7qiuR8pFD+pa+Otw+Kb?= =?utf-8?q?ayhvoi2ntR/sZ0bzfhC2J7XKtkCom7yIWLRURDkMe2vHnPA3bI2JFyH0ghpdE3awI?= =?utf-8?q?AwUhig5IY3p+/qxqIv61/ZiOPe3H87qAdlrphC1q98D5tEbFh98JXAZA6xxXkU0fJ?= =?utf-8?q?uAVcPWa0sNG26C8gg0x5gCTTK8qLD3UrR/pxs7bu8SJLC1OTBQFsgqgJYVJq6r/+D?= =?utf-8?q?fidUEzO7HzSer7Ri0XAteK8DdSwo9rnnh7DJ88ASo17P6JRwUHFl9FIyomcS2vdng?= =?utf-8?q?OT3Lid1y/cj/icGFfA0EVFY/UT/TVuM6IC8o7pcc28SPCA9Z8S1EY0p/0Sy2fR2ni?= =?utf-8?q?p+4S5PbRoR8R+xtFsuTEXTJd3jRZUtAFh5qt+Y4njojJLNFU0T0THSI4UVj8Rwd85?= =?utf-8?q?6UkXIzCGqgzL9+K+THGbcdF5sf9Nqof4VCAi2nF2+z70uai+oBTmE2IRiZlDeLKF2?= =?utf-8?q?lPyj21LDxMCTGJ8F+FTIYIkpquOgwRdxt8jGT03Mi5kQAdIhMVpwARLqL6xoiKmSI?= =?utf-8?q?SSSsCzyEoc9qkZruUCCMBVWh9dxF3cu2YUIbzj8NGgqF7yhgJkLj9472REcrlRF/b?= =?utf-8?q?6rz5N89fxkGuWmdAY645LRihWe0g7h0Ix0IEkpMcygbmDDalK3OCqBM4OzWfZ1Pi3?= =?utf-8?q?Pq/znkxVFPvlCuA/t/Gmc9IUnvxBCPQ6nsXGwyilyFdy/vXessEpq8qNaToETli9u?= =?utf-8?q?GegNOGU4PxP491cNB9YfTWOea9FYVDfViLzVYYOTIIAeZ+yftal3P3mhGoYRGX7oF?= =?utf-8?q?SXcMFtVq19/ifcfXXxMlRb1C2u7590Ljc8eewWq8WLjbyffEYVPEhPhtYIFXJqGv/?= =?utf-8?q?ridozosR1AoN5kYzr6QLFgP8JCPKBnwLc9Yd0duNUKl0rxKup3DVZssFlbKgW/Ou5?= =?utf-8?q?u+Sewts5Uc84U079ac9oyGPxi+C4f9sZ5He7qSy1sAz9cHBcMcZeDAwlDCjRoNiLW?= =?utf-8?q?LLmLDV+4R8O?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?F8l5dusLkHlwLozVxELh497oCt0h?= =?utf-8?q?BllnUgrvf0cp4d8TmxaoYfsM7rfvJGQn135CfKWln40xjJlO18ChlT7FliGCn6Urw?= =?utf-8?q?rmqFK0edvoUTDhWU+CvzOfsnIvrlsaFh/yYxj5CmwmaffeuvREnEkNDB7gDoHPmjJ?= =?utf-8?q?0EDOrG2b78ynE2p8O0S6jW8gt8WcH6S+VOvfzwv5/EyKSSgxE+hyXbTTqT+0ftrSm?= =?utf-8?q?u6vjEgo/L7bRYHwZGs/2uP2Xg452A/WBT5qB5QvZNTpACbCPH7cYrN9QT1Yl4L28/?= =?utf-8?q?IvBKXiUEcTyG/4pE2EyewQpLjdOPP3dUvtZrOygpxK3A0jtWC83sjx91juYfQFGla?= =?utf-8?q?hooWrg2nPXm/4XxEKcj0rXH2Bm5iPibJ1NQs77fkUVbM/BZW+n70P/uFqUk610FvQ?= =?utf-8?q?SEzpeQPsYQiOsvsr+yoY7DZrJMR1v44FBhca5lOnG1LaDEmVVii/E2Gzi83tu9WJL?= =?utf-8?q?DGjd3Sx4ZaWGRWNs7tIGBPnrpDEwGn21YSEM3WvvIs7wL9778ElcHmzq7iJJzp91w?= =?utf-8?q?L6DC3JpBPYKmKPbNQGrlKLDyDGeTlPkdtMzSUk2K2KA32NmnA6cO7B05NMgjAAtH5?= =?utf-8?q?EQ8y9IcqnUZj4fbVzCuaBkfIsChnxeD6P4HBgmTWeCmuie5ikN5YeLHVFMqJgEgv8?= =?utf-8?q?pZ/U5fuH7BtGZRlv7Ev0mUMtPO5DlQBPnhPpa+aCZ5prF7qgt6q2kdLh8+SNqOGnF?= =?utf-8?q?ZI/9l/M7/ZKkaEqigivx1qxsGhuPdv89r2HYxgM4wvqu98qad6ZwUKfFHOgrysvJh?= =?utf-8?q?7KiBq6u5f5sE8TElcc/z2CdXc2K5T7vLnpuc717v9FuuV8nHyrSuYzakdmzrA/aXP?= =?utf-8?q?2Qe0vymTxE5p4aywr1JACa95AHaBAJ/dD348DP1zj9SsrIlJPffF7BzCSiOTCe9gN?= =?utf-8?q?WSYU+6UFOWiY+n7wBs53rDqFkqUGH3FLnAgUqVrx9irLB5/Z5vo+ncrGBbF0biX7n?= =?utf-8?q?8X499YPI2GZJLZTXpeZILyWej2X13YLHnQxsbY7lCb22LqHm/GkgLu64ZoOLpYSqt?= =?utf-8?q?fm2t6lN+NPPvolwq6m4pVzJf9Gsp1Sk+uKti2BkuOcEm7B2xLCb7qol8/LYM27rot?= =?utf-8?q?KoU8RytPdlNff7BUiP1W4JpzeIKWtXeIgbN0jfEVpym2UO51lML8GgyM69K2fFzFP?= =?utf-8?q?6gdqpR/UevGC8Ots3aEj6KhrsJgUYgzpjbAGjKeEEwQB9Zx5Sx/e7k1VhQaW8N2MV?= =?utf-8?q?gdzQhQjEdd1Chz93v2DqQJ3dce3+GZY75Xg5cV78oQVe955cCDph6I9BrouV2Tzfn?= =?utf-8?q?nO9C084vMzeBlCpgYpodRB5Rm2bZDDgVRAJBhIRW/LZ/FVVT76jeoxKwG3wtpRz+o?= =?utf-8?q?KafroeW5Ir1sBcXpTvZeY09oR4iZoLcS9i/wIgw4vuLGkGpT4xccpfijxTyiDCs+f?= =?utf-8?q?wx07T1fp2IQ/UrllSHMe//nqwuqBRfyH5iYOVCLmRF7wpNfvXW0AsQxpeak9E4kyx?= =?utf-8?q?GfQ0gEUrF7hKr/BX9dhMYjMq6QlBJG6lxCFHnI9OKJUq/QPKSeVv+bOyVNo4isvbz?= =?utf-8?q?95kkhJIGfwDO?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 99d3215b-3ecc-4065-7f04-08dd45804ee1 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:13.9092 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: WTsFcdg24zs4xgWICahUxvnqRyfWyXSnbjgdlbO+rRQYOfstAr6scDVt53Uot8pDjSAXBE0i2EWpdGRIET1T7A== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165919_222843_08D0ED92 X-CRM114-Status: UNSURE ( 9.80 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Reviewed-by: Antonio Borneo Signed-off-by: Peng Fan --- drivers/rtc/rtc-stm32.c | 10 ++-------- 1 file changed, 2 insertions(+), 8 deletions(-) diff --git a/drivers/rtc/rtc-stm32.c b/drivers/rtc/rtc-stm32.c index a0564d4435690313b86669893ec639af90fd6b68..1b715db47160158b3cfc79c437ea956e301deeb5 100644 --- a/drivers/rtc/rtc-stm32.c +++ b/drivers/rtc/rtc-stm32.c @@ -1143,11 +1143,11 @@ static int stm32_rtc_probe(struct platform_device *pdev) goto err; } - ret = device_init_wakeup(&pdev->dev, true); + ret = devm_device_init_wakeup(&pdev->dev); if (ret) goto err; - ret = dev_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); + ret = devm_pm_set_wake_irq(&pdev->dev, rtc->irq_alarm); if (ret) goto err; @@ -1208,9 +1208,6 @@ static int stm32_rtc_probe(struct platform_device *pdev) if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; } @@ -1237,9 +1234,6 @@ static void stm32_rtc_remove(struct platform_device *pdev) /* Enable backup domain write protection if needed */ if (rtc->data->need_dbp) regmap_update_bits(rtc->dbp, rtc->dbp_reg, rtc->dbp_mask, 0); - - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); } static int stm32_rtc_suspend(struct device *dev)