From patchwork Wed Feb 5 00:58:20 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960294 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id BD6D9C02193 for ; Wed, 5 Feb 2025 01:03:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=r2hVzGwq/lGLJf/+SRytq7PzChhrqrxvhNJyvMgE8xk=; b=X65HKYrGr71YudUrEnGDAVXUq+ 32DLllDwYdy2SO38bTVRQoEBg681hLmWCszXB34XDmqc1I9yVopanaqxlkCFfDTbxtFHImCe8fgQo 2V/DTxFvlNv4VjzYnW4fnsFKAefYe/v0mnsxSM7WTQPcqgk0qrctNu3ntT+z3jV/KMvEajhUQ9N/D 0qO7wbyeKdsfoxlGDPQAknF1YpMyaKC5KxekdFqv8kNl9xB+4iB9kBSZlPojr+hdvsZEgno1lipIy S6oIQ6Nnvb1Bb3yfoE76GIQ9jIKBilRm15QkVWKXAcdCsPEHxDDkrqk6v4o2M2RjkjbD5D+YDoKhz 04fP8Dnw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTp5-00000001z3U-3lPL; Wed, 05 Feb 2025 01:03:23 +0000 Received: from mail-francecentralazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20a::7] helo=PA4PR04CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlA-00000001yLX-2SpX; Wed, 05 Feb 2025 00:59:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=j8L4dTNQF6PB+2/V2rnCUUxlCPNbDxDGdJKaqqcC2CHW62cmQhbz2rMj1ZsIs6PicomqCVOLmt5zMDD9kYJPabiww1iufXVRy+UJtBr1hZkb6iTzVIXkulIWIE6EvNow8/d3ddiL+UO9WOm8dPAwbG4I+rkWDgag/nVi0AkRw0oLSPJakmlYszUW2bcWpb/1CJGwmFkeZAASpVvxnE2XAbU6b3xDUdG1vBpBRXl/Gsla0Z4FedhBbnTFt+vVkovBaRa3YHd89f+HN+cC30mYSRmMs+i8nVXCRje6MGS/XXzMmnUeYAL2vUK+ZoBEJl20h5BpSfjEN+7mIRa7fHZscA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=d8KEGfsBO+a/yMYt/8MeYmgHuHZrP8QIwEToVnW2SWnNsGhocloxslRHZurofmc70z60y+dhpw43WSbrr9Leu3f6J7XY5uVMrwee1m8STDuw9aFY5wHHmpeUXNQc/Dg+4kb2WhOKEDhq79hyv13udt+++xNHZ6igOe8P8Dri1AWviLsCeZUC+ExGWWguT51hNX6wh8MVkNY0Oryj5E1kWqtYPiUt+WvTRrc0BZHel0rNks0QSdDxx0RxF9jLZkYGP7Lv1Qd94jWqn8DHKfI13NZW94HTK8ecr4xdeUGTw3Jsm4X3BHB1yKYQNQ1o9o/8RUZWUzFR/4sRZEqYdHZx9w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=VFg5y3TrIOn9VH/jNSFVTNtUnnNsK5iZCxLymVMVirI=; b=reSMyPCT8VEPMYbX7GR6+couZPM6zsOs50mP9UrYUzI3Vv21jIraGrIZjG4Ph9DbvZ6lJYrZT+0U3JB9XIw39GRlybNSDG8xEMqUia7X57e0NiwzPQmVy96rS1bPCfFsoK97ToHm8hVLmdOdlGElEmRdQejeBV7S/+MDe/kWKifo5iD0nPvv9HKnFXz6yiNcCcvcTJPD+j6Jot4RSt5wGZ2Ba3hs5oKsmeWE5LfWgnzBnE2lno07pLJB4mbvnErVhVQ9u7rX+Ha3JHR52wLT2DAPNMzRbVjgqhjc4QEHCmT2v7fb6lf4uNpEtwnxFAVNkVuN+9FwOBOgO1txtj45XA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:17 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:17 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:20 +0800 Subject: [PATCH 2/7] rtc: nxp-bbnsm: Use resource managed API to simplify code Message-Id: <20250205-rtc-cleanup-v1-2-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=2071; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=VAulaoWVPhHtzgpO1nG1u9VR+bogAGzfLBxhdt2/l0I=; b=ENdfDOGh0YGiORqM8nju1hwNzBEhXGkPtvmLmmrZH3kthYHpqDEz/bK2nIQJZOLHJyLNZiEJl KkNPuJQtFo7D3ncM4rUNGcWCBY7luJ/myGCOqhWy0nl6JsNPHZZfAKy X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 752ceb67-d20d-4efc-4cee-08dd45805124 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?ZzTjkaW2EWROo1H+YFwo+vK6EUqyRYQ?= =?utf-8?q?z3sF+sunexW0DEzb1+nIWBflaTEVuHR/2j93LdJkoivdEfiy/QwTXYQt/0+H+4ff2?= =?utf-8?q?RJC2FF0V3qn1tOITiC3q3NQ55KHbr4XgfRM4qXtSDUFdaslLYc8l2hvb5Dw9XlhNQ?= =?utf-8?q?ky4bh06ZvsaIb44t1hK2JOtrCvvtUVUlGrSNLiKJ+bhEpoFkJMa3iOWa5q9BmLzZX?= =?utf-8?q?4x10ULHJ33EaS6wC8q3JKjnXIqoJCoe6u2MHA35hqCpO8crr38rV5YZhMcwA9CzWx?= =?utf-8?q?e4KJNOAEcNnPvLgiUQm5UCOgAjRIPnjP+wod7+QrYTURBUY+C4iapa3VjVlCWcmqr?= =?utf-8?q?ytSMx7Sr8Hj+lkE1SNTvEjedv/W39vj7eYGIJuxRB4pJx9gFNv2tTxFe2g5HYHpQv?= =?utf-8?q?tLyQFgTfjRqahr7V+qtQxt6myVbjwFhLDfAHO46720DxGKrP/SjaLPoq+zNk+K0cC?= =?utf-8?q?cI8UXZ+1F/mz0YnercjQPepzydEeFr6Zl5CNVgEdKFZVlUBteGO9WmDNvwGZpTDgi?= =?utf-8?q?YdVsNNalLhaGb/TFJksXmGoDT4kW6V9Y1LvZwDJVWqSzrMYiByIGGir5FKey1ZJ3H?= =?utf-8?q?OVP3RTUgPxh1my0JJy1O5Cnt7SgaB5KYrxU8e9H7ATi5NpIF+Nywh8SQVKmCs56zm?= =?utf-8?q?fXYh2/Is5Sj6x8mAm05zpsw4XWE7XnRxXtGJeJyR/VMDHlDbcFIdG7jG6J9Sh0B//?= =?utf-8?q?D2VvJNAEC9N9pADhR8hrGJJjIlEY8QdcYfwgE8dgzwyVNGhhr8LN8ilTfAAJmm2I0?= =?utf-8?q?1KDJ9ID2eREd+ix68BB+oste+cYH03mjMgnolGIuf+g/Kvksstv+j2iQMW4n5G4V5?= =?utf-8?q?LUBL2yXPV3sbF6yOU4nwNty4GYYtbg2h5pLkYi+snwh4azQqrCv8Ygfuayo82C+NP?= =?utf-8?q?Xa6A80sDJaNw9TyqTRgJlm0GpU0agWzudebaoiQFeKEik7/02zFCCMQoDTHcffYTp?= =?utf-8?q?DIcp9/6AIpngf6sdJhEZE76HGE7c9XQavkSsbSX8gCzYQWQIyNSU78XgYSZzWFbBz?= =?utf-8?q?6d5AKKLGj6b8q84pvm4YIT/pn9gbLAgdWhQQoZ09QsY3MeBWG44Awt0PaOYcjPqBB?= =?utf-8?q?957Ys/QwXHr7fAW3mfgu90ex8GdhbSyNaRvp6v3ZjMJnbRljmokGCGQ57eZB42jtu?= =?utf-8?q?k1NZj1Pcl2WOmkqSL43AUAGk6vlvtAkhrWIH1sDEaGXVtpuwFt4kl9HSH35v/PcfC?= =?utf-8?q?c+dc9nyWxZ3uIixwg9oSUBT/G75btUs/tQz+f6K3NqTGgyLMz7GhuTYsWbD/EvyHw?= =?utf-8?q?9OscvlAatrV4Wu+ouWSLrcbo2Kl3KQpxzFm3vHVU4fpnnoUkhifv+gBtcMvqxZ2Jd?= =?utf-8?q?8gVGmZEgTX8waRMlTQClJ6/E1ARM8Rc5Sufyer8WOaxvQO65M6vEU1Q=3D?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?SrF5NF9iSFtz9RXGeAQuMvatJd2/?= =?utf-8?q?I+vI4h9PV8jGU7HaDqsnb+CQza9g5rrMAa3m1UHi8/zvlmkR5ydQyD0GodBTqimy0?= =?utf-8?q?ixp5ZMj3WfE099xaZPoiBUJf9NzjOu1Kn5WuCQvnLi75XMvh4FGPaheCqqT0dIwL0?= =?utf-8?q?SIoofc00ZaLB9W3GtXXRjMz8lrqqfbtUOPs2hkWvuJp7Y5GlEq9QPlCp9awiVR+zh?= =?utf-8?q?uwcD/LFSFrs+oOHi0fJmXCtDmOW6QaTlMxQw0Rm7HCFuCOoJfCh8f3gDgFsso4q1a?= =?utf-8?q?voEsb/ewyr6pd1Z0HeqBMaYhhrD5zbRuQn/ic9aw8iCMGX1s4a5hDA8pX8JdmHZ8+?= =?utf-8?q?/P1089J9/T8er+4V+I6ueodV8vy4JKi3iVC2Anz/LoQSfst3hR7BOw+D/uHoZuwey?= =?utf-8?q?btc0oE8pwDVL6FCHPF/LiRwU2CeAuNSrWz5BYJOwwSM9RijJ8pXc8cjeAk98HSL9A?= =?utf-8?q?iXvmcEUbt7af7pWaS23bcqhIttm4KdBgqwT8X8A0fo4RoG4Fi0dnVNN1otkodhltA?= =?utf-8?q?9hBooGPZBOEj/kjAC937dhmRGcKTzlhMXFBiOikonbrgvqYyLALge+d9nkQ0M9+Mu?= =?utf-8?q?StUwCcpjopcOJ0ZVH2CAfd22K7ZmbYqTDZG6E+50Q8lHIe/IspgIwGAMdNbkomAfP?= =?utf-8?q?kF7q7eUczCeBzN0jhv4/2payA/73L+ouKBnz50Dv5Ozy10bjvYuoXebmp7g2/nxk8?= =?utf-8?q?Ovjwi7IosRxwhzV+ovss/qQqZNVMQ6Ck/diIbqWQ+GPWT3eEWmjJ3sEW5vCBaCRjP?= =?utf-8?q?4EcY/nBgIQAP2Tp2dfGDKt+3TdWAInQlaMwGV5kuyx3RdT8Pcif0d2hVF1mO+O7Xh?= =?utf-8?q?xPyc1YmZZ0gm+tWODWpA/xOx48JzPRrbAbnsyzQ6kCuf8x5jSjOwT+3Gb3xNUxY+a?= =?utf-8?q?wbQpD8KYnFu9XqA+byzEgZM2zG3FKQYK8Cua2xfhutQuHXG+MaXCV6+ZMTBJ7/uc6?= =?utf-8?q?qnXmmOjFjylPGvRvZHry0K1swshL0Zq2NKpJTQy8tHddVqh6WAhwK5B1YvQ/VmQ5o?= =?utf-8?q?uSkVJRy/bI6dQjP0kPb+/VJz5C+JRGWpPqgnTkHiSvWfpflBr+Q2rTU4DEh4sZiHw?= =?utf-8?q?RH5oDBPg/rzllo51K3nDlJM9Jbwf1QdHLjEVIKElPNm1rma481w53L9AMXJRmLdoB?= =?utf-8?q?nGLF8MmPG37MPHWPbXPF8m/QkZxmwF6/Z3Udt+CfLT4zGRxXm7Ko4W6MfTq8osoP1?= =?utf-8?q?tosq2nDaIJF6qS9GjjwPlpBjezb3hhp7egYdljU5S0zfcrZaAP7DM2e+UbG1x2+Kl?= =?utf-8?q?kesV9FSNPtL0DlhS2r1D07idNNTcOiNs/hjPuSM4rM+1CrXcSjrehLA1Ae6pzALfv?= =?utf-8?q?0ImWG9vSC2bnoxZH0oCjvZNv3UAEK8vBLI89MSZyInIsAfJVgIMfagTAdi2iwGDRD?= =?utf-8?q?vr+XexCvYODGA9hMR80PGlpekF7FSY5xstGlqMrvxPT/sTWdv8MaexSoJx375oHPO?= =?utf-8?q?TyNR9i6nrWt5/Kt/vDEQWVOXsuUaeuH1cnEL75s87zsA8tPbID5FML58PUlBW5XV+?= =?utf-8?q?GcDKJfRWjDlE?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 752ceb67-d20d-4efc-4cee-08dd45805124 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:17.7282 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: zL6WspjqJXPS6S8IFRWl7g5LKLR+YmIKSG/ACkxKGdgE4A9yANxSIhX0yGmJzJLXrRg6ocm2PQPxDADRJnNYwg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165920_636127_81B69E32 X-CRM114-Status: GOOD ( 11.58 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq and devm_device_init_wakeup to cleanup the error handling code and 'driver.remove()' hook. Signed-off-by: Peng Fan --- drivers/rtc/rtc-nxp-bbnsm.c | 29 +++++++++-------------------- 1 file changed, 9 insertions(+), 20 deletions(-) diff --git a/drivers/rtc/rtc-nxp-bbnsm.c b/drivers/rtc/rtc-nxp-bbnsm.c index fa3b0328c7a255ff8a902a58d61a4b0e59eac493..d4fc9dc583d317d4852b7d897a6c45cfff6961a2 100644 --- a/drivers/rtc/rtc-nxp-bbnsm.c +++ b/drivers/rtc/rtc-nxp-bbnsm.c @@ -189,36 +189,26 @@ static int bbnsm_rtc_probe(struct platform_device *pdev) /* clear all the pending events */ regmap_write(bbnsm->regmap, BBNSM_EVENTS, 0x7A); - device_init_wakeup(&pdev->dev, true); - dev_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + ret = devm_device_init_wakeup(&pdev->dev); + if (ret) + dev_err(&pdev->dev, "failed to init wakeup, %d\n", ret); + + ret = devm_pm_set_wake_irq(&pdev->dev, bbnsm->irq); + if (ret) + dev_err(&pdev->dev, "failed to set wake irq, %d\n", ret); ret = devm_request_irq(&pdev->dev, bbnsm->irq, bbnsm_rtc_irq_handler, IRQF_SHARED, "rtc alarm", &pdev->dev); if (ret) { dev_err(&pdev->dev, "failed to request irq %d: %d\n", bbnsm->irq, ret); - goto err; + return ret; } bbnsm->rtc->ops = &bbnsm_rtc_ops; bbnsm->rtc->range_max = U32_MAX; - ret = devm_rtc_register_device(bbnsm->rtc); - if (ret) - goto err; - - return 0; - -err: - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); - return ret; -} - -static void bbnsm_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); - device_init_wakeup(&pdev->dev, false); + return devm_rtc_register_device(bbnsm->rtc); } static const struct of_device_id bbnsm_dt_ids[] = { @@ -233,7 +223,6 @@ static struct platform_driver bbnsm_rtc_driver = { .of_match_table = bbnsm_dt_ids, }, .probe = bbnsm_rtc_probe, - .remove = bbnsm_rtc_remove, }; module_platform_driver(bbnsm_rtc_driver);