From patchwork Wed Feb 5 00:58:24 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Peng Fan (OSS)" X-Patchwork-Id: 13960302 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 899E0C02193 for ; Wed, 5 Feb 2025 01:08:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Cc:To:In-Reply-To: References:Message-Id:Subject:Date:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=4PKvgjWWPKh7dNiOPG/9I2mkkmT7zG+sb/CaHgvQ5eQ=; b=3V2buG/NVIbCjFjDm+IG3NgPik suk+ZfqbfRDOoZCbbq6NckB2oNsno3exIdJrwSFb77qkXHrMQ9rxSYSKYmSJt25jJJlI9jmt5+aqx UQppVLb0+Lc5/cEU3eV45rXYQGTwYOVy5cQjplyJt7TRngLdkrtsb8hGTm46uSNWspCh5PD+rhdaW kWayD5zO4+RvRxeh3xWcP4yEdR5q4Y0X+dIFavtjoGlmprYsaHZfd6mkPNsInisKRSVD8KLHRvLPp ye+wlnWXi+daoEoZ5F3hutrvINttg2y1fp76W+mySqPBCxbU33vJdR4elvRdtCzmgoziKj4FcZH9w bo6vDVkw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1tfTuM-00000001zsY-0Dnn; Wed, 05 Feb 2025 01:08:50 +0000 Received: from mail-norwayeastazlp170130007.outbound.protection.outlook.com ([2a01:111:f403:c20f::7] helo=OSPPR02CU001.outbound.protection.outlook.com) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1tfTlW-00000001yPa-2fG0; Wed, 05 Feb 2025 00:59:43 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=CfemhTSgeU4sGGfI8Re72cBatV8DGltV2OFSZUTR1hNrm6/d8+7z4I05zuAEnDH5FVRB/Wx2on+vY5bVCgpN1RJT1HYh/1vEOGhW/qvyasDVRIxi6UW448mJoaLa1vK2279LZpPXOuzL3pXZ5cIcGCGkT8sZGN+t6aWPzCMvOYHpwaJrQh9UBWNU0dOQU3VsjiXqDZhtDjsHy3CL8XNC6VXhc6lfmwtFCa1JC5JfuUvWa8tpfjsNl3k9Ds0MiNwQLxJBA2/ByldqksU142nLM0H3pBdcVGLkPSkjV5rUpM1EAA1RbK5AfhXCY2+zd7Ul0guHuApuEAMgs5kzYcd8IA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=a9M2MvI2sQI6C/8/ygaNTEP4cSZE1O7z/DXxENYRagjXfLDk+pB7XJl33nku9GcfoZZKVOUKlEU9YVYDd/BXFolhPFAZkiM9mJc069mVzvHiCTXufxt41hFTfELJefTxCmhVRDI1IfnG2VwpkE6xHg/p2t0bswg1BbgdJ9BhrS7/PcuH5Mqem5SdO7W2dIizvS7jq7X34lUOoF+jeDehjNoVLPb96wBppj1/6/djlqv8FBg7ggoiR9KnpMTCbXs8Uu4Kw9XtcbgMhQTjk+XUBZ1l93HhU48yh24UFhQu/j8lIKQHPqXYJHCHY71p8V9fDtAaZndjjau4+4Ay3dHhhQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=oss.nxp.com; dmarc=pass action=none header.from=oss.nxp.com; dkim=pass header.d=oss.nxp.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=NXP1.onmicrosoft.com; s=selector1-NXP1-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=SsAJU3FUgsUM88m4mSGw1WR2K15UVHFt8h4YUCR7Im8=; b=P+1OefZ0diM739yPeiRBD5qtteCmV56h99Rgxpn09M38AdX3GYtnLmmOi0EfOW1hyM9yHme1J3uUXbwbyoarJTHR0GPjVgbf16rJ+plO2H/mpUWacHr8JKadSgT/YmAmjbNeSxZGVY5jwOk9EypKz0NYF6q5F/+0cFGuBqDHYi3TQjI9w8i3/YXcA0PnSEux7/PEg5+YTF5UK4uyy7k+PeWyDEyM4h64Q1mLJVE5pQ7AAzAs9bk1dQbRy9RUH5G30ionlKJ5KOhcF+LRTYwXP92jBf/IgRsFPwbODE2XUiojen0B8SsfvV1z3x6g9374LvPVoHKdhTXdhpYBxrdgfg== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=oss.nxp.com; Received: from PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) by VI2PR04MB10713.eurprd04.prod.outlook.com (2603:10a6:800:275::20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8398.26; Wed, 5 Feb 2025 00:59:33 +0000 Received: from PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630]) by PAXPR04MB8459.eurprd04.prod.outlook.com ([fe80::165a:30a2:5835:9630%3]) with mapi id 15.20.8398.025; Wed, 5 Feb 2025 00:59:33 +0000 From: "Peng Fan (OSS)" Date: Wed, 05 Feb 2025 08:58:24 +0800 Subject: [PATCH 6/7] rtc: mpfs: Use devm_pm_set_wake_irq Message-Id: <20250205-rtc-cleanup-v1-6-66165678e089@nxp.com> References: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> In-Reply-To: <20250205-rtc-cleanup-v1-0-66165678e089@nxp.com> To: Alexandre Belloni , Maxime Coquelin , Alexandre Torgue , Linus Walleij , Conor Dooley , Daire McNamara Cc: linux-rtc@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-riscv@lists.infradead.org, Peng Fan X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1738717111; l=1347; i=peng.fan@nxp.com; s=20230812; h=from:subject:message-id; bh=7sZhYfT/a75JkuPsULgAYPAtV5pnc5lWQRqy0mNIenc=; b=ZZyJ6oBnd4ebUNNhIlVXgX+8rb9tbIafnXdCmfQxVegqmYR6Bau7iTLyWNEhAI0R91LFHHApT LE9qzTrd3U7BRiDAm+bXrNBCS4cu5UMLf523JpJJEsXVHDzxwY1rRzh X-Developer-Key: i=peng.fan@nxp.com; a=ed25519; pk=I4sJg7atIT1g63H7bb5lDRGR2gJW14RKDD0wFL8TT1g= X-ClientProxiedBy: SI2P153CA0034.APCP153.PROD.OUTLOOK.COM (2603:1096:4:190::17) To PAXPR04MB8459.eurprd04.prod.outlook.com (2603:10a6:102:1da::15) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: PAXPR04MB8459:EE_|VI2PR04MB10713:EE_ X-MS-Office365-Filtering-Correlation-Id: 28d5cc0d-d4e7-48f0-0dbb-08dd45805a56 X-MS-Exchange-SharedMailbox-RoutingAgent-Processed: True X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|7416014|376014|52116014|366016|1800799024|38350700014; X-Microsoft-Antispam-Message-Info: =?utf-8?q?qCwVQfQ9yLKFqZ3TXVJAo5RK5LcrnAS?= =?utf-8?q?H30caXKggrju2cpN8zyv+FSLDPiqcb1EdX78L2dd4C0NVj3YgJG9Yu6b7nbgDAXLY?= =?utf-8?q?QWIXJnhXtC6pEUH1cXda//LpwhFkdq33gwHVZpJULKDyzerPfQcOAcFB1kIr8w6/W?= =?utf-8?q?dn9k9WXngqwKAMDMl9jMdLcX1FinbX9aCnhpEst32F5yo6TmcWjDBeo0KH0TfEmb1?= =?utf-8?q?1NJN/XEyPdcJZKOr0UnDFqM6o+n4GbRI9SWNOwVSHwj/sJ7XKMIIGeUbF8+qChWmm?= =?utf-8?q?U5wJj5zGQyeX40loLPccejcC51s9ztR47UQq27ZkQzzfSEVPZ+8Bi+liV1dCAtmoC?= =?utf-8?q?peyD8fNQdLc4dyWGfZvWrrSRFsg6a0bS0wFmOYAoGADU17PHlba/zdGcVyNYQgiLy?= =?utf-8?q?45sWotDrX669AeW29qoRKa1fyW5gH9uh2BxF+CFdiuZ1QBsgWFL4bUUVEnRFvL9vg?= =?utf-8?q?8qy2W+02R1arLqaA9rcAUklkPSMnn6Si0+rLjvZ/jYBOS1P/kkcJ0eTNYfk5lKV34?= =?utf-8?q?1faTFnhOByhyPOzXcb6i9+qMJXxus8elnePJvX4xMUJ2Yth4f6mz/wgG3RwUDfx6E?= =?utf-8?q?rvbsKRKS97ZfFYzU6a0UnahFYHSFTyfAHRqdcdKmEc0rdnBR+GXjXYqfp+cVpzcOT?= =?utf-8?q?Pl+JKZgfwOPF/4J8Q8HpTXqhKWiAe2+C9+Wozi5fZq1DeYUYCSEqpjnljrbaEHQB5?= =?utf-8?q?OwGvYdmE3RDZptU0mgn5fzypwwXykkwNk13+/1oWjEmlVNFvvVrvaIWlW56tLddnH?= =?utf-8?q?PFYoC4EqhV7ml8F9g+zKbb3nMp+0tMW66xaU3zsXC77nbYhXGkdbJPawwUsxWPQ0v?= =?utf-8?q?9kbkHH3nf8nDQeqQKpkqBLPRz4HaeUh3YKFcesfPMNkZq9z96vLMoym7LPCEpKasU?= =?utf-8?q?QERo29FnskA7wyasf+iq+I0qHQ5UCa+tqnod/qdRquCGJPTpA3zKrOc1HVoTe8lkF?= =?utf-8?q?T1BhbsTVXCen5pSp3YO3JfQwKkO03uvbCFUIFasR3ePkS8I6If5x3ukuWHHtDpvMQ?= =?utf-8?q?5mk4gPUdzxejcdXx4zw2ppGqGQDvfnwkPCX23JxcwGnKeZgK73U06Fh8jxq5jF/li?= =?utf-8?q?dz8BwJ66kVa+vuISdMuYPrIiZCDgImkbq0Yr1R8Qv2WShjwwkTpst6H/VuRVqyU5m?= =?utf-8?q?7HD1Tuyl6b1Xv6c2w3UA5u2wKznmglCE02URKFN5yDLxvLUleKeBtH1d9k3dGZKK7?= =?utf-8?q?fRa+XmNlxQ2hgO2wTywcnU3y8CikFdTIqqBfKo3EGQwXZOS+2+40SI2ILhtdnAPr4?= =?utf-8?q?RfoKS63murs6/PdGt3FopO7tCo/PLEXwrmotx1wkgqGkBvVRgmR0KLIDCha1xDffe?= =?utf-8?q?ivb3x7gzz6MlOUgNSOO4KkQaFWxgjo0BRI9xwNlcFfHkHth0FHvZZkyXQIB2+MtZM?= =?utf-8?q?5l1Vgl8gbBb?= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:PAXPR04MB8459.eurprd04.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(7416014)(376014)(52116014)(366016)(1800799024)(38350700014);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?q?v0ISy84DXz2B54Niu4eWWVAEVECu?= =?utf-8?q?mmOCM7I0SrJXPSmLtQaiaI7L22C55EmYQCiBaN30aa3XHiNNZ6rqFcgKC/nK1GBMq?= =?utf-8?q?5eh8q1US3Edi+kCKbudeknuVt9vUWz1GlxbHaW7c+UDIaEPelHdvAy9O9jsVt6rci?= =?utf-8?q?9sQ7Zmg7t7iaoXDikB9+UB0YFdau1Lier4GEue0xtDjmZyw6kBhgO/1358wHwFFk4?= =?utf-8?q?iS3Q9TPvRSR2MGOby/MIQJ4eCFz2Y7eg7p21m2wYUf41emM+dpgLFNefCHUEUWytg?= =?utf-8?q?C4No/Qvu/r/kx5SRa2NumDKkBlc93e1u7JZ2ZHMcjm1LKUO233HFn7nvaIa6+tMiz?= =?utf-8?q?n60LPb3YefmImSLVOJ4egD2D4cOGICbnBrLi3+XBjnuUX9sDsBpVqq8+5MfRqHAQb?= =?utf-8?q?v3EEsHIjwRQ7SSBb0C3t+cc4eRLB8sTm1hAuexHksBlPKoI/s0SFt9jkXNyRKDfqZ?= =?utf-8?q?vg3M3e1anr1XNXDviVCRU645dt3EOMY81pmzAXq5U+tzmMZRPlpCUh6pgbkKLuEKR?= =?utf-8?q?5/jOSFgk/IEpp1qrNLk4r9JPDMYunUiaeb+6GnV6a5Wz+NZnTuBjhUQ4bWYrnIsyo?= =?utf-8?q?9gJtJpUK8Ygke2XQA0pHKqws2VN8xk/qP4H8yWBtECnDa92edI0ULjQOnsKFmexZz?= =?utf-8?q?CWycgLCAHY3YkZnkYrCzgE29GOLsK9QwJAkc3npouo7YveYypvwjzA5YbSs0gSpg4?= =?utf-8?q?gROXXz2vgZoAx0hCdRXkbgQEIBeBwfjQsf4uLxJ5/TaW4JLp7F3sej0rZIQT4iVSV?= =?utf-8?q?DTCGmKU+3QedHYlUXjRgFmlIKXc4siP5jXbXJOeMKzMcJFEzq1XlaC2aZ/Fovij6E?= =?utf-8?q?UPB8/yQgLFzj0begEB/RsbV2AoGpyx0Q/0RUiMViHGLg0OAo2Nf7AwNxgcC5xKuNJ?= =?utf-8?q?9Zf2g9OFLy9olCjanT9KzBGk1UCXfiAIu94BJ5a6adMt4PjBO+52paa9saiD5dLX2?= =?utf-8?q?0Yi/GPZtj5jEYE4w7+acK6qqMMRuGZR+UjnOuxXzxmi3EwYQMTUT2bP2Rydi7fmx5?= =?utf-8?q?Jqhe8RMRCVXydaElkukdjpoHqoEe8QVxtsuQPbILyjdN5DDvs2exNksGh/gZAMV8s?= =?utf-8?q?jAjj1RU6MzxYWiH6kXkCqzqSFsMcKc4JKSrFEmcLQYBRD4oW2cZqAy3Pv9QDKUbNZ?= =?utf-8?q?DmksHkhz0J5tgIXyPD8KGOt6z725q9X3HflQ2dr6zy1MIrd2192WQxuyix4xtU21c?= =?utf-8?q?2TvzmbHQn+OGF69SD6I2qsT0FDIhNAP4CHwU5h1x+EWboCALiQVw/xnOa/3yhUOx3?= =?utf-8?q?EltTCE4Z9Bm+2BrBatrdGEm4yGN1NI+Pokw0tj4LMF5s8niXBfeI0gU2xT189/h3R?= =?utf-8?q?WXd/3qdbowlYr2UwL5uKkcnbAR3Y6WScG2q9NbQEyeXQ19idaM2pQtcO/ckQzOZVM?= =?utf-8?q?7w8bnDsB579puDuVL1VOYz19asNabNAc8hksuQacX5cVl5tG61mHVAUKpT43zT1fu?= =?utf-8?q?kM80hKJa6677bA/40YbTVuUSR5aPpT3xd2BrgphUIW9F9W6viKqjjE5EktvWHsqZj?= =?utf-8?q?7pMHo1gUvj9D?= X-OriginatorOrg: oss.nxp.com X-MS-Exchange-CrossTenant-Network-Message-Id: 28d5cc0d-d4e7-48f0-0dbb-08dd45805a56 X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8459.eurprd04.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Feb 2025 00:59:33.1380 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635 X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: Egsm4Fg8ym7JJhPoaUC7uTQB5XsKHT95YEQ9DBL8mwasmxKv8UcFlWZNkcobBKS6n+gxSveulntB2MmLZhgO9w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI2PR04MB10713 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250204_165942_681949_3A879467 X-CRM114-Status: GOOD ( 10.50 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org From: Peng Fan Use devm_pm_set_wake_irq, then the 'driver.remove()' could be cleaned up. Signed-off-by: Peng Fan --- drivers/rtc/rtc-mpfs.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/rtc/rtc-mpfs.c b/drivers/rtc/rtc-mpfs.c index 3892b0f9917fa7bc4f732cfe2c2b2f548ba7429f..5a38649cbd43b3c6f2fec5db95c4f0013deb2a08 100644 --- a/drivers/rtc/rtc-mpfs.c +++ b/drivers/rtc/rtc-mpfs.c @@ -267,18 +267,13 @@ static int mpfs_rtc_probe(struct platform_device *pdev) dev_info(&pdev->dev, "prescaler set to: %lu\n", prescaler); device_init_wakeup(&pdev->dev, true); - ret = dev_pm_set_wake_irq(&pdev->dev, wakeup_irq); + ret = devm_pm_set_wake_irq(&pdev->dev, wakeup_irq); if (ret) dev_err(&pdev->dev, "failed to enable irq wake\n"); return devm_rtc_register_device(rtcdev->rtc); } -static void mpfs_rtc_remove(struct platform_device *pdev) -{ - dev_pm_clear_wake_irq(&pdev->dev); -} - static const struct of_device_id mpfs_rtc_of_match[] = { { .compatible = "microchip,mpfs-rtc" }, { } @@ -288,7 +283,6 @@ MODULE_DEVICE_TABLE(of, mpfs_rtc_of_match); static struct platform_driver mpfs_rtc_driver = { .probe = mpfs_rtc_probe, - .remove = mpfs_rtc_remove, .driver = { .name = "mpfs_rtc", .of_match_table = mpfs_rtc_of_match,