From patchwork Mon Feb 10 21:35:38 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 13969370 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C014C021A8 for ; Mon, 10 Feb 2025 21:45:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=QnOzHhz8qaCLkngZELQRgoKXDdy+YDHVIXc0e/H6XNw=; b=UUdR19RY7VS/fC dpnj46lw3x6fSSnLiWYron2ig8c105hT83NwqEVfGzw5dI4TS30uM1NloJCmbRin8y+h4la1yFuT7 6JBkJBbt/WH4lR+oFwP9wcXFEIubY0/9xcPX6DIZG3DVjwhP5VYOPIunP10hqHsNDEMLEcd+hDD9L JN7kYNB1NgHn9l05e1N4fjCkOXyrIHmFlrWrhGdyiVDULf20ZDsDKzLTdl6yEGX9DRJu/kdPfCpqy ITs7S/w7xxIn5CHGJ00IdjETW+7VJRPDcf4h7JtvueIBDTolenk+xd+3DouMgjNC3HO4kenHFKBfz rbLV1G+wxJhCKq1dBVYw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1thbaz-00000001YMY-3tZW; Mon, 10 Feb 2025 21:45:37 +0000 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1thbRr-00000001VNK-31DQ for linux-riscv@lists.infradead.org; Mon, 10 Feb 2025 21:36:12 +0000 Received: by mail-wm1-x330.google.com with SMTP id 5b1f17b1804b1-4394036c0efso10719945e9.2 for ; Mon, 10 Feb 2025 13:36:11 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1739223370; x=1739828170; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FqqX7ElFp9wIqiTogqx4ZkugO9mCs5sfeq9wlnFties=; b=C92dpNh3YKxBw+2lvVm69nMEZ27S+YrmYuaFmXg+E0UkcSRF8hMFyL/DltJ8GkJqc6 1oy0WwLU425NC2k7Z5m8paKAw7RXn5S6IJc/Re3M5H6L1Y9Ohhwy6iXkT6SNWMh+VK1I vb+E/desjOe7w5R7iFIveunCxMWEsXryQYJn9oF/sCqLe8NRmm6nfjPjasPkpT9aReAx qcBxYHERNnQJrWmmj11aP1Oi6Eh/mc3735ghcvOs7eBUofrHGj/A/c4b3yTrZvkTYCS4 pD4Qp8FQ8uR0nkVXtWztPqMj+x0CYiAXzHHnmheVhqJOMtDcg4qIf8G7y8z+zenM/TAE ZDEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739223370; x=1739828170; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=FqqX7ElFp9wIqiTogqx4ZkugO9mCs5sfeq9wlnFties=; b=rlLY68+iiH8NSm5pv6+fAYNrbKZ6TNzCTc7qfoygJ2Emlkm7mWJHWk48Ch8gtqIXyz pRHbiURSk60KdF6hY54SZE3hb+lE8Kjesv5y+gUQQoR+NMPMd/MzD4qeEdlAydIvkDtZ g5Q9LPPqELrx7KdfQlN7DWu7N/h20eoapcUL8eVHHnzttw/TOVuJr5dp+NGJpA1IDNkR bjYvQJW/pwi2YbeM+LlZzROlDmzQmNuTMd/tO1j3vh0RxY3TJ4e3LYKsCaWw632O+/Ju LTZSSMVXwvo6sliuWs+nb8s7C4MSprfriiBA32c/Hy+fo9Afn+o32ohsY8R1V4/D336L oUNw== X-Forwarded-Encrypted: i=1; AJvYcCUQckG6DqoBpDOtzgMexE+04NKMWb1joHQI9un/sDWrGt1t53rQZEtrRMSDQt63pl+OBnklYQDzxdnNjg==@lists.infradead.org X-Gm-Message-State: AOJu0YzS+aE6g7m0eW1MK/jqx8IwUaIoiRUYkz2VFko1u/MTIEIATp8a PrcYk6JXJgVNhh+xEB6Poof8f8kjlxD17Q67r7CzrDIY5uMVTgnz6bi+UxM6iuE= X-Gm-Gg: ASbGncv+ehiFQZNhjcusacghcfG+EQ20md8Uj1tlVW9oPAK1lz2tFi5M+HL4RGksQdp YAD1fLTt3Qt+Nq3Hv6cj4sf7kAQSn8jNFn+EHim/bXlel5Lt/hVmuoRGZq/Rl0YMXI/pDcVMShI RKtXbgyYPsh9LabfGtsz4CjwjrngvQjWSWShi/fancHkw5w8b4IxITHGjHJZeWaWstLE+Qdfukk DsqSxSBN5qVY/NwvvficQ0VKdz1pnKwjCCKMgL2VYtmLhOugs2QVughYxPc8gEihkVfSwQWBbRd qT0ZFsd/dNBMtCKa X-Google-Smtp-Source: AGHT+IEI+PbDSd+iZWI542rdQ+gdbkP59WcT5edYepFvbp4hadsR2YRTr4AHJJDYEwdy2nUI6Xz3fQ== X-Received: by 2002:a05:600c:8706:b0:439:350a:ab52 with SMTP id 5b1f17b1804b1-439350aacbemr92952605e9.30.1739223370401; Mon, 10 Feb 2025 13:36:10 -0800 (PST) Received: from carbon-x1.. ([2a01:e0a:e17:9700:16d2:7456:6634:9626]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4394376118esm47541515e9.40.2025.02.10.13.36.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 13:36:09 -0800 (PST) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Cc: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Samuel Holland Subject: [PATCH v2 05/15] riscv: misaligned: move emulated access uniformity check in a function Date: Mon, 10 Feb 2025 22:35:38 +0100 Message-ID: <20250210213549.1867704-6-cleger@rivosinc.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250210213549.1867704-1-cleger@rivosinc.com> References: <20250210213549.1867704-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250210_133611_796255_BDF19F40 X-CRM114-Status: GOOD ( 11.88 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org Split the code that check for the uniformity of misaligned accesses performance on all cpus from check_unaligned_access_emulated_all_cpus() to its own function which will be used for delegation check. No functional changes intended. Signed-off-by: Clément Léger --- arch/riscv/kernel/traps_misaligned.c | 18 +++++++++++++----- 1 file changed, 13 insertions(+), 5 deletions(-) diff --git a/arch/riscv/kernel/traps_misaligned.c b/arch/riscv/kernel/traps_misaligned.c index 57ded7e74dd8..7d6185deea33 100644 --- a/arch/riscv/kernel/traps_misaligned.c +++ b/arch/riscv/kernel/traps_misaligned.c @@ -673,10 +673,20 @@ static int cpu_online_check_unaligned_access_emulated(unsigned int cpu) return 0; } -bool check_unaligned_access_emulated_all_cpus(void) +static bool all_cpus_unaligned_scalar_access_emulated(void) { int cpu; + for_each_online_cpu(cpu) + if (per_cpu(misaligned_access_speed, cpu) != + RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED) + return false; + + return true; +} + +bool check_unaligned_access_emulated_all_cpus(void) +{ /* * We can only support PR_UNALIGN controls if all CPUs have misaligned * accesses emulated since tasks requesting such control can run on any @@ -684,10 +694,8 @@ bool check_unaligned_access_emulated_all_cpus(void) */ on_each_cpu(check_unaligned_access_emulated, NULL, 1); - for_each_online_cpu(cpu) - if (per_cpu(misaligned_access_speed, cpu) - != RISCV_HWPROBE_MISALIGNED_SCALAR_EMULATED) - return false; + if (!all_cpus_unaligned_scalar_access_emulated()) + return false; unaligned_ctl = true; return true;