From patchwork Mon Mar 10 15:12:17 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= X-Patchwork-Id: 14010359 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A3013C282EC for ; Mon, 10 Mar 2025 15:47:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=6OzlSLmEDxmTZGGOWjgBQ1lVLRqdyG9JO3abRrCdyvI=; b=TxnRosY7cWb3Xu J+b0pFPcDeLuAH+LHpdWd8P0OhvGVdHDajg3AjFSZRiGcp5wARophtgMQAjesfxF5ldXzWCjjCLWt GtUjeTCHVX0f8cohvqZy17e667E9dRRXT2zjjdEqYXgUWyBySMfAWNO7bSCXiuzBbpYmkJzg9dCFq IUpesNkD0+2rWp62o6O+vcnqY+saM4MoBSx8WlC+V+iBM5+i/PgGumOsDeKDovjkQIzbjHAo7uv/+ 2WkC2+ZePFYqnjmPb/I0GY8SKkbdi1qck1AyAl+Y7lzWe5F5pPNyrYMO5GMqGuUA0iz0Es5YPPp24 yDfLvMRPNDXxyx62WXUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98 #2 (Red Hat Linux)) id 1trfM0-00000003G57-0386; Mon, 10 Mar 2025 15:47:44 +0000 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]) by bombadil.infradead.org with esmtps (Exim 4.98 #2 (Red Hat Linux)) id 1trepX-000000037uU-2PiP for linux-riscv@lists.infradead.org; Mon, 10 Mar 2025 15:14:12 +0000 Received: by mail-pl1-x631.google.com with SMTP id d9443c01a7336-224171d6826so64657555ad.3 for ; Mon, 10 Mar 2025 08:14:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=rivosinc-com.20230601.gappssmtp.com; s=20230601; t=1741619651; x=1742224451; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=NTEMNxwWUDdJDHTSWR5BaYosnBDapUg7Ev6g031TeV8=; b=vzcM28pMTpXkhcHmcZMbN2IN45ck0WszXVk1M1epcpQo4mbTBXF8SUPZRoLusYJqwb 6bIau4KoFN2xPqFtmAb4Rfljv5Rhlu8Cl2kcHSH4XnNljo+4tHysaacZuUFijadXUWW+ fkMUbdwA4mapF3zhYWcmrxKlbnmsxb5SzCNtNdg7WkeUqGrZTFNaSBmOg/GGLLaR+p05 4DqTypIeEy028tNiC0ub97pGyOpF+1kt7RxFBKOVL60eh5+ohVTLP4pFd/0rXS8QPdrO /R712on6+oMXgBGU5uX2oL1tdll5LAGI7xeqx0DOepYZ1TuJ9Is1fMktPDHwowKLU1Cz wuAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1741619651; x=1742224451; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=NTEMNxwWUDdJDHTSWR5BaYosnBDapUg7Ev6g031TeV8=; b=G/Si9B/T6MVul8EG67xuZ3h+gGnLtkNmAkYR2zRZ56O9Pr8YHVCjKpedCCsYIesvfJ gAHUrdVDdFBaoS+BtoKfzz3LutYVMp4FCEFPlULGLQYE8onE4QhWnjsaXDouLVuEi2Wb Kz+jGt+RSrYtWmLZGy73/0r5VSlgqKLao6dsmJ9j6b5GrDd90RLuuleWhqwP0Jfn++6u Q1bZwGpiY4Toz5uDJTBeqGEGxCjJn1v5bbE4jujbwOrRvaB6YITz3Ls/hLGwERo1MkwX l0V7UUnaCCEwAK4ThSsRXEoJwtoArndQ7yKIvjlzKiyDKmACMj0NPYH/e+1BMGhy88vE xWUw== X-Forwarded-Encrypted: i=1; AJvYcCVwETMPNEiWo++6HH6Nze2OJRitEAT9t5BgUGwIgFoMydn/h4HBXBovngnsxrZC1nRd/qhkM1zYHAXqUg==@lists.infradead.org X-Gm-Message-State: AOJu0YxRjRxGZRQM1Xc6opE/BI35pal2CshgvUN8QGhPlvX8KkJYjjO2 BylKH+JGn81svI5sSbJft8HCnJYSvTSymNzT7g17aE9w8zNVv3ZYgiQXDZSXIks= X-Gm-Gg: ASbGncuO93soNp2htBvfS3ytQ67yL2XHMnkrU0qZwS9488V4uGgNUtkbhQ0nwD7FVua 7ZmqGEW8YYcdpQsF66rDsUS+jisI+B1fG5yfEhYnCXtbjsIOcG/XFAdbuMy/ITg/F1lTJ33eJUA 7+LJYAlkYCT0ijxsRrpVbc1g6ai/h8utSQl9u73SF2lrt0jKB6p2TQHY0bBHrhQnu+xDYKhBYfK +WTTamCn1PTVH7IUqYSKg6Acl+Yl/cFtzdW1wEQke6WL0DKk7Nt06M5FYrg4IkpZPgY+ng6G3J3 EffqpoMdUKcc4ce3QChXIQr4H7hO2HbIteM/gha8hZ5NTQ== X-Google-Smtp-Source: AGHT+IFrDg0cMkxcg3xxzzqPCaOQUBTnQwFpZHXCVcuWzC1x8fPkcfYHuG4bXSCleAdszR5qGgJy/A== X-Received: by 2002:a17:902:d54e:b0:224:1ce1:a3f4 with SMTP id d9443c01a7336-2242887b415mr253277735ad.1.1741619651099; Mon, 10 Mar 2025 08:14:11 -0700 (PDT) Received: from carbon-x1.. ([2a01:e0a:e17:9700:16d2:7456:6634:9626]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-224109e99dfsm79230515ad.91.2025.03.10.08.14.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Mar 2025 08:14:10 -0700 (PDT) From: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= To: Paul Walmsley , Palmer Dabbelt , Anup Patel , Atish Patra , Shuah Khan , Jonathan Corbet , linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, kvm-riscv@lists.infradead.org, linux-kselftest@vger.kernel.org Cc: =?utf-8?b?Q2zDqW1lbnQgTMOpZ2Vy?= , Samuel Holland Subject: [PATCH v3 10/17] riscv: misaligned: enable IRQs while handling misaligned accesses Date: Mon, 10 Mar 2025 16:12:17 +0100 Message-ID: <20250310151229.2365992-11-cleger@rivosinc.com> X-Mailer: git-send-email 2.47.2 In-Reply-To: <20250310151229.2365992-1-cleger@rivosinc.com> References: <20250310151229.2365992-1-cleger@rivosinc.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20250310_081411_613761_16BC0456 X-CRM114-Status: GOOD ( 10.70 ) X-BeenThere: linux-riscv@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-riscv" Errors-To: linux-riscv-bounces+linux-riscv=archiver.kernel.org@lists.infradead.org We can safely reenable IRQs if they were enabled in the previous context. This allows to access user memory that could potentially trigger a page fault. Signed-off-by: Clément Léger --- arch/riscv/kernel/traps.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/arch/riscv/kernel/traps.c b/arch/riscv/kernel/traps.c index 55d9f3450398..3eecc2addc41 100644 --- a/arch/riscv/kernel/traps.c +++ b/arch/riscv/kernel/traps.c @@ -206,6 +206,11 @@ enum misaligned_access_type { static void do_trap_misaligned(struct pt_regs *regs, enum misaligned_access_type type) { irqentry_state_t state = irqentry_enter(regs); + bool enable_irqs = !regs_irqs_disabled(regs); + + /* Enable interrupts if they were enabled in the interrupted context. */ + if (enable_irqs) + local_irq_enable(); if (type == MISALIGNED_LOAD) { if (handle_misaligned_load(regs)) @@ -217,6 +222,9 @@ static void do_trap_misaligned(struct pt_regs *regs, enum misaligned_access_type "Oops - store (or AMO) address misaligned"); } + if (enable_irqs) + local_irq_disable(); + irqentry_exit(regs, state); }