| Message ID | f6512cc50dc31a086e00ed59c63ea60d8c148fc4.1637023980.git.plr.vincent@gmail.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | riscv: dts: sifive unmatched: Name gpio lines. | expand |
Hi Vincent, Am Dienstag, 16. November 2021, 01:52:56 CET schrieb Vincent Pelletier: > Follow the pin descriptions given in the version 3 of the board schematics. > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> when sending a patch series with "git format-patch -6" and friends will automcatically generate x/y additions like "[PATCH 1/6]" and so on. Please try to keep them around when sending, as automated tools for patch handling like "b4", stumble when they encounter a patch series without them. In this case a b4 am f6512cc50dc31a086e00ed59c63ea60d8c148fc4.1637023980.git.plr.vincent@gmail.com [first patch in the series] will actually only retrieve the last patch "[PATCH] riscv: dts: sifive unmatched: Link the tmp451 with its power supply." as it thinks it's a new version of the first one. Thanks Heiko > --- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > index 4f66919215f6..305a086e5207 100644 > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > @@ -245,4 +245,8 @@ &pwm1 { > > &gpio { > status = "okay"; > + gpio-line-names = "J29.1", "PMICNTB", "PMICSHDN", "J8.1", "J8.3", > + "PCIe_PWREN", "THERM", "UBRDG_RSTN", "PCIe_PERSTN", > + "ULPI_RSTN", "J8.2", "UHUB_RSTN", "GEMGXL_RST", "J8.4", > + "EN_VDD_SD", "SD_CD"; > }; >
Hello, On Tue, 16 Nov 2021 10:39:04 +0100, Heiko Stübner <heiko@sntech.de> wrote: > Hi Vincent, > > Am Dienstag, 16. November 2021, 01:52:56 CET schrieb Vincent Pelletier: > > Follow the pin descriptions given in the version 3 of the board schematics. > > > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> > > when sending a patch series with "git format-patch -6" and friends will > automcatically generate x/y additions like "[PATCH 1/6]" and so on. > > Please try to keep them around when sending, as automated tools for patch > handling like "b4", stumble when they encounter a patch series without them. Actually my intent was to not make this a series, as in my understanding independent patches should/may be submitted separately from each other. They just happen to be stacked, and in this order, in my working copy, but should not functionally have any dependency on one another (I believe they should even apply cleanly in any order). It is only after sending that I realised that git send-email --no-thread [...] v5.16-rc1..riscv_for_upstream still decided to thread the emails... Which indeed makes my use of "--no-numbered" a mistake. Sorry for not checking --dry-run output more closely. > In this case a > > b4 am f6512cc50dc31a086e00ed59c63ea60d8c148fc4.1637023980.git.plr.vincent@gmail.com > > [first patch in the series] > will actually only retrieve the last patch > > "[PATCH] riscv: dts: sifive unmatched: Link the tmp451 with its power supply." > > as it thinks it's a new version of the first one. > > > Thanks > Heiko > > > --- > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ++++ > > 1 file changed, 4 insertions(+) > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > index 4f66919215f6..305a086e5207 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > @@ -245,4 +245,8 @@ &pwm1 { > > > > &gpio { > > status = "okay"; > > + gpio-line-names = "J29.1", "PMICNTB", "PMICSHDN", "J8.1", "J8.3", > > + "PCIe_PWREN", "THERM", "UBRDG_RSTN", "PCIe_PERSTN", > > + "ULPI_RSTN", "J8.2", "UHUB_RSTN", "GEMGXL_RST", "J8.4", > > + "EN_VDD_SD", "SD_CD"; > > }; > > > > > >
On 16/11/2021 01:52, Vincent Pelletier wrote: > Follow the pin descriptions given in the version 3 of the board schematics. > > Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> > --- > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ++++ > 1 file changed, 4 insertions(+) > Please do not end the subject line with a dot. Best regards, Krzysztof
On 16/11/2021 11:17, Vincent Pelletier wrote: > Hello, > > On Tue, 16 Nov 2021 10:39:04 +0100, Heiko Stübner <heiko@sntech.de> wrote: >> Hi Vincent, >> >> Am Dienstag, 16. November 2021, 01:52:56 CET schrieb Vincent Pelletier: >>> Follow the pin descriptions given in the version 3 of the board schematics. >>> >>> Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> >> >> when sending a patch series with "git format-patch -6" and friends will >> automcatically generate x/y additions like "[PATCH 1/6]" and so on. >> >> Please try to keep them around when sending, as automated tools for patch >> handling like "b4", stumble when they encounter a patch series without them. > > Actually my intent was to not make this a series, as in my understanding > independent patches should/may be submitted separately from each other. > They just happen to be stacked, and in this order, in my working copy, > but should not functionally have any dependency on one another (I > believe they should even apply cleanly in any order). > This should be a series because the patches, even though independent, are logically connected/grouped as one work. Best regards, Krzysztof
diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts index 4f66919215f6..305a086e5207 100644 --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts @@ -245,4 +245,8 @@ &pwm1 { &gpio { status = "okay"; + gpio-line-names = "J29.1", "PMICNTB", "PMICSHDN", "J8.1", "J8.3", + "PCIe_PWREN", "THERM", "UBRDG_RSTN", "PCIe_PERSTN", + "ULPI_RSTN", "J8.2", "UHUB_RSTN", "GEMGXL_RST", "J8.4", + "EN_VDD_SD", "SD_CD"; };
Follow the pin descriptions given in the version 3 of the board schematics. Signed-off-by: Vincent Pelletier <plr.vincent@gmail.com> --- arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ++++ 1 file changed, 4 insertions(+)