From patchwork Tue May 28 17:02:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 10965479 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CA4596C5 for ; Tue, 28 May 2019 17:03:28 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B36ED28673 for ; Tue, 28 May 2019 17:03:28 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A7CAF28715; Tue, 28 May 2019 17:03:28 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4418628673 for ; Tue, 28 May 2019 17:03:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=mZKTF9/NtguAF3g0eA4tjji/Wu/thEz4eqm+u9ayS7g=; b=cWo3udBmczmlZW GduQuHq1lK01kDMMhiJqdjaLNWBOe7rWNio8UtS4EwfHEH+q2ERwxs9hnC3aw5GDwDBPd+2i+/rTu s1pbdmEmHZibI7hdRa6yqt6o8bGwWeFVq4ap+1BcVWkmjrVB81F8q2yI7pNK267U8+6nLyIo00fuI TlPx+LITwYhaP4lqhjMBUrbULU1hG9Cu81qbjgDYXjC1r7/bg1zn9dLoebJzIjAUmewaSMhd5bntm X4Mbxw3BxumJ6mh9U7BC3E9WlhcC+1MYFjKU4OFt7v5KKo3HPgUnrSinxH+3p9QaHlBqAyWEu4E/Y VRcm65PMi6/Brpqr8Ong==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVfVU-0007QI-Uv; Tue, 28 May 2019 17:03:24 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hVfVR-0007Oh-8m for linux-rockchip@lists.infradead.org; Tue, 28 May 2019 17:03:23 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: ezequiel) with ESMTPSA id 68018263952 From: Ezequiel Garcia To: linux-media@vger.kernel.org, Hans Verkuil Subject: [PATCH v6 00/16] Add MPEG-2 decoding to Rockchip VPU Date: Tue, 28 May 2019 14:02:16 -0300 Message-Id: <20190528170232.2091-1-ezequiel@collabora.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190528_100321_616828_7B3B18FD X-CRM114-Status: GOOD ( 12.29 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Nicolas Dufresne , Heiko Stuebner , Jonas Karlman , Tomasz Figa , linux-rockchip@lists.infradead.org, Boris Brezillon , Philipp Zabel , kernel@collabora.com, Ezequiel Garcia Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This series introduces the decoding infrastructure that will be used to add support for other codecs such as VP8, VP9 and H.264. The driver is exposes two video device nodes, the encoder being /dev/video0, and decoder /dev/video1. Both devices are associated to a single memory-to-memory queue, and same media device /dev/media0. This work has been possible thanks to Jonas Karlman, who did the initial MPEG-2 decoding work and also got mpv+ffmpeg working using the Request API. Patchset applies cleanly on top of: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.3c For those wanting to test, please find a branch here: http://git.infradead.org/users/ezequielg/linux/shortlog/refs/heads/vpu-mpeg2-v6 Future plans ------------ Once this series is merged the plan is to rename the driver to Hantro VPU, and add support to i.MX8, and then add VP8 and H264 decoding support. v6: * Change fill_fmt() helpers to accept only user-defined sizeimage, but not bytesperline. * Add RK3328 support, contributed by Jonas Karlman. v5: * Add helper to clamp height/width based on frmsize * Modify fill_fmt() helpers to keep user-defined sizeimage/bytesperline when they're big enough * Fixed a bunch of problems reported by Hans (see per-patch changelog for more details) v4: * Fix issues in the probe/remove path preventing the driver from being unloaded/reloaded (Jonas) * Rework the media controller registration code to simplify the error/remove path (Boris) * Split the MPEG2 patches (one adding the generic code and one patch per platform) v3: * Share more code between the encoder/decoder logic (VB2/V4L2 interface implementation) * Add a patch to support MPEG2 decoding on RK3288 (Jonas) * Several fixes/improvements all over the place (see changelog in each patch for more details) v2: * Fixed some minor issues brought up by v4l2-compliance. * Fixed bytesused wrongly assigned 0 on the MPEG-2 decoder. * Addressed comments from Hans and Tomasz on the pixel format helpers. Boris Brezillon (8): media: v4l2-common: Fix v4l2_fill_pixfmt[_mp]() prototypes media: v4l2-common: Add an helper to apply frmsize constraints media: v4l2-common: Support custom imagesize in fill_pixfmt() rockchip/vpu: Use v4l2_apply_frmsize_constraints() where appropriate rockchip/vpu: Rename rockchip_vpu_common.h into rockchip_vpu_v4l2.h rockchip/vpu: Move encoder logic to a common place rockchip/vpu: Provide a helper to reset both src and dst formats rockchip/vpu: Prepare things to support decoders Ezequiel Garcia (4): rockchip/vpu: Open-code media controller register rockchip/vpu: Support the Request API rockchip/vpu: Add decoder boilerplate rockchip/vpu: Add support for non-standard controls Jonas Karlman (4): rockchip/vpu: Add infra to support MPEG-2 decoding rockchip/vpu: Add MPEG2 decoding support to RK3399 rockchip/vpu: Add support for MPEG-2 decoding on RK3288 rockchip/vpu: Add support for MPEG-2 decoding on RK3328 drivers/media/v4l2-core/v4l2-common.c | 90 ++- drivers/staging/media/rockchip/vpu/Kconfig | 1 + drivers/staging/media/rockchip/vpu/Makefile | 7 +- .../media/rockchip/vpu/rk3288_vpu_hw.c | 59 +- .../rockchip/vpu/rk3288_vpu_hw_jpeg_enc.c | 2 +- .../rockchip/vpu/rk3288_vpu_hw_mpeg2_dec.c | 261 +++++++ .../media/rockchip/vpu/rk3288_vpu_regs.h | 1 + .../media/rockchip/vpu/rk3399_vpu_hw.c | 71 +- .../rockchip/vpu/rk3399_vpu_hw_jpeg_enc.c | 8 +- .../rockchip/vpu/rk3399_vpu_hw_mpeg2_dec.c | 267 +++++++ .../staging/media/rockchip/vpu/rockchip_vpu.h | 110 ++- .../media/rockchip/vpu/rockchip_vpu_drv.c | 466 ++++++++++-- .../media/rockchip/vpu/rockchip_vpu_enc.c | 571 --------------- .../media/rockchip/vpu/rockchip_vpu_hw.h | 17 + .../media/rockchip/vpu/rockchip_vpu_mpeg2.c | 61 ++ .../media/rockchip/vpu/rockchip_vpu_v4l2.c | 692 ++++++++++++++++++ ...kchip_vpu_common.h => rockchip_vpu_v4l2.h} | 15 +- include/media/v4l2-common.h | 10 +- 18 files changed, 2026 insertions(+), 683 deletions(-) create mode 100644 drivers/staging/media/rockchip/vpu/rk3288_vpu_hw_mpeg2_dec.c create mode 100644 drivers/staging/media/rockchip/vpu/rk3399_vpu_hw_mpeg2_dec.c delete mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_enc.c create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_mpeg2.c create mode 100644 drivers/staging/media/rockchip/vpu/rockchip_vpu_v4l2.c rename drivers/staging/media/rockchip/vpu/{rockchip_vpu_common.h => rockchip_vpu_v4l2.h} (50%)