From patchwork Tue Mar 17 18:06:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dafna Hirschfeld X-Patchwork-Id: 11443705 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 4B1DF92A for ; Tue, 17 Mar 2020 18:07:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 2929B20735 for ; Tue, 17 Mar 2020 18:07:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="OzqISSlB" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2929B20735 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:Cc:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To: References:List-Owner; bh=PI7whRTkEuW02+4/4C3Vg4V92yGg+t7CfUq8G1tEmsY=; b=Ozq ISSlBnX8XIhakCNCa9Zbqbuoe/HYq6tOq9emzOUUI42WdquerOTPLNlAkvTMvOJtyutZ9GmUr3t8q BOipA/6G3fJBKK7DIuCv2EhqHs9/28PzVLClHxqRcE0BDcHV6FPTVJoYdSyZcve6dZ1wlN5E1XZ7Z mElMrY+UYTiHltfmxPjlMY3mBgdYb3nnSmYlhCBiyIA9gLQ440Ba5KmjMkIr9qmS2Io46MbG7lLni HyM5iRdo/JNyQXpU93nm3xisl3zbBwby4F5MukeRAEFF02St/UwyCh7W/1rQVCYGCo11MuYfgF5xT Cpj3QXJskkYSumU5bNc7jo95x8E9GaQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEGcW-00072l-Kv; Tue, 17 Mar 2020 18:07:16 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jEGcT-00071j-Pj for linux-rockchip@lists.infradead.org; Tue, 17 Mar 2020 18:07:15 +0000 Received: from localhost.localdomain (unknown [IPv6:2a02:810a:113f:ad1c:f038:27d4:2beb:6e6b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) (Authenticated sender: dafna) by bhuna.collabora.co.uk (Postfix) with ESMTPSA id 8D5FA294279; Tue, 17 Mar 2020 18:07:09 +0000 (GMT) From: Dafna Hirschfeld To: linux-media@vger.kernel.org Subject: [PATCH v3 0/2] media: staging: rkisp1: fix fwnode API usage and remove v4l2_mbus_config field Date: Tue, 17 Mar 2020 19:06:59 +0100 Message-Id: <20200317180701.6035-1-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200317_110713_967568_B5DEEA53 X-CRM114-Status: GOOD ( 11.22 ) X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mchehab@kernel.org, dafna.hirschfeld@collabora.com, dafna3@gmail.com, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, helen.koike@collabora.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, kernel@collabora.com, ezequiel@collabora.com MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org This patchset fixes usage of the APIs. This fixes the item in the TODO file: * Don't use v4l2_async_notifier_parse_fwnode_endpoints_by_port(). e.g. isp_parse_of_endpoints in drivers/media/platform/omap3isp/isp.c cio2_parse_firmware in drivers/media/pci/intel/ipu3/ipu3-cio2.c. Patches summary: - The first patch removes the field v4l2_mbus_config from 'struct rkisp1_sensor_async'. - The second patch removes the usage of v4l2_async_notifier_parse_fwnode_endpoints_by_port. The code is very similar to the code in the function cio2_parse_firmware but instead of iterating the ports it iterates the id's. The patch also removes the relevant item from the TODO file. changes since v1: - patch 2 - in the function rkisp1_subdev_notifier: 1. move the test 'if (next_id == 0)' outside of the while loop 2. remove the 'end' label. The changes are due to Helen Koike's comments changes since v2: patch 1: rename the field parallel_bus_flags to mbus_flags and set it to vep->bus.mipi_csi2.flags instead of 0 so that the original logic does not change, but only the fields names. patch 2: in the function rkisp1_subdev_notifier: - remove a newline between a call to 'fwnode_graph_get_endpoint_by_id' to the test of its ret value. - define 'next_id' as 'unsigned int' instead of 'int' - rename 'parallel_bus_flags' to 'mbus_flags' and set it to vep.bus.mipi_csi2.flags instead of 0 (this follows previous patch of the series) - when no remote sensor is found, log it with dev_dbg instead of dev_warn Dafna Hirschfeld (2): media: staging: rkisp1: remove mbus field from rkisp1_sensor_async media: staging: rkisp1: replace the call to v4l2_async_notifier_parse_fwnode_endpoints_by_port drivers/staging/media/rkisp1/TODO | 3 - drivers/staging/media/rkisp1/rkisp1-common.h | 3 +- drivers/staging/media/rkisp1/rkisp1-dev.c | 104 ++++++++++--------- drivers/staging/media/rkisp1/rkisp1-isp.c | 52 +++------- 4 files changed, 72 insertions(+), 90 deletions(-)