From patchwork Sat Apr 11 16:05:56 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dafna Hirschfeld X-Patchwork-Id: 11484165 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 83D0592C for ; Sat, 11 Apr 2020 16:06:23 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 504592078E for ; Sat, 11 Apr 2020 16:06:23 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="Tgbcun5+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 504592078E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UcoX2EW/s9uvXFQ8+eteIsws0WF6bcrGSGAszvDUE68=; b=Tgbcun5+jjtRcE LGuEvi4wOm1MXJm+ac+aSPvk4R3GB6LGMB+eFNAcTRmEM71DWpRpvdFjBCpEM4DOWx5zcF2LEMJ+C 7clZEbLM6qqBv9+GwedFnWRQcF2MLv0IxVs/4viCD1P+glezFbpbefE1zBHiR/l1uRv8cAwP9tbUg Cmd8FH0oXyOkfgZCAvB79j1lqyzBupiDjPc522MTly9fHv72PsMtdgyq6cls4CsSJHZLR+wfc0s6n i1PJp2NJcZ1a+Zz/4JUVbU3tPCVMm9bLYjGDGE5nVgXlVT8XSFEcFkKAzkcqaU48a5anEw74hyYiK MUzOFpD7JH23iB7pzzmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNIe8-00079m-Dq; Sat, 11 Apr 2020 16:06:16 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jNIe5-00078F-B5 for linux-rockchip@lists.infradead.org; Sat, 11 Apr 2020 16:06:14 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dafna) with ESMTPSA id 2FD7C2A11D7 From: Dafna Hirschfeld To: linux-media@vger.kernel.org Subject: [PATCH v4 0/6] media: staging: rkisp1: cap: various fixes for capture formats Date: Sat, 11 Apr 2020 18:05:56 +0200 Message-Id: <20200411160602.14637-1-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200411_090613_517671_9FCC4333 X-CRM114-Status: UNSURE ( 9.92 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [46.235.227.227 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mchehab@kernel.org, dafna.hirschfeld@collabora.com, dafna3@gmail.com, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, helen.koike@collabora.com, laurent.pinchart@ideasonboard.com, sakari.ailus@linux.intel.com, kernel@collabora.com, ezequiel@collabora.com Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org This patchset fixes various issues related to the supported formats in the rkisp1 capture. This patchset is rebased on top of v3 of the patchset: "rkisp1: use enum v4l2_pixel_encoding instead of rkisp1_fmt_pix_type" Patches summary: patches 1,2 - fixes a wrong assignments to the register that swaps the 'u', 'v' planes in YUV semiplanar formats. patch 3 - writes to the uv swap with "off" if swapping is not needed. patch 4 - sets the uv swap register only if the format is semiplanar. patch 5 - adds support to planar YUV formats with swapped u,v planes by swapping the addresses of the planes patch 6 - removes some packed YUV formats that are not supported by the driver. changes from v1: - split the first patch from v1 into two separate patches, the first is a cleanup patch the second fixes a bug. changes from v2: - rebasing the patchset on top of v3 of "rkisp1: use enum v4l2_pixel_encoding instead of rkisp1_fmt_pix_type" - patches 1,2: replace "reg = reg | .." with "reg |= .." - adding patch 3 to change the logic of wrrting to uv swap reg - patches 4,5: checking if format is (semi)planar using the info pointer and not using the write_format value - patch 4: using the "swap" define to swap the cb, cr addresses changes from v3: - In patch 5 in the doc and log message: s/plane formats/planar formats/ Dafna Hirschfeld (6): media: staging: rkisp1: cap: cleanup in mainpath config for uv swap format media: staging: rkisp1: cap: fix value written to uv swap register in selfpath media: staging: rkisp1: cap: change the logic for writing to uv swap register media: staging: rkisp1: cap: support uv swap only for semiplanar formats media: staging: rkisp1: cap: support uv swapped planar formats media: staging: rkisp1: cap: remove unsupported formats drivers/staging/media/rkisp1/rkisp1-capture.c | 50 +++++++++---------- 1 file changed, 24 insertions(+), 26 deletions(-)