[v4,0/2] ARM: Add Rockchip rk3288w support

Message

Mylene Josserand June 2, 2020, 8:06 a.m. UTC

Hello everyone,

Context
-------

Here is my V4 of my patches that add the support for the Rockchip
RK3288w which is a revision of the RK3288. It is mostly the same SOC
except for, at least, one clock tree which is different.
This difference is only known by looking at the BSP kernel [1].

Currently, the mainline kernel will not hang on rk3288w but it is
probably by "chance" because we got an issue on a lower kernel version.

According to Rockchip's U-Boot [2], the rk3288w can be detected using
the HDMI revision number (= 0x1A) in this version of the SOC.

Changelog
---------

This V4 is pretty much the same than the V3. Added the dt-bindings
documentation in clock-controller dt-bindings and fixed some typos
according to Heiko's reviews.

Changes since v3:
   - Updated clock-controller's dt-bindings
   - Fixed indentation

Best regards,
Mylène Josserand

[1] https://github.com/rockchip-linux/kernel/blob/develop-4.4/drivers/clk/rockchip/clk-rk3288.c#L960..L964
[2] https://github.com/rockchip-linux/u-boot/blob/next-dev/arch/arm/mach-rockchip/rk3288/rk3288.c#L378..L388

Mylène Josserand (2):
  clk: rockchip: rk3288: Handle clock tree for rk3288w
  dt-bindings: clocks: rk3288: add possible rk3288w

 .../bindings/clock/rockchip,rk3288-cru.txt    |  8 +++++++-
 drivers/clk/rockchip/clk-rk3288.c             | 20 +++++++++++++++++--
 2 files changed, 25 insertions(+), 3 deletions(-)

Comments

Heiko Stübner June 17, 2020, 8:58 a.m. UTC | #1

On Tue, 2 Jun 2020 10:06:42 +0200, Mylène Josserand wrote:
> Context
> -------
> 
> Here is my V4 of my patches that add the support for the Rockchip
> RK3288w which is a revision of the RK3288. It is mostly the same SOC
> except for, at least, one clock tree which is different.
> This difference is only known by looking at the BSP kernel [1].
> 
> [...]

Applied, thanks!

[1/2] clk: rockchip: Handle clock tree for rk3288w variant
      commit: 1627f683636df70fb25358b0a7b39a24e8fce5bf
[2/2] dt-bindings: clocks: add rk3288w variant compatible
      commit: 00bd404144241155653bb0d0c15be51e4e6983aa

Best regards,

Mylene Josserand June 29, 2020, 7:59 a.m. UTC | #2

Hello Heiko,

On 6/17/20 10:58 AM, Heiko Stuebner wrote:
> On Tue, 2 Jun 2020 10:06:42 +0200, Mylène Josserand wrote:
>> Context
>> -------
>>
>> Here is my V4 of my patches that add the support for the Rockchip
>> RK3288w which is a revision of the RK3288. It is mostly the same SOC
>> except for, at least, one clock tree which is different.
>> This difference is only known by looking at the BSP kernel [1].
>>
>> [...]
> 
> Applied, thanks!

Thank you!

Best regards,
Mylène

> 
> [1/2] clk: rockchip: Handle clock tree for rk3288w variant
>        commit: 1627f683636df70fb25358b0a7b39a24e8fce5bf
> [2/2] dt-bindings: clocks: add rk3288w variant compatible
>        commit: 00bd404144241155653bb0d0c15be51e4e6983aa
> 
> Best regards,
>