From patchwork Sat Jul 18 14:59:09 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Dafna Hirschfeld X-Patchwork-Id: 11671969 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 7E02B1510 for ; Sat, 18 Jul 2020 14:59:39 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 5512120656 for ; Sat, 18 Jul 2020 14:59:39 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="SEX1P9+D" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5512120656 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:MIME-Version:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:To:From:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Owner; bh=sgzw5XPUSWYbpCw99mox4a+dm0ifOBK9NyxvKhsSFjM=; b=SEX1P9+DITkqmXWfXQy+cqSRii /9WwjMwkRWTFIOOFwD8LTcPhBJUPhqNp7e9zCbo82+S6m1rAe8FfsmavXK6lHlw2bvDItFrbyGTku SdyqP5L2BEPlHJ6Vob0tD0A9g4kFZBaWE7BPWvC0La8mlR9rjy3nrasHJjTczPrhK6Po7Yis0SXQU lxZvqYsXXDN6NRPbXTqglJ0WsWhgY6KGrBwVVh6VXm7gXEfi8lEAtYpt1aHwfn4xrLl51swr5XWHX DLu4l3beiPqJOxBG2nw3ubYoHc63OT4j0b8Tgj2TkP98ZavWy4LouX2NayZFNr2KHMTUKtN4C/14C nSk9pk0w==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoJJ-0006S5-W4; Sat, 18 Jul 2020 14:59:34 +0000 Received: from bhuna.collabora.co.uk ([2a00:1098:0:82:1000:25:2eeb:e3e3]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jwoJE-0006MT-Fm for linux-rockchip@lists.infradead.org; Sat, 18 Jul 2020 14:59:29 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: dafna) with ESMTPSA id 805CB2A2789 From: Dafna Hirschfeld To: linux-media@vger.kernel.org, laurent.pinchart@ideasonboard.com Subject: [PATCH v2 0/9] media: staging: rkisp1: document rkisp1-common.h Date: Sat, 18 Jul 2020 16:59:09 +0200 Message-Id: <20200718145918.17752-1-dafna.hirschfeld@collabora.com> X-Mailer: git-send-email 2.17.1 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200718_105928_666464_745B0C6E X-CRM114-Status: UNSURE ( 6.56 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.4 on merlin.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mchehab@kernel.org, dafna.hirschfeld@collabora.com, dafna3@gmail.com, tfiga@chromium.org, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, helen.koike@collabora.com, sakari.ailus@linux.intel.com, kernel@collabora.com, ezequiel@collabora.com MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org This patchset extends the documentation of rkisp1-common.h. It adds a line description of every struct and every field, a line description of every lock and short description of the functions, enums and macros. Patches 1-8 are cleanups and minor fixes found during documentation. This patchset solves the TODO item: 'Document rkisp1-common.h' NOTE: This patchset is rebased on top of v2 of the patchset "media: staging: rkisp1: move stats reading to irq handler" https://patchwork.kernel.org/project/linux-media/list/?series=308787 This is because that patchset changes the lock fields in the rkisp1-stats struct. Changes since v2: - 4 added cleanup patches - patches 4-8 - fixes due to comments - added documentation to the debugfs parameters, the functions, the enum and the macros. Dafna Hirschfeld (9): media: staging: rkisp1: remove unused field ctrl_handler from struct rkisp1_device media: staging: rkisp1: remove unused field alloc_ctx from struct rkisp1_device media: staging: rkisp1: set pads array of the resizer to size 2 media: staging: rkisp1: don't define vaddr field in rkisp1_buffer as an array media: staging: rkisp1: add a pointer to rkisp1_device from struct rkisp1_isp media: staging: rkisp1: unify (un)register functions to have the same parameters media: staging: rkisp1: remove declaration of unimplemented function 'rkisp1_params_isr_handler' media: staging: rkisp1: group declaration of similar functions together media: staging: rkisp1: improve documentation of rkisp1-common.h drivers/staging/media/rkisp1/TODO | 1 - drivers/staging/media/rkisp1/rkisp1-common.h | 272 +++++++++++++----- drivers/staging/media/rkisp1/rkisp1-dev.c | 15 +- drivers/staging/media/rkisp1/rkisp1-isp.c | 17 +- drivers/staging/media/rkisp1/rkisp1-params.c | 14 +- drivers/staging/media/rkisp1/rkisp1-resizer.c | 2 +- drivers/staging/media/rkisp1/rkisp1-stats.c | 14 +- 7 files changed, 235 insertions(+), 100 deletions(-)