[v3,0/3] media: rockchip: Introduce driver for Rockchip's camera interface

Message

Maxime Chevallier Sept. 22, 2020, 4:55 p.m. UTC

Hi everyone,

This is the third iteration of the series introducing a driver for the
PX30 camera interface.

This was previously known as the "cif" driver in other iterations, but
was renamed to "vip" following Ezequiel's advices to match the datasheet
name.

This is based on a BSP driver, and I'm not fully familiar with the media
and V4L2 frameworks, so I guess some review is still needed.

This new series adds some stability fixes, and introduces the
double-buffering frame handling, giving better performances.

Thanks to everyone who reviewed the first two iterations,

Maxime

Maxime Chevallier (3):
  media: dt-bindings: media: Document Rockchip VIP bindings
  media: rockchip: Introduce driver for Rockhip's camera interface
  arm64: dts: rockchip: Add the camera interface description of the PX30

 .../bindings/media/rockchip-vip.yaml          |  100 ++
 arch/arm64/boot/dts/rockchip/px30.dtsi        |   12 +
 drivers/media/platform/Kconfig                |   13 +
 drivers/media/platform/Makefile               |    1 +
 drivers/media/platform/rockchip/vip/Makefile  |    3 +
 drivers/media/platform/rockchip/vip/capture.c | 1246 +++++++++++++++++
 drivers/media/platform/rockchip/vip/dev.c     |  408 ++++++
 drivers/media/platform/rockchip/vip/dev.h     |  206 +++
 drivers/media/platform/rockchip/vip/regs.h    |  260 ++++
 9 files changed, 2249 insertions(+)
 create mode 100644 Documentation/devicetree/bindings/media/rockchip-vip.yaml
 create mode 100644 drivers/media/platform/rockchip/vip/Makefile
 create mode 100644 drivers/media/platform/rockchip/vip/capture.c
 create mode 100644 drivers/media/platform/rockchip/vip/dev.c
 create mode 100644 drivers/media/platform/rockchip/vip/dev.h
 create mode 100644 drivers/media/platform/rockchip/vip/regs.h

Comments

Ezequiel Garcia Oct. 2, 2020, 4:31 p.m. UTC | #1

Hi Maxime,

On Tue, 22 Sep 2020 at 13:55, Maxime Chevallier
<[e-mail]> wrote:
>
> Hi everyone,
>
> This is the third iteration of the series introducing a driver for the
> PX30 camera interface.
>
> This was previously known as the "cif" driver in other iterations, but
> was renamed to "vip" following Ezequiel's advices to match the datasheet
> name.
>
> This is based on a BSP driver, and I'm not fully familiar with the media
> and V4L2 frameworks, so I guess some review is still needed.
>
> This new series adds some stability fixes, and introduces the
> double-buffering frame handling, giving better performances.
>
> Thanks to everyone who reviewed the first two iterations,
>
> Maxime
>
> Maxime Chevallier (3):
>   media: dt-bindings: media: Document Rockchip VIP bindings
>   media: rockchip: Introduce driver for Rockhip's camera interface

I can't find this "v3 2/3 media: rockchip: Introduce driver for
Rockhip's camera interface" patch in my mailbox. Perhaps it was too
large and got filtered?
Or maybe it's an issue on my side?

Cheers,
Ezequiel

Dafna Hirschfeld Oct. 2, 2020, 4:42 p.m. UTC | #2

Am 02.10.20 um 18:31 schrieb Ezequiel Garcia:
> Hi Maxime,
> 
> On Tue, 22 Sep 2020 at 13:55, Maxime Chevallier
> <[e-mail]> wrote:
>>
>> Hi everyone,
>>
>> This is the third iteration of the series introducing a driver for the
>> PX30 camera interface.
>>
>> This was previously known as the "cif" driver in other iterations, but
>> was renamed to "vip" following Ezequiel's advices to match the datasheet
>> name.
>>
>> This is based on a BSP driver, and I'm not fully familiar with the media
>> and V4L2 frameworks, so I guess some review is still needed.
>>
>> This new series adds some stability fixes, and introduces the
>> double-buffering frame handling, giving better performances.
>>
>> Thanks to everyone who reviewed the first two iterations,
>>
>> Maxime
>>
>> Maxime Chevallier (3):
>>    media: dt-bindings: media: Document Rockchip VIP bindings
>>    media: rockchip: Introduce driver for Rockhip's camera interface
> 
> I can't find this "v3 2/3 media: rockchip: Introduce driver for
> Rockhip's camera interface" patch in my mailbox. Perhaps it was too
> large and got filtered?
> Or maybe it's an issue on my side?

I do see it on my mailbox, if it helps..

Dafna,

> 
> Cheers,
> Ezequiel
>