mbox series

[RESEND,0/7] gpio-rockchip driver

Message ID 20210324064541.949630-1-jay.xu@rock-chips.com (mailing list archive)
Headers show
Series gpio-rockchip driver | expand

Message

jay.xu@rock-chips.com March 24, 2021, 6:45 a.m. UTC
Separate gpio driver from pinctrl driver, and support v2 controller.

Jianqun Xu (7):
  pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
  pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct
  gpio: separate gpio driver from pinctrl-rockchip driver
  gpio/rockchip: use struct rockchip_gpio_regs for gpio controller
  gpio/rockchip: support next version gpio controller
  gpio/rockchip: always enable clock for gpio controller
  gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type

 drivers/gpio/Kconfig               |   8 +
 drivers/gpio/Makefile              |   1 +
 drivers/gpio/gpio-rockchip.c       | 758 ++++++++++++++++++++++++
 drivers/pinctrl/pinctrl-rockchip.c | 909 +----------------------------
 drivers/pinctrl/pinctrl-rockchip.h | 286 +++++++++
 5 files changed, 1072 insertions(+), 890 deletions(-)
 create mode 100644 drivers/gpio/gpio-rockchip.c
 create mode 100644 drivers/pinctrl/pinctrl-rockchip.h

Comments

jay.xu@rock-chips.com March 24, 2021, 6:50 a.m. UTC | #1
I'm forget to send-to include Bartosz, I'll remember in next version

--------------
jay.xu@rock-chips.com
>Separate gpio driver from pinctrl driver, and support v2 controller.
>
>Jianqun Xu (7):
>  pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
>  pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct
>  gpio: separate gpio driver from pinctrl-rockchip driver
>  gpio/rockchip: use struct rockchip_gpio_regs for gpio controller
>  gpio/rockchip: support next version gpio controller
>  gpio/rockchip: always enable clock for gpio controller
>  gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
>
> drivers/gpio/Kconfig               |   8 +
> drivers/gpio/Makefile              |   1 +
> drivers/gpio/gpio-rockchip.c       | 758 ++++++++++++++++++++++++
> drivers/pinctrl/pinctrl-rockchip.c | 909 +----------------------------
> drivers/pinctrl/pinctrl-rockchip.h | 286 +++++++++
> 5 files changed, 1072 insertions(+), 890 deletions(-)
> create mode 100644 drivers/gpio/gpio-rockchip.c
> create mode 100644 drivers/pinctrl/pinctrl-rockchip.h
>
>--
>2.25.1
>
>
>
Bartosz Golaszewski March 26, 2021, 1:07 p.m. UTC | #2
On Wed, Mar 24, 2021 at 7:50 AM jay.xu@rock-chips.com
<jay.xu@rock-chips.com> wrote:
>
> I'm forget to send-to include Bartosz, I'll remember in next version
>
> --------------
> jay.xu@rock-chips.com
> >Separate gpio driver from pinctrl driver, and support v2 controller.
> >
> >Jianqun Xu (7):
> >  pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
> >  pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct
> >  gpio: separate gpio driver from pinctrl-rockchip driver
> >  gpio/rockchip: use struct rockchip_gpio_regs for gpio controller
> >  gpio/rockchip: support next version gpio controller
> >  gpio/rockchip: always enable clock for gpio controller
> >  gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
> >
> > drivers/gpio/Kconfig               |   8 +
> > drivers/gpio/Makefile              |   1 +
> > drivers/gpio/gpio-rockchip.c       | 758 ++++++++++++++++++++++++
> > drivers/pinctrl/pinctrl-rockchip.c | 909 +----------------------------
> > drivers/pinctrl/pinctrl-rockchip.h | 286 +++++++++
> > 5 files changed, 1072 insertions(+), 890 deletions(-)
> > create mode 100644 drivers/gpio/gpio-rockchip.c
> > create mode 100644 drivers/pinctrl/pinctrl-rockchip.h
> >
> >--
> >2.25.1
> >
> >
> >

I don't even have this in my inbox so I can't review it.

Bartosz
Ezequiel Garcia April 10, 2021, 8:41 p.m. UTC | #3
Hi Jianqun,

I tried applying this on top of "pinctrl: rockchip: add support for rk3568",
but I got some conflicts. If you could add some information about
how patches should be applied to the cover letter, that'd be really helpful :-)

Also, I've noticed several of these GPIOs patches, is this the most up to date?
You can add some information about superseeding patches
in the cover letter as well.

Thanks,
Ezequiel


On Wed, 24 Mar 2021 at 03:46, Jianqun Xu <jay.xu@rock-chips.com> wrote:
>
> Separate gpio driver from pinctrl driver, and support v2 controller.
>
> Jianqun Xu (7):
>   pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
>   pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct
>   gpio: separate gpio driver from pinctrl-rockchip driver
>   gpio/rockchip: use struct rockchip_gpio_regs for gpio controller
>   gpio/rockchip: support next version gpio controller
>   gpio/rockchip: always enable clock for gpio controller
>   gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
>
>  drivers/gpio/Kconfig               |   8 +
>  drivers/gpio/Makefile              |   1 +
>  drivers/gpio/gpio-rockchip.c       | 758 ++++++++++++++++++++++++
>  drivers/pinctrl/pinctrl-rockchip.c | 909 +----------------------------
>  drivers/pinctrl/pinctrl-rockchip.h | 286 +++++++++
>  5 files changed, 1072 insertions(+), 890 deletions(-)
>  create mode 100644 drivers/gpio/gpio-rockchip.c
>  create mode 100644 drivers/pinctrl/pinctrl-rockchip.h
>
> --
> 2.25.1
>
>
>