mbox series

[v4,0/7] gpio-rockchip driver

Message ID 20210510063602.505829-1-jay.xu@rock-chips.com (mailing list archive)
Headers show
Series gpio-rockchip driver | expand

Message

jay.xu@rock-chips.com May 10, 2021, 6:35 a.m. UTC
Separate gpio driver from pinctrl driver, and support v2 controller.

Jianqun Xu (7):
  pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
  pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct
  gpio: separate gpio driver from pinctrl-rockchip driver
  gpio/rockchip: use struct rockchip_gpio_regs for gpio controller
  gpio/rockchip: support next version gpio controller
  gpio/rockchip: always enable clock for gpio controller
  gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type

 drivers/gpio/Kconfig               |   8 +
 drivers/gpio/Makefile              |   1 +
 drivers/gpio/gpio-rockchip.c       | 758 ++++++++++++++++++++++++
 drivers/pinctrl/pinctrl-rockchip.c | 910 +----------------------------
 drivers/pinctrl/pinctrl-rockchip.h | 287 +++++++++
 5 files changed, 1073 insertions(+), 891 deletions(-)
 create mode 100644 drivers/gpio/gpio-rockchip.c
 create mode 100644 drivers/pinctrl/pinctrl-rockchip.h

Comments

Ezequiel Garcia May 10, 2021, 10:16 p.m. UTC | #1
Hi Jianqun,

Thanks a lot for the patch, and for pushing this work forward.

On Mon, 10 May 2021 at 03:36, Jianqun Xu <jay.xu@rock-chips.com> wrote:
>
> Separate gpio driver from pinctrl driver, and support v2 controller.
>

Usually, we expect to see a changelog here, with some information
about the changes from in v2, v3, etc. Also, note that only the cover
letter says "v4", and the individual patches are missing that. You can
use git-format-patch --subject-prefix="PATCH v4", and then all the patches
will get the same prefix.

However, the last patchset I can find in lore.kernel.org (or my
mailbox) is a v2:

https://lore.kernel.org/linux-gpio/20210411133030.1663936-1-pgwipeout@gmail.com/

.. which was sent by Peter Geis (so you should have Cced him).

These are just some friendly tips on the submission process,
for you to keep in mind,  you don't really need to resend the
series or do anything else.

Also, I added Bartosz the GPIO maintainer in Cc.

Thanks!
Ezequiel

> Jianqun Xu (7):
>   pinctrl/rockchip: separate struct rockchip_pin_bank to a head file
>   pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct
>   gpio: separate gpio driver from pinctrl-rockchip driver
>   gpio/rockchip: use struct rockchip_gpio_regs for gpio controller
>   gpio/rockchip: support next version gpio controller
>   gpio/rockchip: always enable clock for gpio controller
>   gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type
>
>  drivers/gpio/Kconfig               |   8 +
>  drivers/gpio/Makefile              |   1 +
>  drivers/gpio/gpio-rockchip.c       | 758 ++++++++++++++++++++++++
>  drivers/pinctrl/pinctrl-rockchip.c | 910 +----------------------------
>  drivers/pinctrl/pinctrl-rockchip.h | 287 +++++++++
>  5 files changed, 1073 insertions(+), 891 deletions(-)
>  create mode 100644 drivers/gpio/gpio-rockchip.c
>  create mode 100644 drivers/pinctrl/pinctrl-rockchip.h
>
> --
> v5:
>  - change to devel branch
>
> 2.25.1
>
>
>
Bartosz Golaszewski May 12, 2021, 1:29 p.m. UTC | #2
On Tue, May 11, 2021 at 12:16 AM Ezequiel Garcia
<ezequiel@vanguardiasur.com.ar> wrote:
>
> Hi Jianqun,
>
> Thanks a lot for the patch, and for pushing this work forward.
>
> On Mon, 10 May 2021 at 03:36, Jianqun Xu <jay.xu@rock-chips.com> wrote:
> >
> > Separate gpio driver from pinctrl driver, and support v2 controller.
> >
>
> Usually, we expect to see a changelog here, with some information
> about the changes from in v2, v3, etc. Also, note that only the cover
> letter says "v4", and the individual patches are missing that. You can
> use git-format-patch --subject-prefix="PATCH v4", and then all the patches
> will get the same prefix.
>
> However, the last patchset I can find in lore.kernel.org (or my
> mailbox) is a v2:
>
> https://lore.kernel.org/linux-gpio/20210411133030.1663936-1-pgwipeout@gmail.com/
>
> .. which was sent by Peter Geis (so you should have Cced him).
>
> These are just some friendly tips on the submission process,
> for you to keep in mind,  you don't really need to resend the
> series or do anything else.
>
> Also, I added Bartosz the GPIO maintainer in Cc.
>

Thanks. Jianqun: please resend the series so that I get it in my inbox.

Bart