[v2,0/7] Enable 10bits bitstream for Hantro/G2 HEVC codec

Message

Benjamin Gaignard July 18, 2022, 8:39 a.m. UTC

Since v1 Jernej patches to support 10 bits decoding have been merged.
This v2 rebase the previously send patches and add Ezequiel reviewed-by
tag.
This series add 10bits support for newer hardware blocks (i.e without
legacy regs) and for HEVC codec.

It based tested on IMX8MQ with HEVC conformance tests.
The results are that all 10bits bitstreams are OK.

The problematic point raise by this series is the question of where 
to put HEVC validation function. Does it have to be only hantro_try_ctrl()
or shall it be done also in .run().
This series doesn't change that behavoir so I will argue in farvor to
merge it and to work on this validation time problem when unstaging 
the driver.
Hans, Ezequiel may that sound acceptable for you ? 

Regards,
Benjamin

Benjamin Gaignard (7):
  media: hantro: Store HEVC bit depth in context
  media: hantro: HEVC: Fix auxilary buffer size calculation
  media: hantro: HEVC: Fix chroma offset computation
  media: hantro: postproc: Configure output regs to support 10bit
  media: Hantro: HEVC: Allows 10-bit bitstream
  media: hantro: imx8m: Enable 10bit decoding
  media: hantro: Allows luma and chroma depth to be different

 .../staging/media/hantro/hantro_g2_hevc_dec.c |  4 +--
 drivers/staging/media/hantro/hantro_hevc.c    | 13 +++++----
 .../staging/media/hantro/hantro_postproc.c    |  7 ++++-
 drivers/staging/media/hantro/imx8m_vpu_hw.c   | 27 +++++++++++++++++++
 4 files changed, 40 insertions(+), 11 deletions(-)

Comments

Hans Verkuil July 18, 2022, 10:12 a.m. UTC | #1

On 7/18/22 10:39, Benjamin Gaignard wrote:
> Since v1 Jernej patches to support 10 bits decoding have been merged.
> This v2 rebase the previously send patches and add Ezequiel reviewed-by
> tag.
> This series add 10bits support for newer hardware blocks (i.e without
> legacy regs) and for HEVC codec.
> 
> It based tested on IMX8MQ with HEVC conformance tests.
> The results are that all 10bits bitstreams are OK.
> 
> The problematic point raise by this series is the question of where 
> to put HEVC validation function. Does it have to be only hantro_try_ctrl()
> or shall it be done also in .run().
> This series doesn't change that behavoir so I will argue in farvor to
> merge it and to work on this validation time problem when unstaging 
> the driver.
> Hans, Ezequiel may that sound acceptable for you ? 

Hmm, the hantro driver will be unstaged either this week or (hopefully)
very early on in the next cycle. So I think you should no longer consider
hantro as a staging driver but as a regular mainline driver.

This series definitely won't make the 5.20 cut, so I think it makes more
sense to get this right before merging it.

Regards,

	Hans

> 
> Regards,
> Benjamin
> 
> Benjamin Gaignard (7):
>   media: hantro: Store HEVC bit depth in context
>   media: hantro: HEVC: Fix auxilary buffer size calculation
>   media: hantro: HEVC: Fix chroma offset computation
>   media: hantro: postproc: Configure output regs to support 10bit
>   media: Hantro: HEVC: Allows 10-bit bitstream
>   media: hantro: imx8m: Enable 10bit decoding
>   media: hantro: Allows luma and chroma depth to be different
> 
>  .../staging/media/hantro/hantro_g2_hevc_dec.c |  4 +--
>  drivers/staging/media/hantro/hantro_hevc.c    | 13 +++++----
>  .../staging/media/hantro/hantro_postproc.c    |  7 ++++-
>  drivers/staging/media/hantro/imx8m_vpu_hw.c   | 27 +++++++++++++++++++
>  4 files changed, 40 insertions(+), 11 deletions(-)
>