mbox series

[v4,0/5] Add more RK3326 gaming handhelds

Message ID 20221117215954.4114202-1-maccraft123mc@gmail.com (mailing list archive)
Headers show
Series Add more RK3326 gaming handhelds | expand

Message

Maya Matuszczyk Nov. 17, 2022, 9:59 p.m. UTC 
This patch series adds Odroid Go Advance, Odroid Go Super(without
display) and Anbernic RG351M.

RG351P uses almost the same motherboard, and I'm not sure how to handle
it. RG351P DTS file would look exactly the same, aside name change.

--

Changes from V3:
- Changed go3's volume buttons to not re-use builtin controller dt node
- Addressed Krzysztof Kozlowski's comments - removed status = "okay"
  where it's not needed, and added a commit message to patch adding dt
  bindings.
- Addressed Chris Morgan's comments - removed battery node from RG351M
- Added a cover letter even harder

Changes from V2:
- Fixed a typo
- Added "v3" tag, sorry!
- Added the cover letter in a way that shouldn't get swallowed by gmail
  this time

Changes from V1:
- Addressed Chris Morgan's comments
- Added RG351M
- Added RG351M and Odroid Go Super

--

Maya Matuszczyk (5):
  arm64: dts: rockchip: Move most of Odroid Go Advance DTS into a DTSI
  dt-bindings: arm: rockchip: Add more RK3326 devices
  arm64: dts: rockchip: Add Odroid Go Advance Black Edition
  arm64: dts: rockchip: Add Odroid Go Super
  arm64: dts: rockchip: Add Anbernic RG351M

 .../devicetree/bindings/arm/rockchip.yaml     |  25 +
 arch/arm64/boot/dts/rockchip/Makefile         |   3 +
 .../dts/rockchip/rk3326-anbernic-rg351m.dts   |  33 +
 .../boot/dts/rockchip/rk3326-odroid-go.dtsi   | 600 +++++++++++++++++
 .../dts/rockchip/rk3326-odroid-go2-v11.dts    | 156 +++++
 .../boot/dts/rockchip/rk3326-odroid-go2.dts   | 620 +-----------------
 .../boot/dts/rockchip/rk3326-odroid-go3.dts   | 185 ++++++
 7 files changed, 1011 insertions(+), 611 deletions(-)
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3326-anbernic-rg351m.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3326-odroid-go.dtsi
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3326-odroid-go2-v11.dts
 create mode 100644 arch/arm64/boot/dts/rockchip/rk3326-odroid-go3.dts

Comments

Heiko Stuebner Nov. 22, 2022, 10:34 p.m. UTC | #1 
On Thu, 17 Nov 2022 22:59:49 +0100, Maya Matuszczyk wrote:
> This patch series adds Odroid Go Advance, Odroid Go Super(without
> display) and Anbernic RG351M.
> 
> RG351P uses almost the same motherboard, and I'm not sure how to handle
> it. RG351P DTS file would look exactly the same, aside name change.
> 
> --
> 
> [...]

Applied, thanks!

[1/5] arm64: dts: rockchip: Move most of Odroid Go Advance DTS into a DTSI
      commit: 04ea3e30386e632c028654409e9a86c4c6b7accb
[2/5] dt-bindings: arm: rockchip: Add more RK3326 devices
      commit: 76eeb9b665d72ee53e5e93f154b23536f9d1c9c0
[3/5] arm64: dts: rockchip: Add Odroid Go Advance Black Edition
      commit: abba44b3e7c3f7530b607e8d2e2db96e6460fc73
[4/5] arm64: dts: rockchip: Add Odroid Go Super
      commit: 2f217d71aa89504abc9ab95286b807efaa03e11a
[5/5] arm64: dts: rockchip: Add Anbernic RG351M
      commit: 4e2347dbd618f88865408709cb7c06ab1f5f3f4a

Best regards,
Chris Morgan Nov. 23, 2022, 2:25 a.m. UTC | #2 
On Tue, Nov 22, 2022 at 11:34:12PM +0100, Heiko Stuebner wrote:
> On Thu, 17 Nov 2022 22:59:49 +0100, Maya Matuszczyk wrote:
> > This patch series adds Odroid Go Advance, Odroid Go Super(without
> > display) and Anbernic RG351M.
> > 
> > RG351P uses almost the same motherboard, and I'm not sure how to handle
> > it. RG351P DTS file would look exactly the same, aside name change.
> > 
> > --
> > 
> > [...]
> 
> Applied, thanks!

Late to the party, sorry about that. For what it's worth I was able to
test this for the Odroid Go Advance at least and everything tested out
okay. I do see a potential sound regression that is unrelated to this
change I will have to chase down though...

Tested-by: Chris Morgan <macromorgan@hotmail.com>

> 
> [1/5] arm64: dts: rockchip: Move most of Odroid Go Advance DTS into a DTSI
>       commit: 04ea3e30386e632c028654409e9a86c4c6b7accb
> [2/5] dt-bindings: arm: rockchip: Add more RK3326 devices
>       commit: 76eeb9b665d72ee53e5e93f154b23536f9d1c9c0
> [3/5] arm64: dts: rockchip: Add Odroid Go Advance Black Edition
>       commit: abba44b3e7c3f7530b607e8d2e2db96e6460fc73
> [4/5] arm64: dts: rockchip: Add Odroid Go Super
>       commit: 2f217d71aa89504abc9ab95286b807efaa03e11a
> [5/5] arm64: dts: rockchip: Add Anbernic RG351M
>       commit: 4e2347dbd618f88865408709cb7c06ab1f5f3f4a
> 
> Best regards,
> -- 
> Heiko Stuebner <heiko@sntech.de>