From patchwork Thu Feb 22 17:39:26 2024 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Pasha Tatashin X-Patchwork-Id: 13567675 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 10C90C5479F for ; Thu, 22 Feb 2024 17:40:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:To :From:Reply-To:Cc:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=cOOXY/2X1fxpiLoe35xFwcMK30kEAxVuLvJ1ilp994c=; b=gjqlBvKMYYukSz GHCgK/qNbuwvpuwDT/FwMZmXxv4wrJZAaCt8g9h/ZODGHkg3a7usgiuOEZTS5MdaZO+PXoPcPqeCI 1NR0lVHBsipQofw6woi92nJb71r2y+a5tgo7ejuMFhJvjxUwry7raWz2EPzaYBBeGdG5n/hF2FPin h4dG5x8WvzHv5f1OvU++CChsutNQc8BcrQZFwkAl1l/b/l8trWbEl2Y5u9RVEr093OEFvtRWI3YV5 BG03PvOUOHL4uHMqj/lfTSSxRJCGY6n5jhm/H28DhUnB32I6MxxQ0Xf9tcnSDQ7/GMbQv+1Y/njHD MbGI7pctgX8uWarCbxjA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdD3A-00000005pL5-0s4m; Thu, 22 Feb 2024 17:40:00 +0000 Received: from mail-qt1-x835.google.com ([2607:f8b0:4864:20::835]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rdD2x-00000005pCJ-3zbY for linux-rockchip@lists.infradead.org; Thu, 22 Feb 2024 17:39:55 +0000 Received: by mail-qt1-x835.google.com with SMTP id d75a77b69052e-42a029c8e62so14481121cf.1 for ; Thu, 22 Feb 2024 09:39:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=soleen-com.20230601.gappssmtp.com; s=20230601; t=1708623586; x=1709228386; darn=lists.infradead.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=SmC4SQg9RJFTyxACzu+4WUHQYE29YjgzDeLpVcyOgV4=; b=bogOwhGho5VUYQf6yNuUPfwPi2KD7wLQJSttqG5auI643ZUm4+x5SWdl8KRIfuyk1J U1JIXTK3sWVu9g/lJD80b3SYrRcv6FoM7BoQaeYNAMYKIabBnZc90/eZ482UmgjaNPf6 S9alXNp9pBYCkGfIGCMx6JtM1DaIEyToj9MH/BZZGpzsfX/IwnaJUe4Eta5SmWbQ+YOD GRFQJl66ivUTjzMLQ94x5JaksAQ8Zaaxb9EClZIL+qNvyuotGXe6E5YlB7czDgaOqZuD zWz07GqmR/afEF65eZsmvSV+5SefLl/kN72Q2T//+6rJC7Kh+yKO29PqGoimbP9TxI/Q asVA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708623586; x=1709228386; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=SmC4SQg9RJFTyxACzu+4WUHQYE29YjgzDeLpVcyOgV4=; b=LnNtA6sGj9nTmrxiwmFq3iohRPO9t8rm11I0wg4HG5qMXQgVqJyyRjsmyVNFEPYGIQ AXocorAj2ijvPCWZjHKMuBY+uNAS/qhTysQ5KEOj+znRKJKc7YLIcRNykp3ynGPFlc5c PRgtvN1mpCIkAJDRlR6bsuKVJUPKtmTUWZ/u9CvtBpvZaVFTIQPZ2KEqmqeH1U9K/q59 oomT2nme+2YcgV8NpIm8J8jgfnHkj4LatEF25hTsYsMgqEgXLN6C0729kbuHP4d1z8eR mriLwngvDrJ8gisSBRjPlrcPjLZHTPlKuQhVgfWQbZ/WUDd/AL0VLVx7fO4lfN6juS7I WiCQ== X-Forwarded-Encrypted: i=1; AJvYcCUHgYpsrw8Nj/RWkkoANov7j7vVnIFasoC79PGu+YbBtak7Hwi7296LJFGAFB0Ue43tyFjhrNRsowGE1NPRrW8OcVgw5G/sM906RL4hkVG8c6H4 X-Gm-Message-State: AOJu0Yy3/pkGpZoKCzTZjUHZgN3Kn+MIRoC2OG+ZA5rj+dKM0O6eLns9 IPEMeT1PBKyngumjnsCtg6hyGVJMNPa2A6kLfxzmHY47xJWudbULukBl8q34gJM= X-Google-Smtp-Source: AGHT+IHQazQ2VKGKYiiCB/F+URR0eEgUMsL+eJQ7E97VwpEkplwTztlYNQqqnsB6QCcvUbBxCire4A== X-Received: by 2002:a05:622a:3d0:b0:42c:71ea:9b28 with SMTP id k16-20020a05622a03d000b0042c71ea9b28mr28604094qtx.32.1708623585634; Thu, 22 Feb 2024 09:39:45 -0800 (PST) Received: from soleen.c.googlers.com.com (249.240.85.34.bc.googleusercontent.com. [34.85.240.249]) by smtp.gmail.com with ESMTPSA id f17-20020ac86ed1000000b0042e5ab6f24fsm259682qtv.7.2024.02.22.09.39.44 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 22 Feb 2024 09:39:45 -0800 (PST) From: Pasha Tatashin To: akpm@linux-foundation.org, alim.akhtar@samsung.com, alyssa@rosenzweig.io, asahi@lists.linux.dev, baolu.lu@linux.intel.com, bhelgaas@google.com, cgroups@vger.kernel.org, corbet@lwn.net, david@redhat.com, dwmw2@infradead.org, hannes@cmpxchg.org, heiko@sntech.de, iommu@lists.linux.dev, jernej.skrabec@gmail.com, jonathanh@nvidia.com, joro@8bytes.org, krzysztof.kozlowski@linaro.org, linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-sunxi@lists.linux.dev, linux-tegra@vger.kernel.org, lizefan.x@bytedance.com, marcan@marcan.st, mhiramat@kernel.org, m.szyprowski@samsung.com, pasha.tatashin@soleen.com, paulmck@kernel.org, rdunlap@infradead.org, robin.murphy@arm.com, samuel@sholland.org, suravee.suthikulpanit@amd.com, sven@svenpeter.dev, thierry.reding@gmail.com, tj@kernel.org, tomas.mudrunka@gmail.com, vdumpa@nvidia.com, wens@csie.org, will@kernel.org, yu-cheng.yu@intel.com, rientjes@google.com, bagasdotme@gmail.com, mkoutny@suse.com Subject: [PATCH v5 00/11] IOMMU memory observability Date: Thu, 22 Feb 2024 17:39:26 +0000 Message-ID: <20240222173942.1481394-1-pasha.tatashin@soleen.com> X-Mailer: git-send-email 2.44.0.rc0.258.g7320e95886-goog MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240222_093950_037900_DADD78DD X-CRM114-Status: GOOD ( 17.10 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org ---------------------------------------------------------------------- Changelog ---------------------------------------------------------------------- v5: - Synced with v6.8-rc5 - Added: Acked-by: Marek Szyprowski - Added: Acked-by: Jernej Skrabec - Addressed review comments from Robin Murphy: Updated the header comment in iommu-pages.h Removed __iommu_alloc_pages_node(), invoke iommu_alloc_pages_node directly. Removed unused: __iommu_alloc_page_node() Removed __iommu_free_page() Renamed: iommu_free_pages_list() -> iommu_put_pages_list() Added missing iommu_put_pages_list() to dma-iommu.c in iommu/dma: use iommu_put_pages_list() to releae freelist v4: - Synced with v6.8-rc3 - Updated commit log for "iommu: account IOMMU allocated memory" as suggested by Michal Koutný - Added more Acked-bys David Rientjes and Thierry Reding - Added Tested-by Bagas Sanjaya. v3: - Sync with v6.7-rc7 - Addressed comments from David Rientjes: s/pages/page/, added unlikely() into the branches, expanded comment for iommu_free_pages_list(). - Added Acked-bys: David Rientjes v2: - Added Reviewed-by Janne Grunau - Sync with 6.7.0-rc3 - Separated form the series patches: vhost-vdpa: account iommu allocations https://lore.kernel.org/all/20231130200447.2319543-1-pasha.tatashin@soleen.com vfio: account iommu allocations https://lore.kernel.org/all/20231130200900.2320829-1-pasha.tatashin@soleen.com as suggested by Jason Gunthorpe - Fixed SPARC build issue detected by kernel test robot - Drop the following patches as they do account iommu page tables: iommu/dma: use page allocation function provided by iommu-pages.h iommu/fsl: use page allocation function provided by iommu-pages.h iommu/iommufd: use page allocation function provided by iommu-pages.h as suggested by Robin Murphy. These patches are not related to IOMMU page tables. We might need to do a separate work to support DMA observability. - Remove support iommu/io-pgtable-arm-v7s as the 2nd level pages are under a page size, thanks Robin Murphy for pointing this out. ---------------------------------------------------------------------- Description ---------------------------------------------------------------------- IOMMU subsystem may contain state that is in gigabytes. Majority of that state is iommu page tables. Yet, there is currently, no way to observe how much memory is actually used by the iommu subsystem. This patch series solves this problem by adding both observability to all pages that are allocated by IOMMU, and also accountability, so admins can limit the amount if via cgroups. The system-wide observability is using /proc/meminfo: SecPageTables: 438176 kB Contains IOMMU and KVM memory. Per-node observability: /sys/devices/system/node/nodeN/meminfo Node N SecPageTables: 422204 kB Contains IOMMU and KVM memory in the given NUMA node. Per-node IOMMU only observability: /sys/devices/system/node/nodeN/vmstat nr_iommu_pages 105555 Contains number of pages IOMMU allocated in the given node. Accountability: using sec_pagetables cgroup-v2 memory.stat entry. With the change, iova_stress[1] stops as limit is reached: $ ./iova_stress iova space: 0T free memory: 497G iova space: 1T free memory: 495G iova space: 2T free memory: 493G iova space: 3T free memory: 491G stops as limit is reached. This series encorporates suggestions that came from the discussion at LPC [2]. ---------------------------------------------------------------------- [1] https://github.com/soleen/iova_stress [2] https://lpc.events/event/17/contributions/1466 ---------------------------------------------------------------------- Previous versions v1: https://lore.kernel.org/all/20231128204938.1453583-1-pasha.tatashin@soleen.com v2: https://lore.kernel.org/linux-mm/20231130201504.2322355-1-pasha.tatashin@soleen.com v3: https://lore.kernel.org/all/20231226200205.562565-1-pasha.tatashin@soleen.com v4: https://lore.kernel.org/all/20240207174102.1486130-1-pasha.tatashin@soleen.com ---------------------------------------------------------------------- Pasha Tatashin (11): iommu/vt-d: add wrapper functions for page allocations iommu/dma: use iommu_put_pages_list() to releae freelist iommu/amd: use page allocation function provided by iommu-pages.h iommu/io-pgtable-arm: use page allocation function provided by iommu-pages.h iommu/io-pgtable-dart: use page allocation function provided by iommu-pages.h iommu/exynos: use page allocation function provided by iommu-pages.h iommu/rockchip: use page allocation function provided by iommu-pages.h iommu/sun50i: use page allocation function provided by iommu-pages.h iommu/tegra-smmu: use page allocation function provided by iommu-pages.h iommu: observability of the IOMMU allocations iommu: account IOMMU allocated memory Documentation/admin-guide/cgroup-v2.rst | 2 +- Documentation/filesystems/proc.rst | 4 +- drivers/iommu/amd/amd_iommu.h | 8 - drivers/iommu/amd/init.c | 91 ++++++------ drivers/iommu/amd/io_pgtable.c | 13 +- drivers/iommu/amd/io_pgtable_v2.c | 20 +-- drivers/iommu/amd/iommu.c | 13 +- drivers/iommu/dma-iommu.c | 7 +- drivers/iommu/exynos-iommu.c | 14 +- drivers/iommu/intel/dmar.c | 16 +- drivers/iommu/intel/iommu.c | 47 ++---- drivers/iommu/intel/iommu.h | 2 - drivers/iommu/intel/irq_remapping.c | 16 +- drivers/iommu/intel/pasid.c | 18 +-- drivers/iommu/intel/svm.c | 11 +- drivers/iommu/io-pgtable-arm.c | 15 +- drivers/iommu/io-pgtable-dart.c | 37 ++--- drivers/iommu/iommu-pages.h | 186 ++++++++++++++++++++++++ drivers/iommu/rockchip-iommu.c | 14 +- drivers/iommu/sun50i-iommu.c | 7 +- drivers/iommu/tegra-smmu.c | 18 ++- include/linux/mmzone.h | 5 +- mm/vmstat.c | 3 + 23 files changed, 361 insertions(+), 206 deletions(-) create mode 100644 drivers/iommu/iommu-pages.h