mbox series

[0/5] VOP Support for rk3576

Message ID 20240827103211.3132728-1-andyshrk@163.com (mailing list archive)
Headers show
Series VOP Support for rk3576 | expand

Message

Andy Yan Aug. 27, 2024, 10:32 a.m. UTC
From: Andy Yan <andy.yan@rock-chips.com>


Thanks for the basic work from Collabora, I can bringup a HDMI
display out on rk3576.

This patch series are still in a very early stage, some architectural
adjustments and more self test are needed,  I plan to add some SOC
specific callbacks in next version.
I'm sending it out at this moment just want to facilitate some people
who are looking forward to doing early try.

The hdmi depends on WIP patch from Cristian[0]

I only test it with a 1080P HDMI output with linux kernel boot logo
and a weston output.

If there are some one want to have a try, I have a tree here[0]
[0]https://lore.kernel.org/lkml/20240819-b4-rk3588-bridge-upstream-v4-0-6417c72a2749@collabora.com/
[1]https://github.com/andyshrk/linux/tree/rk3576-vop2-upstream-v1-0827


Andy Yan (5):
  drm/rockchip: vop2: Add debugfs support
  drm/rockchip: vop2: Support for different layer selet configuration
    between VPs
  drm/rockchip: vop2: Add support for rk3576
  phy: phy-rockchip-samsung-hdptx: Don't request
    RST_PHY/RST_ROPLL/RST_LCPLL
  drm/rockchip: Add basic RK3576 HDMI output support

 .../gpu/drm/rockchip/dw_hdmi_qp-rockchip.c    | 174 ++++-
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.c  | 656 +++++++++++++++++-
 drivers/gpu/drm/rockchip/rockchip_drm_vop2.h  |  99 ++-
 drivers/gpu/drm/rockchip/rockchip_vop2_reg.c  | 496 ++++++++++++-
 .../phy/rockchip/phy-rockchip-samsung-hdptx.c |  17 +-
 5 files changed, 1341 insertions(+), 101 deletions(-)

Comments

Piotr Oniszczuk Aug. 27, 2024, 10:42 a.m. UTC | #1
> Wiadomość napisana przez Andy Yan <andyshrk@163.com> w dniu 27.08.2024, o godz. 12:32:
> 
> From: Andy Yan <andy.yan@rock-chips.com>
> 
> 
> Thanks for the basic work from Collabora, I can bringup a HDMI
> display out on rk3576.
> 
> This patch series are still in a very early stage, some architectural
> adjustments and more self test are needed,  I plan to add some SOC
> specific callbacks in next version.
> I'm sending it out at this moment just want to facilitate some people
> who are looking forward to doing early try.
> 
> The hdmi depends on WIP patch from Cristian[0]
> 

Andy,

Is it make sense to use this series just _as guideline_ to add very basic support for 3528 vop3?

Currently with 3528 i got state where hdmi phy drives correct mode but screen is black (as no vop3 correct support to drive working dw_hdmi)

If you will hint me what needs to be changed in yours 3576 vop2 series to get basic vop3 working - i can play with this on my two 3528 devices….
(we can skip all fancy vop3 features; it will be ehough to see prompt + basic cooperation with 3528 mali gpu)
Andy Yan Aug. 27, 2024, 10:55 a.m. UTC | #2
Hi Piotr,

在 2024-08-27 18:42:49,"Piotr Oniszczuk" <piotr.oniszczuk@gmail.com> 写道:
>
>
>> Wiadomość napisana przez Andy Yan <andyshrk@163.com> w dniu 27.08.2024, o godz. 12:32:
>> 
>> From: Andy Yan <andy.yan@rock-chips.com>
>> 
>> 
>> Thanks for the basic work from Collabora, I can bringup a HDMI
>> display out on rk3576.
>> 
>> This patch series are still in a very early stage, some architectural
>> adjustments and more self test are needed,  I plan to add some SOC
>> specific callbacks in next version.
>> I'm sending it out at this moment just want to facilitate some people
>> who are looking forward to doing early try.
>> 
>> The hdmi depends on WIP patch from Cristian[0]
>> 
>
>Andy,
>
>Is it make sense to use this series just _as guideline_ to add very basic support for 3528 vop3?
>
>Currently with 3528 i got state where hdmi phy drives correct mode but screen is black (as no vop3 correct support to drive working dw_hdmi)
>
>If you will hint me what needs to be changed in yours 3576 vop2 series to get basic vop3 working - i can play with this on my two 3528 devices….
>(we can skip all fancy vop3 features; it will be ehough to see prompt + basic cooperation with 3528 mali gpu)

The VOP of rk3528 is a bit like a hybrid of rk3588 and rk3576. 
The interface mux  and irq are like rk3568/88
The overlay are similar with rk3576.
I think you can use this series as a reference to add baseic support for rk3528.

>
>
>
>_______________________________________________
>Linux-rockchip mailing list
>Linux-rockchip@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/linux-rockchip