| Message ID | 20250307120004.959980-1-amadeus@jmu.edu.cn (mailing list archive) |
|---|---|
| Headers | show |
| Series | arm64: dts: rockchip: Add pwm nodes for RK3528 | expand |
On Fri, 07 Mar 2025 20:00:02 +0800, Chukun Pan wrote: > Add pwm nodes for RK3528. Most rk3528 boards use pwm-regulator to > supply to CPU, add node to enable them. The PWM core on RK3528 is > the same as RK3328, but the driver doesn't support interrupts yet. > > Unlike other SoCs, pinctrl-names need to be in "active" state, > I'm not sure about this, but otherwise the pwm-regulator will > not work properly. > > [...] Applied, thanks! [2/2] arm64: dts: rockchip: Add pwm nodes for RK3528 commit: 2973d077aedfc114affab96c3b2c7286163cc8c9 Best regards,
Hi Heiko, On 2025-03-12 08:45, Heiko Stuebner wrote: > > On Fri, 07 Mar 2025 20:00:02 +0800, Chukun Pan wrote: >> Add pwm nodes for RK3528. Most rk3528 boards use pwm-regulator to >> supply to CPU, add node to enable them. The PWM core on RK3528 is >> the same as RK3328, but the driver doesn't support interrupts yet. >> >> Unlike other SoCs, pinctrl-names need to be in "active" state, >> I'm not sure about this, but otherwise the pwm-regulator will >> not work properly. >> >> [...] > > Applied, thanks! The pinctrl-names should be changed to "default" and not "active", something you can fixup or do you want a patch? In commit 96d8d3253246 ("arm64: dts: rockchip: Fix PWM pinctrl names") similar issue was corrected for current rockchip boards. Regards, Jonas > > [2/2] arm64: dts: rockchip: Add pwm nodes for RK3528 > commit: 2973d077aedfc114affab96c3b2c7286163cc8c9 > > Best regards,
Add pwm nodes for RK3528. Most rk3528 boards use pwm-regulator to supply to CPU, add node to enable them. The PWM core on RK3528 is the same as RK3328, but the driver doesn't support interrupts yet. Unlike other SoCs, pinctrl-names need to be in "active" state, I'm not sure about this, but otherwise the pwm-regulator will not work properly. --- vdd_arm: regulator-vdd-arm { compatible = "pwm-regulator"; pwms = <&pwm1 0 5000 1>; pwm-supply = <&vcc5v0_sys>; regulator-name = "vdd_arm"; regulator-min-microvolt = <746000>; regulator-max-microvolt = <1201000>; regulator-always-on; regulator-boot-on; regulator-settling-time-up-us = <250>; }; &cpu0 { cpu-supply = <&vdd_arm>; }; &pwm1 { status = "okay"; }; --- Chukun Pan (2): dt-bindings: pwm: rockchip: Add rockchip,rk3528-pwm arm64: dts: rockchip: Add pwm nodes for RK3528 .../devicetree/bindings/pwm/pwm-rockchip.yaml | 1 + arch/arm64/boot/dts/rockchip/rk3528.dtsi | 88 +++++++++++++++++++ 2 files changed, 89 insertions(+)