| Message ID | 1411900693-30484-4-git-send-email-caesar.wang@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Caesar, On Sun, Sep 28, 2014 at 3:38 AM, Caesar Wang <caesar.wang@rock-chips.com> wrote: > This patch changes a dtsi file to contain the thermal data > on RK3288 and later SoCs. This data will > enable a thermal shutdown over 125C. > > Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com> > --- > arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi | 32 +++++++++++++++++++++++++++++++ > 1 file changed, 32 insertions(+) > create mode 100644 arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi I haven't done lots of review of this series, but I did notice that this file has bad spacing. It's fairly obvious in your gerrit patch <https://chromium-review.googlesource.com/#/c/220270/1/arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi> because gerrit (by default) shows you "tab" characters... In general you should use tab for indentation, not spaces. You seem to use a mix of the two. -Doug
Hi, On Tue, Sep 30, 2014 at 11:24 AM, Doug Anderson <dianders@chromium.org> wrote: > Caesar, > > On Sun, Sep 28, 2014 at 3:38 AM, Caesar Wang <caesar.wang@rock-chips.com> wrote: >> This patch changes a dtsi file to contain the thermal data >> on RK3288 and later SoCs. This data will >> enable a thermal shutdown over 125C. >> >> Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com> >> --- >> arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi | 32 +++++++++++++++++++++++++++++++ >> 1 file changed, 32 insertions(+) >> create mode 100644 arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi > > I haven't done lots of review of this series, but I did notice that > this file has bad spacing. It's fairly obvious in your gerrit patch > <https://chromium-review.googlesource.com/#/c/220270/1/arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi> > because gerrit (by default) shows you "tab" characters... > > In general you should use tab for indentation, not spaces. You seem > to use a mix of the two. I suppose I should also point out that it's generally not great to name things "rk3xxx" since it makes too many predictions about how future products will behave. It's better to name things after the first relevant product. I'd just name this "rk3288-cpu-thermal.dtsi". -Doug
diff --git a/arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi b/arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi new file mode 100644 index 0000000..8888f7e --- /dev/null +++ b/arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi @@ -0,0 +1,32 @@ +/* + * Device Tree Source for RK3XXX SoC CPU thermal + * + * Copyright (c) 2014, Fuzhou Rockchip Electronics Co., Ltd + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +#include <dt-bindings/thermal/thermal.h> + +cpu_thermal: cpu_thermal { + polling-delay-passive = <500>; /* milliseconds */ + polling-delay = <1000>; /* milliseconds */ + + /* sensor ID */ + thermal-sensors = <&tsadc 0>; + + trips { + cpu_alert0: cpu_alert { + temperature = <800000>; /* millicelsius */ + hysteresis = <2000>; /* millicelsius */ + type = "passive"; + }; + cpu_crit: cpu_crit { + temperature = <125000>; /* millicelsius */ + hysteresis = <2000>; /* millicelsius */ + type = "critical"; + }; + }; +};
This patch changes a dtsi file to contain the thermal data on RK3288 and later SoCs. This data will enable a thermal shutdown over 125C. Signed-off-by: Caesar Wang <caesar.wang@rock-chips.com> --- arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi | 32 +++++++++++++++++++++++++++++++ 1 file changed, 32 insertions(+) create mode 100644 arch/arm/boot/dts/rk3xxx-cpu-thermal.dtsi