From patchwork Fri Feb 20 00:44:35 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Heiko Stuebner X-Patchwork-Id: 5854261 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0A0579F269 for ; Fri, 20 Feb 2015 00:39:54 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2EADC20353 for ; Fri, 20 Feb 2015 00:39:53 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 29AA12034E for ; Fri, 20 Feb 2015 00:39:51 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1YObdG-00052D-R1; Fri, 20 Feb 2015 00:39:50 +0000 Received: from gloria.sntech.de ([95.129.55.99]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1YObd1-0004t5-KM; Fri, 20 Feb 2015 00:39:36 +0000 Received: from ip923444a8.dynamic.kabel-deutschland.de ([146.52.68.168] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:256) (Exim 4.80) (envelope-from ) id 1YObcU-0007Xu-I2; Fri, 20 Feb 2015 01:39:02 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: FUKAUMI Naoki Subject: Re: [PATCH v4 0/3] add support for Firefly-RK3288 and Rayeager PX2 boards Date: Fri, 20 Feb 2015 01:44:35 +0100 Message-ID: <142441781.gJtRx3FmLT@diego> User-Agent: KMail/4.14.1 (Linux/3.16.0-4-amd64; KDE/4.14.2; x86_64; ; ) In-Reply-To: <2137926.nqOiED5bzz@diego> References: <1422189576-19478-1-git-send-email-naobsd@gmail.com> <2137926.nqOiED5bzz@diego> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150219_163935_834977_3C946B44 X-CRM114-Status: GOOD ( 10.84 ) X-Spam-Score: -0.0 (/) Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Am Montag, 26. Januar 2015, 02:22:55 schrieb Heiko Stübner: > Am Sonntag, 25. Januar 2015, 21:39:33 schrieb FUKAUMI Naoki: > > This series adds support for following Rockchip SoC based boards. > > > > - Firefly, Firefly-RK3288 (both beta and mass production version) > > - ChipSPARK, Rayeager PX2 > > I've applied this series with Andy's Tested-by for the Rayeager board and my > Tested-by for the Firefly. > > One caveat, I had to remove the gmac node from the firefly dtsi, as the > whole gmac series goes through the network tree, so the dtb won't compile > either in my tree or arm-soc due to the missing core node. > > I'll try to see if I can get the separate gmac node in when everything is > combined in 3.20-rc1. I've added the missing gmac config now to my dts-branch for 3.21 (or whatever it might get called), with the following patch: ----------- 8< ------------ From: Heiko Stuebner Date: Fri, 20 Feb 2015 01:31:57 +0100 Subject: [PATCH] ARM: dts: rockchip: enable gmac on rk3288-firefly This was left out of the original firefly board definition due to the ethernet support going completely through the network tree, making the underlying nodes unavailable. Now that everything is present enable the gmac on the firefly. Signed-off-by: Heiko Stuebner --- arch/arm/boot/dts/rk3288-firefly.dtsi | 16 ++++++++++++++++ 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi b/arch/arm/boot/dts/rk3288-firefly.dtsi index b9dda41..b54dd78 100644 --- a/arch/arm/boot/dts/rk3288-firefly.dtsi +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi @@ -179,6 +179,22 @@ status = "okay"; }; +&gmac { + assigned-clocks = <&cru SCLK_MAC>; + assigned-clock-parents = <&ext_gmac>; + clock_in_out = "input"; + pinctrl-names = "default"; + pinctrl-0 = <&rgmii_pins>, <&phy_rst>, <&phy_pmeb>, <&phy_int>; + phy-supply = <&vcc_lan>; + phy-mode = "rgmii"; + snps,reset-active-low; + snps,reset-delays-us = <0 10000 1000000>; + snps,reset-gpio = <&gpio4 8 GPIO_ACTIVE_LOW>; + tx_delay = <0x30>; + rx_delay = <0x10>; + status = "ok"; +}; + &hdmi { ddc-i2c-bus = <&i2c5>; status = "okay";