| Message ID | 1435687438.27701.12.camel@ceres (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jul 1, 2015 at 2:03 AM, Alexey Klimov <klimov.linux@gmail.com> wrote: > Memory for this struct is allocated by spi_alloc_master() using > kzalloc() so it doesn't need to be set to 0 one more time. > > Signed-off-by: Alexey Klimov <klimov.linux@gmail.com> Yup, I just noticed this too when reviewing the mediatek SPI driver. For both patches: Reviewed-by: Daniel Kurtz <djkurtz@chromium.org> > --- > drivers/spi/spi-s3c24xx.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c > index f747ca2..f36bc32 100644 > --- a/drivers/spi/spi-s3c24xx.c > +++ b/drivers/spi/spi-s3c24xx.c > @@ -501,7 +501,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) > } > > hw = spi_master_get_devdata(master); > - memset(hw, 0, sizeof(struct s3c24xx_spi)); > > hw->master = master; > hw->pdata = pdata = dev_get_platdata(&pdev->dev); > -- > 1.9.1 > > > > > _______________________________________________ > Linux-rockchip mailing list > Linux-rockchip@lists.infradead.org > http://lists.infradead.org/mailman/listinfo/linux-rockchip
diff --git a/drivers/spi/spi-s3c24xx.c b/drivers/spi/spi-s3c24xx.c index f747ca2..f36bc32 100644 --- a/drivers/spi/spi-s3c24xx.c +++ b/drivers/spi/spi-s3c24xx.c @@ -501,7 +501,6 @@ static int s3c24xx_spi_probe(struct platform_device *pdev) } hw = spi_master_get_devdata(master); - memset(hw, 0, sizeof(struct s3c24xx_spi)); hw->master = master; hw->pdata = pdata = dev_get_platdata(&pdev->dev);
Memory for this struct is allocated by spi_alloc_master() using kzalloc() so it doesn't need to be set to 0 one more time. Signed-off-by: Alexey Klimov <klimov.linux@gmail.com> --- drivers/spi/spi-s3c24xx.c | 1 - 1 file changed, 1 deletion(-)