From patchwork Wed Sep 2 21:54:22 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 7113521 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8A158BEEC1 for ; Wed, 2 Sep 2015 21:55:15 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id A915420636 for ; Wed, 2 Sep 2015 21:55:14 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D376620632 for ; Wed, 2 Sep 2015 21:55:13 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXFzs-0003AC-AO; Wed, 02 Sep 2015 21:55:12 +0000 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXFzq-0001zm-E0 for linux-rockchip@lists.infradead.org; Wed, 02 Sep 2015 21:55:10 +0000 Received: by pacwi10 with SMTP id wi10so23809274pac.3 for ; Wed, 02 Sep 2015 14:54:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=xL8jkHMzwsTCrqkrrpX5bby67P4Tucq5CcL7rj1dC0A=; b=i9l8O5V/B8XoxSHWxScVTBE9mRRb5Zy1VX3ciJpseEZdt3fEF7fNiqOEV66aPyABEO QO8A/h6ZDCUblNydEqrhUkKvL5QsXSnjH1nTsZZuZeNhFGkXdxDkTqm/z/kB44+uKmQR HeRBQ8mh5J+uWLLyq88ekqc+Nh+fzw7EoG0+w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=xL8jkHMzwsTCrqkrrpX5bby67P4Tucq5CcL7rj1dC0A=; b=iBikZw2Fpz4REoeNo6H5JHjYKk/b6qVGXONSgZf1oLrgH8r1OAgxMzeBjMzVNz3tJN vkYVL9Qi9sTRUc1CvLssrs6sLUYcvp4BYVUjUmwP3cXWx2Ni41LIhaOAGczjDaY8iI3F ELCtI/TNskH0evg9JCeTvfR4nqybRmcnqXckcy9C/zAD0fcnHAPJD1NHSTOGvOrzv278 PQjuoq5dAomtMj9te1y2j1i8hG3AHBDfPfFEzx5gRnkN+T09ZCT2iy5D3pJbG92SzfIx wdMzyJIdLKwuF+3m7bqbZ/VuE7MF+NbodHEGkMyzCIqY75rlL3lcKGDeiv4vwvCUHoen u3Ow== X-Gm-Message-State: ALoCoQlNxoLVyJJd7B1d4cAC0qwf9ORtKjIydSfEtGlta83IMRkrdT6ZksK0s6cXzNhAAjFpkszB X-Received: by 10.68.136.138 with SMTP id qa10mr15788070pbb.8.1441230889289; Wed, 02 Sep 2015 14:54:49 -0700 (PDT) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id c4sm22795755pdl.16.2015.09.02.14.54.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Sep 2015 14:54:48 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner Subject: [PATCH] ARM: dts: Add the hdmi-ddc pinctrl settings for rk3288 Date: Wed, 2 Sep 2015 14:54:22 -0700 Message-Id: <1441230862-17376-1-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.5.0.457.gab17608 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150902_145510_507279_61FE0D95 X-CRM114-Status: GOOD ( 12.65 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, linux@arm.linux.org.uk, amstan@chromium.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, briannorris@chromium.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, robh+dt@kernel.org, ykk@rock-chips.com, galak@codeaurora.org, linux-arm-kernel@lists.infradead.org, mark.yao@rock-chips.com MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The pins for i2c5 can either be configured as "I2C5" which means that they're controlled by the normal RK3288 I2C controller or as "EDP / HDMI I2C". It's unclear why EDP is referenced here since apparently setting the mux to this position enables I2C communication using the dw_hdmi block with a patch like . There appear to be some reasons why using the builtin I2C controller in dw_hdmi is better than using the normal RK3288 I2C controller, so boards based on rk3288 might eventually want to use this pinmux if it's known to work. Once driver support in dw_hdmi lands, boards would use this by selecting this pinctrl for the HDMI block and then _not_ specifying a ddc-i2c-bus and _not_ setting the status to "okay" for i2c5 (which uses the same pins). Signed-off-by: Douglas Anderson --- arch/arm/boot/dts/rk3288.dtsi | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 906e938..055b488 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -923,6 +923,13 @@ #interrupt-cells = <2>; }; + hdmi { + hdmi_ddc: hdmi-ddc { + rockchip,pins = <7 19 RK_FUNC_2 &pcfg_pull_none>, + <7 20 RK_FUNC_2 &pcfg_pull_none>; + }; + }; + pcfg_pull_up: pcfg-pull-up { bias-pull-up; };