From patchwork Wed Sep 2 22:20:06 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexandru M Stan X-Patchwork-Id: 7113581 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 06A1A9F1D5 for ; Wed, 2 Sep 2015 22:20:39 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 25EAB2066C for ; Wed, 2 Sep 2015 22:20:38 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0F07D20664 for ; Wed, 2 Sep 2015 22:20:37 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXGOR-0005Vi-FH; Wed, 02 Sep 2015 22:20:35 +0000 Received: from mail-pa0-x234.google.com ([2607:f8b0:400e:c03::234]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1ZXGOP-0005TY-Ss for linux-rockchip@lists.infradead.org; Wed, 02 Sep 2015 22:20:34 +0000 Received: by padhy1 with SMTP id hy1so24517026pad.1 for ; Wed, 02 Sep 2015 15:20:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=bzDUkq6giHY+quiL+rWLGsTpa6eaKkCUX4lpVi84Rp4=; b=XDyXdBitIJ7qlWRJLxpGhCred98sFBgqRIcOsedENjC35K3GqVyqNKiKHXKly1u2q0 YP44hMBTmXhdYW5KRgIEVtumOIK8y4zzRDeagSZZp3kdptCVwxMXleGSIL0hRO8k0Lgq +IiIa1a/s2bT4EGVx+ic0KXA3bOEWGBw/ayGI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=bzDUkq6giHY+quiL+rWLGsTpa6eaKkCUX4lpVi84Rp4=; b=g1Er1HAuA+g2LqOnRwlo+HKW4+PLMes71fncAdAd4UBccPPb4x3qUnm7YdS8vhrXWG Q9xQ2Fd+jxLIqnYbF4DHDXGxpkTx3nH/qBp7/GIYCJ9fHovsz43CZuMKkPJDemqIqNKb c2nYUw8ulq4WNXm7iYRLThsA4aoWSKc6N+wAgziOChZ3IyYBwjcR1RS+UqWU8FTGvfUF gN+fgeqFeRMSv14SVrptvjpW8Wk5Oo6MzZ48WiOflh6Xfkhy3uCJg3pBjdjf3cmQystK DkMIQk3F5GoP3AUK06Cf745JGrQLFZgfAEUtE9vOmF7OZRtwCqOC6uXD1HI9GK4f9y5c UknA== X-Gm-Message-State: ALoCoQlLPBHKsxeFk4X/v51ukFprBitKZdTkAJt9pwtEWXMFIVuWYEQFFBAB8Aip5I6uwQbhSLux X-Received: by 10.68.167.227 with SMTP id zr3mr60564287pbb.61.1441232412471; Wed, 02 Sep 2015 15:20:12 -0700 (PDT) Received: from amstan.mtv.corp.google.com ([100.96.109.27]) by smtp.gmail.com with ESMTPSA id lg7sm15593711pbc.1.2015.09.02.15.20.11 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 02 Sep 2015 15:20:11 -0700 (PDT) From: Alexandru M Stan To: Heiko Stuebner Subject: [PATCH] ARM: dts: rk3288: pull up cts lines Date: Wed, 2 Sep 2015 15:20:06 -0700 Message-Id: <1441232406-32628-1-git-send-email-amstan@chromium.org> X-Mailer: git-send-email 2.5.0.457.gab17608 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20150902_152033_964357_81220DD0 X-CRM114-Status: GOOD ( 10.40 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, Alexandru M Stan , Jeffy Chen , Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Neil Hendin , linux-arm-kernel@lists.infradead.org, Caesar Wang MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The flow control lines from a user accessible UART are optional, the user might not have anything connected to those pins. In order to prevent random interrupts happening and noise affecting that pin it should be pulled up. Note that the default state for those pins on the rk3288 is pulled up, so this patch merely restores them. Suggested-by: Neil Hendin Signed-off-by: Alexandru M Stan --- arch/arm/boot/dts/rk3288.dtsi | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/arm/boot/dts/rk3288.dtsi b/arch/arm/boot/dts/rk3288.dtsi index 906e938..a059367 100644 --- a/arch/arm/boot/dts/rk3288.dtsi +++ b/arch/arm/boot/dts/rk3288.dtsi @@ -1211,11 +1211,11 @@ }; uart0_cts: uart0-cts { - rockchip,pins = <4 18 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <4 18 RK_FUNC_1 &pcfg_pull_up>; }; uart0_rts: uart0-rts { - rockchip,pins = <4 19 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <4 19 RK_FUNC_1 &pcfg_pull_up>; }; }; @@ -1226,11 +1226,11 @@ }; uart1_cts: uart1-cts { - rockchip,pins = <5 10 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <5 10 RK_FUNC_1 &pcfg_pull_up>; }; uart1_rts: uart1-rts { - rockchip,pins = <5 11 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <5 11 RK_FUNC_1 &pcfg_pull_up>; }; }; @@ -1249,11 +1249,11 @@ }; uart3_cts: uart3-cts { - rockchip,pins = <7 9 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <7 9 RK_FUNC_1 &pcfg_pull_up>; }; uart3_rts: uart3-rts { - rockchip,pins = <7 10 RK_FUNC_1 &pcfg_pull_none>; + rockchip,pins = <7 10 RK_FUNC_1 &pcfg_pull_up>; }; }; @@ -1264,11 +1264,11 @@ }; uart4_cts: uart4-cts { - rockchip,pins = <5 14 3 &pcfg_pull_none>; + rockchip,pins = <5 14 3 &pcfg_pull_up>; }; uart4_rts: uart4-rts { - rockchip,pins = <5 15 3 &pcfg_pull_none>; + rockchip,pins = <5 15 3 &pcfg_pull_up>; }; };