| Message ID | 1441961729-10594-1-git-send-email-shawn.lin@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Shawn, On Fri, 2015-09-11 at 04:55PM +0800, Shawn Lin wrote: > This patch adds phys and phy-names for sdhci-of-arasan as optional > properties, and details the example as well. > > Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> > --- > > Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > index da541c3..0264d5f 100644 > --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt > @@ -1,11 +1,12 @@ > Device Tree Bindings for the Arasan SDHCI Controller > > - The bindings follow the mmc[1], clock[2] and interrupt[3] bindings. Only > - deviations are documented here. > + The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings. > + Only deviations are documented here. > > [1] Documentation/devicetree/bindings/mmc/mmc.txt > [2] Documentation/devicetree/bindings/clock/clock-bindings.txt > [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt > + [4] Documentation/devicetree/bindings/phy/phy-bindings.txt > > Required Properties: > - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or > @@ -16,6 +17,9 @@ Required Properties: > - interrupts: Interrupt specifier > - interrupt-parent: Phandle for the interrupt controller that services > interrupts for this device. > +Optional Properties: > + - phys: From PHY bindings: Phandle for the Generic PHY for arasan. > + - phy-names: MUST be "phy_arasan". This might be a dumb question, but, is the external phy actually optional? Or is it mandatory for certain implementations of the IP. In the latter case, it should probably be a mandatory property depending on the compatible string matching an implementation that requires an external phy (accordingly, the implementation might have to treat it that way too). Sören
? 2015/9/14 10:47, Sören Brinkmann ??: > Hi Shawn, > > On Fri, 2015-09-11 at 04:55PM +0800, Shawn Lin wrote: >> This patch adds phys and phy-names for sdhci-of-arasan as optional >> properties, and details the example as well. >> >> Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> >> --- >> >> Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 ++++++++-- >> 1 file changed, 8 insertions(+), 2 deletions(-) >> >> diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> index da541c3..0264d5f 100644 >> --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt >> @@ -1,11 +1,12 @@ >> Device Tree Bindings for the Arasan SDHCI Controller >> >> - The bindings follow the mmc[1], clock[2] and interrupt[3] bindings. Only >> - deviations are documented here. >> + The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings. >> + Only deviations are documented here. >> >> [1] Documentation/devicetree/bindings/mmc/mmc.txt >> [2] Documentation/devicetree/bindings/clock/clock-bindings.txt >> [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt >> + [4] Documentation/devicetree/bindings/phy/phy-bindings.txt >> >> Required Properties: >> - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or >> @@ -16,6 +17,9 @@ Required Properties: >> - interrupts: Interrupt specifier >> - interrupt-parent: Phandle for the interrupt controller that services >> interrupts for this device. >> +Optional Properties: >> + - phys: From PHY bindings: Phandle for the Generic PHY for arasan. >> + - phy-names: MUST be "phy_arasan". > > This might be a dumb question, but, is the external phy actually > optional? Or is it mandatory for certain implementations of the IP. > In the latter case, it should probably be a mandatory property depending > on the compatible string matching an implementation that requires an > external phy (accordingly, the implementation might have to treat it From my soc team's reponse, there is no way to bypass controller to IO if no phy supported. So it should be the latter case you mentioned for arasan.sdhci-5.1. Thanks for point out it, really helpful. I will fix it in v2. > that way too). > > Sören > > >
diff --git a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt index da541c3..0264d5f 100644 --- a/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt +++ b/Documentation/devicetree/bindings/mmc/arasan,sdhci.txt @@ -1,11 +1,12 @@ Device Tree Bindings for the Arasan SDHCI Controller - The bindings follow the mmc[1], clock[2] and interrupt[3] bindings. Only - deviations are documented here. + The bindings follow the mmc[1], clock[2], interrupt[3] and phy[4] bindings. + Only deviations are documented here. [1] Documentation/devicetree/bindings/mmc/mmc.txt [2] Documentation/devicetree/bindings/clock/clock-bindings.txt [3] Documentation/devicetree/bindings/interrupt-controller/interrupts.txt + [4] Documentation/devicetree/bindings/phy/phy-bindings.txt Required Properties: - compatible: Compatibility string. Must be 'arasan,sdhci-8.9a' or @@ -16,6 +17,9 @@ Required Properties: - interrupts: Interrupt specifier - interrupt-parent: Phandle for the interrupt controller that services interrupts for this device. +Optional Properties: + - phys: From PHY bindings: Phandle for the Generic PHY for arasan. + - phy-names: MUST be "phy_arasan". Example: sdhci@e0100000 { @@ -25,4 +29,6 @@ Example: clocks = <&clkc 21>, <&clkc 32>; interrupt-parent = <&gic>; interrupts = <0 24 4>; + phys = <&emmc_phy>; + phy-names = "phy_arasan"; } ;
This patch adds phys and phy-names for sdhci-of-arasan as optional properties, and details the example as well. Signed-off-by: Shawn Lin <shawn.lin@rock-chips.com> --- Documentation/devicetree/bindings/mmc/arasan,sdhci.txt | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-)