From patchwork Mon Nov 30 02:28:05 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 7720601 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 85EDEBEEE1 for ; Mon, 30 Nov 2015 02:31:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id C81302058E for ; Mon, 30 Nov 2015 02:31:24 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0E1720573 for ; Mon, 30 Nov 2015 02:31:23 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a3EFO-0004jI-NP; Mon, 30 Nov 2015 02:31:22 +0000 Received: from mail-pa0-f66.google.com ([209.85.220.66]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a3ED3-0001H6-LF; Mon, 30 Nov 2015 02:29:04 +0000 Received: by padhk6 with SMTP id hk6so23284148pad.2; Sun, 29 Nov 2015 18:28:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pSox7+1O/DPE/bZD3RzLL+60qVj5+KT7eCw812sT+1U=; b=R3Hk3bOk9fvwn9QN4L5By1h7B7OYiFGkGtsexgMPQ4e4DLbBOIsa16pMAi+kgLdz6S bBVRX/7LUAi7dnEH6vtqRkUSMiwnz7RcW/jsPYyzsaxEkmRyjVZ75Oea1TcNHfbeJbga 3RUcF8Z4O20ZCw+DnLEKOVXVKG+EgVUQvh98zBDykTi+QAqR9tv2rdZdS5uiDO+1VHCs s0pkybcySAbL0fC5mIxxUG7PexcGBowel8gZG54fo8vyYC5lJMabPXrBi9LsWvLcZJoN EpDatIJbCZlF4F09KHheYrnatqkLXsBtIy8PDXCxu+6N9Qr4uzD5WR4LcEmdk8jppiPh 9YTw== X-Received: by 10.98.14.75 with SMTP id w72mr68012026pfi.166.1448850516452; Sun, 29 Nov 2015 18:28:36 -0800 (PST) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id 25sm10790104pfp.62.2015.11.29.18.28.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 29 Nov 2015 18:28:35 -0800 (PST) From: Caesar Wang To: Eduardo Valentin Subject: [PATCH v2 2/5] thermal: rockchip: fix a impossible condition caused by the warning Date: Mon, 30 Nov 2015 10:28:05 +0800 Message-Id: <1448850488-16325-3-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1448850488-16325-1-git-send-email-wxt@rock-chips.com> References: <1448850488-16325-1-git-send-email-wxt@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151129_182858_114289_A66FF23A X-CRM114-Status: GOOD ( 11.61 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Zhang Rui , Dan Carpenter , Caesar Wang MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As the Dan report the smatch check the thermal driver warning: drivers/thermal/rockchip_thermal.c:551 rockchip_configure_from_dt() warn: impossible condition '(thermal->tshut_temp > ((~0 >> 1))) => (s32min-s32max > s32max)' Since the Temperature is currently represented as int not long in the thermal driver. Fixes: commit 437df2172e8d ("thermal: rockchip: consistently use int for temperatures") Reported-by: Dan Carpenter Signed-off-by: Caesar Wang --- Changes in v2: None Changes in v1: None drivers/thermal/rockchip_thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index ae796ec..6b0f00d 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -549,7 +549,7 @@ static int rockchip_configure_from_dt(struct device *dev, thermal->tshut_temp = shut_temp; } - if (thermal->tshut_temp > INT_MAX) { + if (!(thermal->tshut_temp < INT_MAX)) { dev_err(dev, "Invalid tshut temperature specified: %d\n", thermal->tshut_temp); return -ERANGE;