From patchwork Thu Dec 3 08:48:40 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Caesar Wang X-Patchwork-Id: 7757311 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 7F69CBEEE1 for ; Thu, 3 Dec 2015 08:49:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id AC29720439 for ; Thu, 3 Dec 2015 08:49:47 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D96482041F for ; Thu, 3 Dec 2015 08:49:46 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1a4PaE-0003JG-EI; Thu, 03 Dec 2015 08:49:46 +0000 Received: from mail-pa0-f65.google.com ([209.85.220.65]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1a4Pa1-00036E-6p; Thu, 03 Dec 2015 08:49:34 +0000 Received: by pabfh17 with SMTP id fh17so8209049pab.3; Thu, 03 Dec 2015 00:49:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6kUkWnCoA+fxpyEee4qp1MhgtD6W7k0qFmeB/7QL094=; b=hqQQXp6kqVKw4kieRXzXpAiUbUH/5m6wxgmArNZdcVw7hFkYaCNbhENzTUIIVrDxXU jV92sDjN7Xl+/WY/f9gd4xcv/r5xDM3vFjMhjz8w48RncmdXcppu+t3hZxXzeEzxvAQA QYMhttLzAlbLJFTXMaoNR8g0yOfROTNMfn3jA5aQiikYjN1ywuj5mMzdf2pZ9v5EH7UQ cnbTcNQxSR8JsIu72VGHOaFQox4GwY1JGc4QI/WkqUD7MckkRSrfF29rtjTdvoMxz6i2 gdeU6VVAskoTo2CP5GT3G52+rJrZIY/FAArJsCRSMXrvDAjuLZxsPpy4gVyf+FDWogD4 PWsw== X-Received: by 10.66.224.165 with SMTP id rd5mr11374346pac.73.1449132552578; Thu, 03 Dec 2015 00:49:12 -0800 (PST) Received: from localhost.localdomain ([103.29.142.67]) by smtp.gmail.com with ESMTPSA id 13sm9087741pfp.68.2015.12.03.00.49.08 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 03 Dec 2015 00:49:11 -0800 (PST) From: Caesar Wang To: Eduardo Valentin Subject: [PATCH v3 2/5] thermal: rockchip: fix a impossible condition caused by the warning Date: Thu, 3 Dec 2015 16:48:40 +0800 Message-Id: <1449132523-18817-3-git-send-email-wxt@rock-chips.com> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1449132523-18817-1-git-send-email-wxt@rock-chips.com> References: <1449132523-18817-1-git-send-email-wxt@rock-chips.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20151203_004933_436945_22E5D83F X-CRM114-Status: GOOD ( 10.04 ) X-Spam-Score: -2.6 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: huangtao@rock-chips.com, Heiko Stuebner , linux-pm@vger.kernel.org, dmitry.torokhov@gmail.com, dianders@chromium.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, linux-arm-kernel@lists.infradead.org, Zhang Rui , computersforpeace@gmail.com, Dan Carpenter , Caesar Wang MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP As the Dan report the smatch check the thermal driver warning: drivers/thermal/rockchip_thermal.c:551 rockchip_configure_from_dt() warn: impossible condition '(thermal->tshut_temp > ((~0 >> 1))) => (s32min-s32max > s32max)' Let's we remove the imposssible condition Since the Temperature is currently represented as int not long in the thermal driver. Fixes: commit 437df2172e8d ("thermal: rockchip: consistently use int for temperatures") Reported-by: Dan Carpenter Signed-off-by: Caesar Wang --- Changes in v3: - As Brian comments on https://patchwork.kernel.org/patch/7580661/, let's remove the impossible condition. Changes in v2: None Changes in v1: None drivers/thermal/rockchip_thermal.c | 6 ------ 1 file changed, 6 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index ae796ec..611de00 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -549,12 +549,6 @@ static int rockchip_configure_from_dt(struct device *dev, thermal->tshut_temp = shut_temp; } - if (thermal->tshut_temp > INT_MAX) { - dev_err(dev, "Invalid tshut temperature specified: %d\n", - thermal->tshut_temp); - return -ERANGE; - } - if (of_property_read_u32(np, "rockchip,hw-tshut-mode", &tshut_mode)) { dev_warn(dev, "Missing tshut mode property, using default (%s)\n",