From patchwork Thu Jan 21 05:04:12 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 8077471 Return-Path: X-Original-To: patchwork-linux-rockchip@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 6F5A89F1CC for ; Thu, 21 Jan 2016 05:05:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 91DB6205DC for ; Thu, 21 Jan 2016 05:05:29 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 97A9620374 for ; Thu, 21 Jan 2016 05:05:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.80.1 #2 (Red Hat Linux)) id 1aM7R0-0000ax-7h; Thu, 21 Jan 2016 05:05:26 +0000 Received: from mail-pa0-x230.google.com ([2607:f8b0:400e:c03::230]) by bombadil.infradead.org with esmtps (Exim 4.80.1 #2 (Red Hat Linux)) id 1aM7Qy-0008Ly-0m for linux-rockchip@lists.infradead.org; Thu, 21 Jan 2016 05:05:24 +0000 Received: by mail-pa0-x230.google.com with SMTP id yy13so16633013pab.3 for ; Wed, 20 Jan 2016 21:05:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=VuKQuCpfX/EUJKCGSqZzuT798Zb++33D1915/jU/+i8=; b=ndn8puWHeVvSzimkOp7jncrqIbjfFaLx7sYkIO2Yy6TSaBuK8OBulpZYSx5DgcSwQM C1Jh508G3vSow2mRWsLW00Cf8NJqYfBaIUZ5RvXw2eDZ+kxtRdgewL/xaM8+lmFNK0O1 dp6UaG/uKlTl5YxD+xVsqlyS+jrA77S8pdduc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=VuKQuCpfX/EUJKCGSqZzuT798Zb++33D1915/jU/+i8=; b=XO15jSdxiQi85aThM9nOUfJMDoOo/D3Csp+OTorbO4gehGsjfG/1oQ2+alYXlFy8DZ dBz/g8nWufRBHp7g5QYsVLQRft+Fi7cjY0TxxppOD6d5/qtlqu8GmkHTtRhvKCVeghq0 7EpZaHji+EwOAKfnFTakqWJZAZLMEMDfEcqaIcWZNuaFrWPhOi9cKp5gNEGXda8SSez1 m/oSLtUZRlJvIH8XRYOlXeOTyGVWqffTacH73y9OArImb8inVYZUsCHs981br1VjDbgO qya1HX4joHjfDIl79/i3hmu6f+AK6RartJAqyDZMoi/lqvPGfLK9bVepv0X+FiCP1LFr MzFw== X-Gm-Message-State: ALoCoQmxydgG8Qnh/WOaUqAIzMLpvvFhD5XsLf75/1CP3gHuEVkZx/gOqldFDNA6ktHVGIEygPHAZsaqVUtaPwuIJcYJ4ShRTQ== X-Received: by 10.66.219.38 with SMTP id pl6mr58124946pac.147.1453352703155; Wed, 20 Jan 2016 21:05:03 -0800 (PST) Received: from tictac.mtv.corp.google.com ([172.22.65.76]) by smtp.gmail.com with ESMTPSA id z28sm52255589pfi.19.2016.01.20.21.05.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 20 Jan 2016 21:05:02 -0800 (PST) From: Douglas Anderson To: John Youn , balbi@ti.com, kever.yang@rock-chips.com Subject: [PATCH v4 01/21] usb: dwc2: rockchip: Make the max_transfer_size automatic Date: Wed, 20 Jan 2016 21:04:12 -0800 Message-Id: <1453352672-27890-2-git-send-email-dianders@chromium.org> X-Mailer: git-send-email 2.7.0.rc3.207.g0ac5344 In-Reply-To: <1453352672-27890-1-git-send-email-dianders@chromium.org> References: <1453352672-27890-1-git-send-email-dianders@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160120_210524_149362_36332AA9 X-CRM114-Status: GOOD ( 12.77 ) X-Spam-Score: -2.7 (--) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: gregory.herrero@intel.com, =?UTF-8?q?Heiko=20St=C3=BCbner?= , johnyoun@synopsys.com, gregkh@linuxfoundation.org, ming.lei@canonical.com, linux-usb@vger.kernel.org, Douglas Anderson , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, yousaf.kaukab@intel.com, stern@rowland.harvard.edu, Julius Werner , dinguyen@opensource.altera.com MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=ham version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Previously we needed to set the max_transfer_size to explicitly be 65535 because the old driver would detect that our hardware could support much bigger transfers and then would try to do them. This wouldn't work since the DMA alignment code couldn't support it. Later in commit e8f8c14d9da7 ("usb: dwc2: clip max_transfer_size to 65535") upstream added support for clipping this automatically. Since that commit it has been OK to just use "-1" (default), but nobody bothered to change it. Let's change it to default now for two reasons: - It's nice to use autodetected params. - If we can remove the 65535 limit, we can transfer more! Signed-off-by: Douglas Anderson Acked-by: John Youn Tested-by: Heiko Stuebner --- Changes in v4: - Add John's Acks from Changes in v3: None Changes in v2: None drivers/usb/dwc2/platform.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/usb/dwc2/platform.c b/drivers/usb/dwc2/platform.c index 510f787434b3..5008a467ce06 100644 --- a/drivers/usb/dwc2/platform.c +++ b/drivers/usb/dwc2/platform.c @@ -129,7 +129,7 @@ static const struct dwc2_core_params params_rk3066 = { .host_rx_fifo_size = 520, /* 520 DWORDs */ .host_nperio_tx_fifo_size = 128, /* 128 DWORDs */ .host_perio_tx_fifo_size = 256, /* 256 DWORDs */ - .max_transfer_size = 65535, + .max_transfer_size = -1, .max_packet_count = -1, .host_channels = -1, .phy_type = -1,