diff mbox

[v2,09/10] Documentation: devicetree: rockchip: Document Landingship

Message ID 1454897859-7601-10-git-send-email-afaerber@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Färber Feb. 8, 2016, 2:17 a.m. UTC
Use "geekbuying,landingship" compatible string, plus those of GeekBox.

Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 Documentation/devicetree/bindings/arm/rockchip.txt | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Heiko Stuebner Feb. 8, 2016, 10:29 a.m. UTC | #1
Am Montag, 8. Februar 2016, 03:17:38 schrieb Andreas Färber:
> Use "geekbuying,landingship" compatible string, plus those of GeekBox.

I do believe this would be better as geekbuying,geekbox-landingship . They 
might reuse the landingship naming for future baseboards as well ;-)

> 
> Signed-off-by: Andreas Färber <afaerber@suse.de>
> ---
>  v2: New
> 
>  Documentation/devicetree/bindings/arm/rockchip.txt | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt
> b/Documentation/devicetree/bindings/arm/rockchip.txt index
> f633595b196c..c6d95f202591 100644
> --- a/Documentation/devicetree/bindings/arm/rockchip.txt
> +++ b/Documentation/devicetree/bindings/arm/rockchip.txt
> @@ -91,6 +91,11 @@ Rockchip platforms device tree bindings
>      Required root node properties:
>        - compatible = "geekbuying,geekbox", "rockchip,rk3368";
> 
> +- GeekBuying Landingship:
> +    Required root node properties:
> +      - compatible = "geekbuying,landingship",
> +		     "geekbuying,geekbox", "rockchip,rk3368";
> +
>  - Rockchip RK3368 evb:
>      Required root node properties:
>        - compatible = "rockchip,rk3368-evb-act8846", "rockchip,rk3368";
Andreas Färber Feb. 8, 2016, 10:51 a.m. UTC | #2
Am 08.02.2016 um 11:29 schrieb Heiko Stuebner:
> Am Montag, 8. Februar 2016, 03:17:38 schrieb Andreas Färber:
>> Use "geekbuying,landingship" compatible string, plus those of GeekBox.
> 
> I do believe this would be better as geekbuying,geekbox-landingship . They 
> might reuse the landingship naming for future baseboards as well ;-)

Well, the question is: Is this MXM3 interface as generic as Qseven so
that it could be used as is for other modules (and baseboards from other
manufacturers could be used for the module)? Then my thought was
landingship as identifier for the baseboard and geekbox as identifier
for the contained module.

I agree that if this Landingship is specific to the GeekBox then
geekbox-landingship would be more appropriate. We could also do both.

Can you tell? Unfortunately I spot no real documentation of the MXM3
connector pins in the schematics we could compare, only an on-board
documentation of the three-row pins.

Regards,
Andreas
diff mbox

Patch

diff --git a/Documentation/devicetree/bindings/arm/rockchip.txt b/Documentation/devicetree/bindings/arm/rockchip.txt
index f633595b196c..c6d95f202591 100644
--- a/Documentation/devicetree/bindings/arm/rockchip.txt
+++ b/Documentation/devicetree/bindings/arm/rockchip.txt
@@ -91,6 +91,11 @@  Rockchip platforms device tree bindings
     Required root node properties:
       - compatible = "geekbuying,geekbox", "rockchip,rk3368";
 
+- GeekBuying Landingship:
+    Required root node properties:
+      - compatible = "geekbuying,landingship",
+		     "geekbuying,geekbox", "rockchip,rk3368";
+
 - Rockchip RK3368 evb:
     Required root node properties:
       - compatible = "rockchip,rk3368-evb-act8846", "rockchip,rk3368";