diff mbox

[v2,04/10] ARM64: dts: rockchip: Add GMAC to GeekBox

Message ID 1454897859-7601-5-git-send-email-afaerber@suse.de (mailing list archive)
State New, archived
Headers show

Commit Message

Andreas Färber Feb. 8, 2016, 2:17 a.m. UTC
Signed-off-by: Andreas Färber <afaerber@suse.de>
---
 v2: New
 
 arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

Comments

Heiko Stuebner Feb. 8, 2016, 10:28 a.m. UTC | #1
Hi Andreas,

Am Montag, 8. Februar 2016, 03:17:33 schrieb Andreas Färber:
> Signed-off-by: Andreas Färber <afaerber@suse.de>

is there some special reason that gmac, emmc, ir, etc are in separate 
patches? I guess I'll just fold them into the core patch otherwise.


Heiko

> ---
>  v2: New
> 
>  arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts | 20 ++++++++++++++++++++
> 1 file changed, 20 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts index
> bc91d39758ab..a8dcf3c2b0c1 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
> @@ -56,6 +56,13 @@
>  		reg = <0x0 0x0 0x0 0x80000000>;
>  	};
> 
> +	ext_gmac: gmac-clk {
> +		compatible = "fixed-clock";
> +		clock-frequency = <125000000>;
> +		clock-output-names = "ext_gmac";
> +		#clock-cells = <0>;
> +	};
> +
>  	leds: gpio-leds {
>  		compatible = "gpio-leds";
> 
> @@ -82,6 +89,19 @@
>  	};
>  };
> 
> +&gmac {
> +	status = "okay";
> +	phy-supply = <&vcc_lan>;
> +	phy-mode = "rgmii";
> +	clock_in_out = "input";
> +	assigned-clocks = <&cru SCLK_MAC>;
> +	assigned-clock-parents = <&ext_gmac>;
> +	pinctrl-names = "default";
> +	pinctrl-0 = <&rgmii_pins>;
> +	tx_delay = <0x30>;
> +	rx_delay = <0x10>;
> +};
> +
>  &i2c0 {
>  	status = "okay";
Andreas Färber Feb. 8, 2016, 10:40 a.m. UTC | #2
Hi Heiko,

Am 08.02.2016 um 11:28 schrieb Heiko Stuebner:
> Am Montag, 8. Februar 2016, 03:17:33 schrieb Andreas Färber:
>> Signed-off-by: Andreas Färber <afaerber@suse.de>
> 
> is there some special reason that gmac, emmc, ir, etc are in separate 
> patches? I guess I'll just fold them into the core patch otherwise.

Yes, feel free to squash. They are separate because they were not in v1,
it makes them easier to review and I didn't want errors in them to hold
up the base .dts. :) For example, SDIO I am still fighting with.

Cheers,
Andreas
diff mbox

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
index bc91d39758ab..a8dcf3c2b0c1 100644
--- a/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3368-geekbox.dts
@@ -56,6 +56,13 @@ 
 		reg = <0x0 0x0 0x0 0x80000000>;
 	};
 
+	ext_gmac: gmac-clk {
+		compatible = "fixed-clock";
+		clock-frequency = <125000000>;
+		clock-output-names = "ext_gmac";
+		#clock-cells = <0>;
+	};
+
 	leds: gpio-leds {
 		compatible = "gpio-leds";
 
@@ -82,6 +89,19 @@ 
 	};
 };
 
+&gmac {
+	status = "okay";
+	phy-supply = <&vcc_lan>;
+	phy-mode = "rgmii";
+	clock_in_out = "input";
+	assigned-clocks = <&cru SCLK_MAC>;
+	assigned-clock-parents = <&ext_gmac>;
+	pinctrl-names = "default";
+	pinctrl-0 = <&rgmii_pins>;
+	tx_delay = <0x30>;
+	rx_delay = <0x10>;
+};
+
 &i2c0 {
 	status = "okay";