From patchwork Wed Aug 17 21:10:09 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 9286607 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6C2DF600CB for ; Wed, 17 Aug 2016 21:10:53 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 592D5293BE for ; Wed, 17 Aug 2016 21:10:53 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 4D4EA29446; Wed, 17 Aug 2016 21:10:53 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id D6068293BE for ; Wed, 17 Aug 2016 21:10:52 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1ba86s-0000wi-LH; Wed, 17 Aug 2016 21:10:50 +0000 Received: from mail-pa0-x232.google.com ([2607:f8b0:400e:c03::232]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1ba86q-0000m3-5d for linux-rockchip@lists.infradead.org; Wed, 17 Aug 2016 21:10:48 +0000 Received: by mail-pa0-x232.google.com with SMTP id pp5so39369755pac.3 for ; Wed, 17 Aug 2016 14:10:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id; bh=7xasqhT10Xax/dtvp5Ff47uRhntsZXlfo0LC3eMcn0M=; b=bRhs57hANK3DLNMQY/B+FOm/as6WbnV4RNxw0jpB0d6ron5INIo27xfTa0Owzd/gQj 4cs2NEYG0Cvjl5sUHpar4XLh4KJaDmghX5oNnZAamMLe8IYPJl7h7GGkhe2C0Se7AW3D iSrFhcq5THMcRfJHpik+YjRQ6n20v0lhJsSRM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=7xasqhT10Xax/dtvp5Ff47uRhntsZXlfo0LC3eMcn0M=; b=UTBYrt7SmtKqfhSljhImsT2kMJEq7ekaX1VtBYGxs3ZVuvpoKmhEIjzmOyaCEIBKtk E250bxqSkV5s6oJbJ3WVBBBydGcoAqBKw5ViEcWU2Pd3VIg0UV+LOJfi+8L3EmdVIwfp r/gn4FtIsxPTUwzKWDgrJpIP8aJQ6yfLNNJCWbwUD6usd9DMQ2U84CLHarZaB9zFMvma J1LkskrWzU6YkVkLaXa5AO5kkY4PPSewzXZ96lQHPCGatV2gWAUh1LNyw5IhAMmqmW+i WtMBsBgwG4vsTH5peU+foed/XBdIyCs9EgxaXUwK+z2ILx60PHoisigtgQb5EOON1f74 NY1g== X-Gm-Message-State: AEkooutR5SSAjohLkDM9pfF0Ginm3tFALz5rjF3QZY3vdu0VcDADEURJQe7KDFVIQkNgBmKY X-Received: by 10.66.165.67 with SMTP id yw3mr4147816pab.8.1471468226930; Wed, 17 Aug 2016 14:10:26 -0700 (PDT) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id i137sm15827837pfe.64.2016.08.17.14.10.25 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 17 Aug 2016 14:10:25 -0700 (PDT) From: Brian Norris To: Mark Yao Subject: [PATCH] drm/rockchip: analogix_dp: drop unnecessary probe deferral "error" print Date: Wed, 17 Aug 2016 14:10:09 -0700 Message-Id: <1471468209-31192-1-git-send-email-briannorris@chromium.org> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20160817_141048_281298_7A1F69C4 X-CRM114-Status: UNSURE ( 8.83 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , David Airlie , Brian Norris , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, Sean Paul , Yakir Yang MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This driver is the only user of of_drm_find_panel() which prints an error before doing probe deferral, yielding messages like this on boot, before eventually succeeding: [ 2.234271] [drm:rockchip_dp_probe] *ERROR* failed to find panel ... [ 4.797539] [drm:rockchip_dp_probe] *ERROR* failed to find panel ... Let's just drop the message. Signed-off-by: Brian Norris Reviewed-by: Sean Paul --- drivers/gpu/drm/rockchip/analogix_dp-rockchip.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c index 89aadbf465f8..045fcc46827c 100644 --- a/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c +++ b/drivers/gpu/drm/rockchip/analogix_dp-rockchip.c @@ -381,10 +381,8 @@ static int rockchip_dp_probe(struct platform_device *pdev) panel = of_drm_find_panel(panel_node); of_node_put(panel_node); - if (!panel) { - DRM_ERROR("failed to find panel\n"); + if (!panel) return -EPROBE_DEFER; - } } dp = devm_kzalloc(dev, sizeof(*dp), GFP_KERNEL);