From patchwork Fri Nov 18 23:52:56 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Brian Norris X-Patchwork-Id: 9437685 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 6E43560237 for ; Fri, 18 Nov 2016 23:53:30 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 5F3DB28B98 for ; Fri, 18 Nov 2016 23:53:30 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 542CD29A60; Fri, 18 Nov 2016 23:53:30 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.9]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4DA3C29A5D for ; Fri, 18 Nov 2016 23:53:28 +0000 (UTC) Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.85_2 #1 (Red Hat Linux)) id 1c7syF-0002VB-Kr; Fri, 18 Nov 2016 23:53:27 +0000 Received: from mail-pg0-x233.google.com ([2607:f8b0:400e:c05::233]) by bombadil.infradead.org with esmtps (Exim 4.85_2 #1 (Red Hat Linux)) id 1c7syA-0001wk-RL for linux-rockchip@lists.infradead.org; Fri, 18 Nov 2016 23:53:24 +0000 Received: by mail-pg0-x233.google.com with SMTP id x23so104963892pgx.1 for ; Fri, 18 Nov 2016 15:53:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=9kMkrSkvWM7QGbdRwhTQQpqGU/GzV4cxs0SB/0laE5I=; b=RTj7ckMr8mO5FMnGoV7pgHPky3IUBjWO6kNA4mPAW6UoCzYnWmjuNOZSAlIEtOmpJj KHGtgEJbi6Q77HKsBvkRxqCCWHWOYq999M25bjTKikbfCQHP0yRtFNFRIm9bF38FOAEY 6qp/Kc5LL6kmWea1R/LOASyhzMgSjrCsYHXDU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=9kMkrSkvWM7QGbdRwhTQQpqGU/GzV4cxs0SB/0laE5I=; b=WtjeexhRLqcxSoDjkn0fJb3+vqA/9QELsbMxpfJdW8bKyURWI1OSpqerPZBbXjgFJ+ 3UwU2K1YHbvIVjgdvYq1aqkNqRvggk56aPv6SAbs0eS3grZDjUa8Q3lNkdpaZ4TUf3zN Igp7vvisasVcB/TQZ1hFdjpohyuHm668hMY3+cykSgA6cfUCb/x/HkV/m7oDu0Ja8KF5 6Y/FpjE/nuSOkgxfMP4uP9TgJ1B6jLH+yc4zsVT2U1jhQa1Dzktc1K6jrIVFW/Fjbxf4 /7pnpavJNi91qLeHzUzygXqcWZAAy9zHglyIiupvQVtuS3vZy63eHCUd5pGUyaGQ4HU8 pCyw== X-Gm-Message-State: AKaTC00C1VbBZepAeYmW4F/ht4cDXdHWp0zFGfyu1ibogxmCRlzzWlUQHJYSRPLCXSZi2Z+a X-Received: by 10.99.44.84 with SMTP id s81mr4634233pgs.153.1479513182064; Fri, 18 Nov 2016 15:53:02 -0800 (PST) Received: from ban.mtv.corp.google.com ([172.22.64.120]) by smtp.gmail.com with ESMTPSA id t21sm20428247pfa.1.2016.11.18.15.53.01 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 18 Nov 2016 15:53:01 -0800 (PST) From: Brian Norris To: Zhang Rui , Eduardo Valentin Subject: [PATCH 2/3] thermal: rockchip: improve conversion error messages Date: Fri, 18 Nov 2016 15:52:56 -0800 Message-Id: <1479513177-81504-2-git-send-email-briannorris@chromium.org> X-Mailer: git-send-email 2.8.0.rc3.226.g39d4020 In-Reply-To: <1479513177-81504-1-git-send-email-briannorris@chromium.org> References: <1479513177-81504-1-git-send-email-briannorris@chromium.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20161118_155323_024411_72F68685 X-CRM114-Status: UNSURE ( 9.10 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Heiko Stuebner , linux-pm@vger.kernel.org, Brian Norris , linux-kernel@vger.kernel.org, Stephen Barber , linux-rockchip@lists.infradead.org, Caesar Wang MIME-Version: 1.0 Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP These error messages don't give much information about what went wrong. It would be nice, for one, to see what invalid temperature was being requested when conversion fails. It's also good to return an error when we can't handle a conversion properly. While we're at it, fix the grammar too. Signed-off-by: Brian Norris Reviewed-by: Caesar Wang@rock-chips.com --- Note: it'd probably be even nicer to know which sensor this was, but we've kinda abstracted that one away by this point... drivers/thermal/rockchip_thermal.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c index e227a9f0acf7..35554d146b9d 100644 --- a/drivers/thermal/rockchip_thermal.c +++ b/drivers/thermal/rockchip_thermal.c @@ -424,7 +424,8 @@ static u32 rk_tsadcv2_temp_to_code(struct chip_tsadc_table table, } exit: - pr_err("Invalid the conversion, error=%d\n", error); + pr_err("%s: invalid temperature, temp=%d error=%d\n", + __func__, temp, error); return error; } @@ -475,7 +476,9 @@ static int rk_tsadcv2_code_to_temp(struct chip_tsadc_table table, u32 code, } break; default: - pr_err("Invalid the conversion table\n"); + pr_err("%s: invalid conversion table, mode=%d\n", + __func__, table.mode); + return -EINVAL; } /*