| Message ID | 1488364463-27075-3-git-send-email-daniel.meng@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Mittwoch, 1. März 2017, 18:34:23 CET schrieb Meng Dongyang: > Add u2phy config information in the data of match table for > rk3328. > > Signed-off-by: Meng Dongyang <daniel.meng@rock-chips.com> in general looks good, so Reviewed-by: Heiko Stuebner <heiko@sntech.de> one question below > drivers/phy/phy-rockchip-inno-usb2.c | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/drivers/phy/phy-rockchip-inno-usb2.c > b/drivers/phy/phy-rockchip-inno-usb2.c index 4ea95c2..cf2729c 100644 > --- a/drivers/phy/phy-rockchip-inno-usb2.c > +++ b/drivers/phy/phy-rockchip-inno-usb2.c > @@ -1141,6 +1141,26 @@ static int rockchip_usb2phy_probe(struct > platform_device *pdev) return ret; > } > > +static const struct rockchip_usb2phy_cfg rk3328_phy_cfgs[] = { > + { > + .reg = 0x100, > + .num_ports = 2, > + .phy_tuning = rk3328_usb2phy_tuning, > + .clkout_ctl = { 0x108, 4, 4, 1, 0 }, > + .port_cfgs = { > + [USB2PHY_PORT_HOST] = { > + .phy_sus = { 0x104, 15, 0, 0, 0x1d1 }, > + .ls_det_en = { 0x110, 1, 1, 0, 1 }, > + .ls_det_st = { 0x114, 1, 1, 0, 1 }, > + .ls_det_clr = { 0x118, 1, 1, 0, 1 }, > + .utmi_ls = { 0x120, 17, 16, 0, 1 }, > + .utmi_hstdet = { 0x120, 19, 19, 0, 1 } > + } > + }, > + }, The TRM also talks about the otg-port, so is there a reason for not including it here? Heiko > + { /* sentinel */ } > +}; > + > static const struct rockchip_usb2phy_cfg rk3366_phy_cfgs[] = { > { > .reg = 0x700, > @@ -1223,6 +1243,7 @@ static int rockchip_usb2phy_probe(struct > platform_device *pdev) }; > > static const struct of_device_id rockchip_usb2phy_dt_match[] = { > + { .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs }, > { .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs }, > { .compatible = "rockchip,rk3399-usb2phy", .data = &rk3399_phy_cfgs }, > {}
Hi Meng,
[auto build test ERROR on robh/for-next]
[also build test ERROR on v4.10 next-20170302]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Meng-Dongyang/Documentation-bindings-add-DT-documentation-for-u2phy-and-u2phy-grf/20170302-223541
base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next
config: xtensa-allmodconfig (attached as .config)
compiler: xtensa-linux-gcc (GCC) 4.9.0
reproduce:
wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
make.cross ARCH=xtensa
All errors (new ones prefixed by >>):
>> drivers/phy/phy-rockchip-inno-usb2.c:1143:3: error: unknown field 'phy_tuning' specified in initializer
.phy_tuning = rk3328_usb2phy_tuning,
^
>> drivers/phy/phy-rockchip-inno-usb2.c:1143:17: error: 'rk3328_usb2phy_tuning' undeclared here (not in a function)
.phy_tuning = rk3328_usb2phy_tuning,
^
vim +/phy_tuning +1143 drivers/phy/phy-rockchip-inno-usb2.c
1137 }
1138
1139 static const struct rockchip_usb2phy_cfg rk3328_phy_cfgs[] = {
1140 {
1141 .reg = 0x100,
1142 .num_ports = 2,
> 1143 .phy_tuning = rk3328_usb2phy_tuning,
1144 .clkout_ctl = { 0x108, 4, 4, 1, 0 },
1145 .port_cfgs = {
1146 [USB2PHY_PORT_HOST] = {
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c index 4ea95c2..cf2729c 100644 --- a/drivers/phy/phy-rockchip-inno-usb2.c +++ b/drivers/phy/phy-rockchip-inno-usb2.c @@ -1141,6 +1141,26 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) return ret; } +static const struct rockchip_usb2phy_cfg rk3328_phy_cfgs[] = { + { + .reg = 0x100, + .num_ports = 2, + .phy_tuning = rk3328_usb2phy_tuning, + .clkout_ctl = { 0x108, 4, 4, 1, 0 }, + .port_cfgs = { + [USB2PHY_PORT_HOST] = { + .phy_sus = { 0x104, 15, 0, 0, 0x1d1 }, + .ls_det_en = { 0x110, 1, 1, 0, 1 }, + .ls_det_st = { 0x114, 1, 1, 0, 1 }, + .ls_det_clr = { 0x118, 1, 1, 0, 1 }, + .utmi_ls = { 0x120, 17, 16, 0, 1 }, + .utmi_hstdet = { 0x120, 19, 19, 0, 1 } + } + }, + }, + { /* sentinel */ } +}; + static const struct rockchip_usb2phy_cfg rk3366_phy_cfgs[] = { { .reg = 0x700, @@ -1223,6 +1243,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) }; static const struct of_device_id rockchip_usb2phy_dt_match[] = { + { .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs }, { .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs }, { .compatible = "rockchip,rk3399-usb2phy", .data = &rk3399_phy_cfgs }, {}
Add u2phy config information in the data of match table for rk3328. Signed-off-by: Meng Dongyang <daniel.meng@rock-chips.com> --- drivers/phy/phy-rockchip-inno-usb2.c | 21 +++++++++++++++++++++ 1 file changed, 21 insertions(+)