Message ID | 1488440945-27291-4-git-send-email-daniel.meng@rock-chips.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Meng, [auto build test ERROR on robh/for-next] [also build test ERROR on v4.10] [cannot apply to next-20170303] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Meng-Dongyang/Documentation-bindings-add-assign-clock-property-in-u2phy-node/20170304-192646 base: https://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git for-next config: xtensa-allmodconfig (attached as .config) compiler: xtensa-linux-gcc (GCC) 4.9.0 reproduce: wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # save the attached .config to linux build tree make.cross ARCH=xtensa All errors (new ones prefixed by >>): drivers/phy/phy-rockchip-inno-usb2.c:1143:3: error: unknown field 'phy_tuning' specified in initializer .phy_tuning = rk3328_usb2phy_tuning, ^ drivers/phy/phy-rockchip-inno-usb2.c:1143:17: error: 'rk3328_usb2phy_tuning' undeclared here (not in a function) .phy_tuning = rk3328_usb2phy_tuning, ^ >> drivers/phy/phy-rockchip-inno-usb2.c:1151:5: error: unknown field 'idfall_det_en' specified in initializer .idfall_det_en = { 0x0110, 5, 5, 0, 1 }, ^ >> drivers/phy/phy-rockchip-inno-usb2.c:1152:5: error: unknown field 'idfall_det_st' specified in initializer .idfall_det_st = { 0x0114, 5, 5, 0, 1 }, ^ >> drivers/phy/phy-rockchip-inno-usb2.c:1153:5: error: unknown field 'idfall_det_clr' specified in initializer .idfall_det_clr = { 0x0118, 5, 5, 0, 1 }, ^ >> drivers/phy/phy-rockchip-inno-usb2.c:1154:5: error: unknown field 'idrise_det_en' specified in initializer .idrise_det_en = { 0x0110, 4, 4, 0, 1 }, ^ >> drivers/phy/phy-rockchip-inno-usb2.c:1155:5: error: unknown field 'idrise_det_st' specified in initializer .idrise_det_st = { 0x0114, 4, 4, 0, 1 }, ^ >> drivers/phy/phy-rockchip-inno-usb2.c:1156:5: error: unknown field 'idrise_det_clr' specified in initializer .idrise_det_clr = { 0x0118, 4, 4, 0, 1 }, ^ >> drivers/phy/phy-rockchip-inno-usb2.c:1162:5: error: unknown field 'utmi_iddig' specified in initializer .utmi_iddig = { 0x0120, 6, 6, 0, 1 }, ^ vim +/idfall_det_en +1151 drivers/phy/phy-rockchip-inno-usb2.c 1137 } 1138 1139 static const struct rockchip_usb2phy_cfg rk3328_phy_cfgs[] = { 1140 { 1141 .reg = 0x100, 1142 .num_ports = 2, > 1143 .phy_tuning = rk3328_usb2phy_tuning, 1144 .clkout_ctl = { 0x108, 4, 4, 1, 0 }, 1145 .port_cfgs = { 1146 [USB2PHY_PORT_OTG] = { 1147 .phy_sus = { 0x0100, 15, 0, 0, 0x1d1 }, 1148 .bvalid_det_en = { 0x0110, 2, 2, 0, 1 }, 1149 .bvalid_det_st = { 0x0114, 2, 2, 0, 1 }, 1150 .bvalid_det_clr = { 0x0118, 2, 2, 0, 1 }, > 1151 .idfall_det_en = { 0x0110, 5, 5, 0, 1 }, > 1152 .idfall_det_st = { 0x0114, 5, 5, 0, 1 }, > 1153 .idfall_det_clr = { 0x0118, 5, 5, 0, 1 }, > 1154 .idrise_det_en = { 0x0110, 4, 4, 0, 1 }, > 1155 .idrise_det_st = { 0x0114, 4, 4, 0, 1 }, > 1156 .idrise_det_clr = { 0x0118, 4, 4, 0, 1 }, 1157 .ls_det_en = { 0x0110, 0, 0, 0, 1 }, 1158 .ls_det_st = { 0x0114, 0, 0, 0, 1 }, 1159 .ls_det_clr = { 0x0118, 0, 0, 0, 1 }, 1160 .utmi_avalid = { 0x0120, 10, 10, 0, 1 }, 1161 .utmi_bvalid = { 0x0120, 9, 9, 0, 1 }, > 1162 .utmi_iddig = { 0x0120, 6, 6, 0, 1 }, 1163 .utmi_ls = { 0x0120, 5, 4, 0, 1 }, 1164 }, 1165 [USB2PHY_PORT_HOST] = { --- 0-DAY kernel test infrastructure Open Source Technology Center https://lists.01.org/pipermail/kbuild-all Intel Corporation
diff --git a/drivers/phy/phy-rockchip-inno-usb2.c b/drivers/phy/phy-rockchip-inno-usb2.c index 4ea95c2..0dcccc6 100644 --- a/drivers/phy/phy-rockchip-inno-usb2.c +++ b/drivers/phy/phy-rockchip-inno-usb2.c @@ -1141,6 +1141,57 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) return ret; } +static const struct rockchip_usb2phy_cfg rk3328_phy_cfgs[] = { + { + .reg = 0x100, + .num_ports = 2, + .phy_tuning = rk3328_usb2phy_tuning, + .clkout_ctl = { 0x108, 4, 4, 1, 0 }, + .port_cfgs = { + [USB2PHY_PORT_OTG] = { + .phy_sus = { 0x0100, 15, 0, 0, 0x1d1 }, + .bvalid_det_en = { 0x0110, 2, 2, 0, 1 }, + .bvalid_det_st = { 0x0114, 2, 2, 0, 1 }, + .bvalid_det_clr = { 0x0118, 2, 2, 0, 1 }, + .idfall_det_en = { 0x0110, 5, 5, 0, 1 }, + .idfall_det_st = { 0x0114, 5, 5, 0, 1 }, + .idfall_det_clr = { 0x0118, 5, 5, 0, 1 }, + .idrise_det_en = { 0x0110, 4, 4, 0, 1 }, + .idrise_det_st = { 0x0114, 4, 4, 0, 1 }, + .idrise_det_clr = { 0x0118, 4, 4, 0, 1 }, + .ls_det_en = { 0x0110, 0, 0, 0, 1 }, + .ls_det_st = { 0x0114, 0, 0, 0, 1 }, + .ls_det_clr = { 0x0118, 0, 0, 0, 1 }, + .utmi_avalid = { 0x0120, 10, 10, 0, 1 }, + .utmi_bvalid = { 0x0120, 9, 9, 0, 1 }, + .utmi_iddig = { 0x0120, 6, 6, 0, 1 }, + .utmi_ls = { 0x0120, 5, 4, 0, 1 }, + }, + [USB2PHY_PORT_HOST] = { + .phy_sus = { 0x104, 15, 0, 0, 0x1d1 }, + .ls_det_en = { 0x110, 1, 1, 0, 1 }, + .ls_det_st = { 0x114, 1, 1, 0, 1 }, + .ls_det_clr = { 0x118, 1, 1, 0, 1 }, + .utmi_ls = { 0x120, 17, 16, 0, 1 }, + .utmi_hstdet = { 0x120, 19, 19, 0, 1 } + } + }, + .chg_det = { + .opmode = { 0x0100, 3, 0, 5, 1 }, + .cp_det = { 0x0120, 24, 24, 0, 1 }, + .dcp_det = { 0x0120, 23, 23, 0, 1 }, + .dp_det = { 0x0120, 25, 25, 0, 1 }, + .idm_sink_en = { 0x0108, 8, 8, 0, 1 }, + .idp_sink_en = { 0x0108, 7, 7, 0, 1 }, + .idp_src_en = { 0x0108, 9, 9, 0, 1 }, + .rdm_pdwn_en = { 0x0108, 10, 10, 0, 1 }, + .vdm_src_en = { 0x0108, 12, 12, 0, 1 }, + .vdp_src_en = { 0x0108, 11, 11, 0, 1 }, + }, + }, + { /* sentinel */ } +}; + static const struct rockchip_usb2phy_cfg rk3366_phy_cfgs[] = { { .reg = 0x700, @@ -1223,6 +1274,7 @@ static int rockchip_usb2phy_probe(struct platform_device *pdev) }; static const struct of_device_id rockchip_usb2phy_dt_match[] = { + { .compatible = "rockchip,rk3328-usb2phy", .data = &rk3328_phy_cfgs }, { .compatible = "rockchip,rk3366-usb2phy", .data = &rk3366_phy_cfgs }, { .compatible = "rockchip,rk3399-usb2phy", .data = &rk3399_phy_cfgs }, {}
Add u2phy config information in the data of match table for rk3328. Changes in v2: - add support of otg port Signed-off-by: Meng Dongyang <daniel.meng@rock-chips.com> --- drivers/phy/phy-rockchip-inno-usb2.c | 52 ++++++++++++++++++++++++++++++++++++ 1 file changed, 52 insertions(+)