| Message ID | 1530001004-25036-1-git-send-email-hjc@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Am Dienstag, 26. Juni 2018, 10:16:44 CEST schrieb Sandy Huang: > linebuffer mode should be LB_YUV_3840X5 when width is bigger > than 1280 in yuv mode. > seperate yuv and rgb case make the scl_vop_cal_lb_mode() logic > is clearer. > > Signed-off-by: Sandy Huang <hjc@rock-chips.com> > Link: > https://patchwork.freedesktop.org/patch/msgid/1523960108-190541-1-git-send-> email-hjc@rock-chips.com Missing the "v2" in the subject, but I remembered and found the v1 from april. And it looks great now. Reviewed-by: Heiko Stuebner <heiko@sntech.de>
Hi Sandy, Am Dienstag, 26. Juni 2018, 10:16:44 CEST schrieb Sandy Huang: > linebuffer mode should be LB_YUV_3840X5 when width is bigger > than 1280 in yuv mode. > seperate yuv and rgb case make the scl_vop_cal_lb_mode() logic > is clearer. > > Signed-off-by: Sandy Huang <hjc@rock-chips.com> applied to drm-misc-next Heiko
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h index 084acdd..fcb9104 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.h +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.h @@ -331,16 +331,19 @@ static inline int scl_vop_cal_lb_mode(int width, bool is_yuv) { int lb_mode; - if (width > 2560) - lb_mode = LB_RGB_3840X2; - else if (width > 1920) - lb_mode = LB_RGB_2560X4; - else if (!is_yuv) - lb_mode = LB_RGB_1920X5; - else if (width > 1280) - lb_mode = LB_YUV_3840X5; - else - lb_mode = LB_YUV_2560X8; + if (is_yuv) { + if (width > 1280) + lb_mode = LB_YUV_3840X5; + else + lb_mode = LB_YUV_2560X8; + } else { + if (width > 2560) + lb_mode = LB_RGB_3840X2; + else if (width > 1920) + lb_mode = LB_RGB_2560X4; + else + lb_mode = LB_RGB_1920X5; + } return lb_mode; }
linebuffer mode should be LB_YUV_3840X5 when width is bigger than 1280 in yuv mode. seperate yuv and rgb case make the scl_vop_cal_lb_mode() logic is clearer. Signed-off-by: Sandy Huang <hjc@rock-chips.com> Link: https://patchwork.freedesktop.org/patch/msgid/1523960108-190541-1-git-send-email-hjc@rock-chips.com --- drivers/gpu/drm/rockchip/rockchip_drm_vop.h | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)