| Message ID | 20150124003009.GA14891@dtor-ws (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Dmitry, On Fri, Jan 23, 2015 at 4:30 PM, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > dw_mci_pltfm_remove() is not (nor should it be) marked as __exit, > so we should not be using __exit_p() wrapper with it. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> > --- > drivers/mmc/host/dw_mmc-rockchip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Nice catch, thanks! Reviewed-by: Doug Anderson <dianders@chromium.org> Tested-by: Doug Anderson <dianders@chromium.org>
On 24 January 2015 at 01:30, Dmitry Torokhov <dmitry.torokhov@gmail.com> wrote: > dw_mci_pltfm_remove() is not (nor should it be) marked as __exit, > so we should not be using __exit_p() wrapper with it. > > Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> Thanks! Applied for next. Kind regards Uffe > --- > drivers/mmc/host/dw_mmc-rockchip.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c > index 5650ac4..e2a726a 100644 > --- a/drivers/mmc/host/dw_mmc-rockchip.c > +++ b/drivers/mmc/host/dw_mmc-rockchip.c > @@ -133,7 +133,7 @@ static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops, > > static struct platform_driver dw_mci_rockchip_pltfm_driver = { > .probe = dw_mci_rockchip_probe, > - .remove = __exit_p(dw_mci_pltfm_remove), > + .remove = dw_mci_pltfm_remove, > .driver = { > .name = "dwmmc_rockchip", > .of_match_table = dw_mci_rockchip_match, > -- > 2.2.0.rc0.207.ga3a616c > > > -- > Dmitry
diff --git a/drivers/mmc/host/dw_mmc-rockchip.c b/drivers/mmc/host/dw_mmc-rockchip.c index 5650ac4..e2a726a 100644 --- a/drivers/mmc/host/dw_mmc-rockchip.c +++ b/drivers/mmc/host/dw_mmc-rockchip.c @@ -133,7 +133,7 @@ static SIMPLE_DEV_PM_OPS(dw_mci_rockchip_pmops, static struct platform_driver dw_mci_rockchip_pltfm_driver = { .probe = dw_mci_rockchip_probe, - .remove = __exit_p(dw_mci_pltfm_remove), + .remove = dw_mci_pltfm_remove, .driver = { .name = "dwmmc_rockchip", .of_match_table = dw_mci_rockchip_match,
dw_mci_pltfm_remove() is not (nor should it be) marked as __exit, so we should not be using __exit_p() wrapper with it. Signed-off-by: Dmitry Torokhov <dmitry.torokhov@gmail.com> --- drivers/mmc/host/dw_mmc-rockchip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)