Message ID | 20180115171614.14474-2-thierry.escande@collabora.com (mailing list archive) |
---|---|
State | New, archived |
Headers | show |
Hi Thierry, On Tue, Jan 16, 2018 at 2:15 AM, Thierry Escande <thierry.escande@collabora.com> wrote: > From: Tomasz Figa <tfiga@chromium.org> > > Current code implements prepare_fb and cleanup_fb callbacks only to > grab/release fb references, which is already done by atomic framework > when creating/destryoing plane state. AFAICT this is already gone in current code, so only the part mentioned below remains. > Also there are some unused fields > vop and vop_win structs. Let's remove these unused bits. ^^ Best regards, Tomasz Best regards, Tomasz
diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index ba7505292b78..7a137bc5708c 100644 --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c @@ -95,9 +95,6 @@ struct vop { struct drm_device *drm_dev; bool is_enabled; - /* mutex vsync_ work */ - struct mutex vsync_mutex; - bool vsync_work_pending; struct completion dsp_hold_completion; /* protected by dev->event_lock */ @@ -1567,8 +1564,6 @@ static int vop_bind(struct device *dev, struct device *master, void *data) spin_lock_init(&vop->reg_lock); spin_lock_init(&vop->irq_lock); - mutex_init(&vop->vsync_mutex); - ret = devm_request_irq(dev, vop->irq, vop_isr, IRQF_SHARED, dev_name(dev), vop); if (ret)