From patchwork Mon Jan 22 17:46:22 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Kamil_Trzci=C5=84ski?= X-Patchwork-Id: 10178969 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 9BEDC60390 for ; Mon, 22 Jan 2018 17:47:06 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 89CD926E54 for ; Mon, 22 Jan 2018 17:47:06 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 7E5EE280B0; Mon, 22 Jan 2018 17:47:06 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [65.50.211.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 2DCE526E54 for ; Mon, 22 Jan 2018 17:47:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=7lLap7V/xShzp80OW3o3RCvyEg9Dc5UVa/X+mxI4zEk=; b=nNSKiaBl50f59R yTlMSd5KTFVmhF5WNJ84bWbigwlvN5uRmgr77ahErsTCFjGwx3E7E7HSH4FKF1+zqXyCWJw24Nb1v 1T2sYwi07M1caGjXF5JSn5dd+nOx4FoWh90SGvXbPqd9x/1Kk56MgotsL2Q8VxIGFKZZVUJ6xyjJx BQG3HBJAbaEKEcddDi8SPz7/xjp80L2dDIC34MCDVM1MQqku7m4XtWavMNgqqBWcWHTxaRjBVLbEt vE3bYyVOc+Z9WhMGAXb5gTkJ0a3wAYoxK2jkUW1xS+ghttL4oG5flYFB5qP7amo7O7zc1iOJ+i4cy ehbz1Y4TAjToxtBp9dDA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.89 #1 (Red Hat Linux)) id 1edgBT-00024Q-NR; Mon, 22 Jan 2018 17:47:03 +0000 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]) by bombadil.infradead.org with esmtps (Exim 4.89 #1 (Red Hat Linux)) id 1edgBE-0001pZ-91 for linux-rockchip@lists.infradead.org; Mon, 22 Jan 2018 17:46:50 +0000 Received: by mail-wm0-x244.google.com with SMTP id v71so18524307wmv.2 for ; Mon, 22 Jan 2018 09:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ayufan-eu.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xClyDNai+rFTl8fCZbaY0FPNW/Rpw46sHAInTtHqTfc=; b=wrXU6zPJQVAcTbB0ZoMkkphaDHkp9FPu6mZj2lswkEeLfwTWbPRFBaiyp1uLBHDCKI mFpxfDlGg0bFRmYMVa6z5OfZhHXW1ixNCmPoXPVaOOXVbrQRW5RUVmva9IX56xDNWH1k qLEhwgJ7uGdvzueLX5IdaF1qConBRqu4AdF5cVXfkW+w2afz1Ltj9v4zRNG0JPhIciVd 1YyCa0aONgddnS/A0dV3doMpQZ40JA10+lhgnmalPjrNX0lfSGiYnRg0XrniYFa8Agsu 3ZNZ71ewCgG0JhiwqpVQZwRYTC8lMTs0kE9ImsTpxVUW21slpkxsT/l/3QAoqL0pEYWF 9cVw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=xClyDNai+rFTl8fCZbaY0FPNW/Rpw46sHAInTtHqTfc=; b=M88nO+T/kdHhYLscIuZXcevS6I0H3P9AEjAi2+58ACRIfa4l8B0gMTJgY0qVS4m6A8 JrkmesnLP26z9Iuo4wRkEdPuuiqX/xvaSWlR7YXYoEt0n9uNs5tpGRJxhTv+jA2XCrmi mguEI7L+OVxt+42eXyJaoIYW/s2/cS1zPj04oIjqASq6UMu5eWBFwWblXift0yAds1sq GFNWVfCj5LV7divBl84tGJcR7ADtWUKO9uO0llZffvNt6qnw+RavKczF6+IH0KaZiflB zmv2GYRJImLgKyhl2lXb1JW2GK+GGgDLdxaMS9rvYQI/qxrfTIWjt+2PFuR4UV6ENigJ P1Rg== X-Gm-Message-State: AKwxytezJBPP7JFEw0JH5Ou3Lt0st/IcDcwoBryKvjKnFIOMElQL+TDl olFZOR333ov+Kt8yZm+clB20HQ== X-Google-Smtp-Source: AH8x227etWhcfNXpDjCrL/dLV4hzCrxlRfmVRjquPg6ego7G7jaWR6t8YzGUqRdISFIeQb48JUfGCA== X-Received: by 10.80.220.70 with SMTP id y6mr14521995edk.236.1516643195844; Mon, 22 Jan 2018 09:46:35 -0800 (PST) Received: from ubuntu.home (89-76-148-210.dynamic.chello.pl. [89.76.148.210]) by smtp.gmail.com with ESMTPSA id w28sm11541541edl.43.2018.01.22.09.46.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 22 Jan 2018 09:46:35 -0800 (PST) From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= To: Subject: [PATCH] rock64: dts: fix gmac2io stability issues Date: Mon, 22 Jan 2018 18:46:22 +0100 Message-Id: <20180122174628.15613-1-ayufan@ayufan.eu> X-Mailer: git-send-email 2.14.1 MIME-Version: 1.0 X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Heiko Stuebner , Catalin Marinas , Will Deacon , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Rob Herring , linux-arm-kernel@lists.infradead.org, David Wu , =?UTF-8?q?Kamil=20Trzci=C5=84ski?= , "David S. Miller" , Liang Chen , Joseph Chen Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP This commit enables thresh dma mode as this forces to disable checksuming, and chooses delay values which make the interface stable. These changes are needed, because ROCK64 is faced with two problems: 1. tx checksuming does not work with packets larger than 1498, 2. the default delays for tx/rx are not stable when using 1Gbps connection. Delays were found out with: https://github.com/ayufan-rock64/linux-build/tree/master/recipes/gmac-delays-test Change-Id: Ie894df4b52122988da683c02e3a05d635a5c7b84 Signed-off-by: Kamil Trzciński --- arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts index 5602ec01fed9..bcc0bb35d840 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts @@ -132,8 +132,6 @@ assigned-clocks = <&cru SCLK_MAC2IO>, <&cru SCLK_MAC2IO_EXT>; assigned-clock-parents = <&gmac_clkin>, <&gmac_clkin>; clock_in_out = "input"; - /* shows instability at 1GBit right now */ - max-speed = <100>; phy-supply = <&vcc_io>; phy-mode = "rgmii"; pinctrl-names = "default"; @@ -141,8 +139,9 @@ snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; snps,reset-active-low; snps,reset-delays-us = <0 10000 50000>; - tx_delay = <0x26>; - rx_delay = <0x11>; + snps,force_thresh_dma_mode; + tx_delay = <0x24>; + rx_delay = <0x18>; status = "okay"; };