diff mbox series

arm64: dts: rock960: Enable tsadc device

Message ID 20190215152539.16606-1-ezequiel@collabora.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: rock960: Enable tsadc device | expand

Commit Message

Ezequiel Garcia Feb. 15, 2019, 3:25 p.m. UTC
Enable the thermal sensor. This device also provides
temperature shutdown protection. The shutdown value is
set at 110C, as tested by the vendor.

Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
---
 arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Heiko Stübner Feb. 15, 2019, 11:14 p.m. UTC | #1
Hi Ezequiel,

Am Freitag, 15. Februar 2019, 16:25:39 CET schrieb Ezequiel Garcia:
> Enable the thermal sensor. This device also provides
> temperature shutdown protection. The shutdown value is
> set at 110C, as tested by the vendor.
> 
> Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> ---
>  arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index
> d64d5ac0804a..599c9752ed4d 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> @@ -634,3 +634,10 @@
>          mali-supply = <&vdd_gpu>;
>          status = "okay";
>  };

doesn't apply against my 5.1/dts64 branch and our rock960.dtsi
also does not have a mali node yet (especially also not one with
space-indentation ;-) ).


Heiko

> +
> +&tsadc {
> +	rockchip,hw-tshut-mode = <1>;
> +	rockchip,hw-tshut-polarity = <1>;
> +	rockchip,hw-tshut-temp = <110000>;
> +	status = "okay";
> +};
Ezequiel Garcia Feb. 16, 2019, 2:55 a.m. UTC | #2
On Sat, 2019-02-16 at 00:14 +0100, Heiko Stübner wrote:
> Hi Ezequiel,
> 
> Am Freitag, 15. Februar 2019, 16:25:39 CET schrieb Ezequiel Garcia:
> > Enable the thermal sensor. This device also provides
> > temperature shutdown protection. The shutdown value is
> > set at 110C, as tested by the vendor.
> > 
> > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > ---
> >  arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index
> > d64d5ac0804a..599c9752ed4d 100644
> > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > @@ -634,3 +634,10 @@
> >          mali-supply = <&vdd_gpu>;
> >          status = "okay";
> >  };
> 
> doesn't apply against my 5.1/dts64 branch and our rock960.dtsi
> also does not have a mali node yet (especially also not one with
> space-indentation ;-) ).
> 
> 

Sorry about that, it was based on your for-next branch,
but a mali patch slipped through.

> Heiko
> 
> > +
> > +&tsadc {
> > +	rockchip,hw-tshut-mode = <1>;
> > +	rockchip,hw-tshut-polarity = <1>;
> > +	rockchip,hw-tshut-temp = <110000>;
> > +	status = "okay";
> > +};
> 
> 
>
Heiko Stübner Feb. 16, 2019, 8:34 p.m. UTC | #3
Am Samstag, 16. Februar 2019, 03:55:01 CET schrieb Ezequiel Garcia:
> On Sat, 2019-02-16 at 00:14 +0100, Heiko Stübner wrote:
> > Hi Ezequiel,
> > 
> > Am Freitag, 15. Februar 2019, 16:25:39 CET schrieb Ezequiel Garcia:
> > > Enable the thermal sensor. This device also provides
> > > temperature shutdown protection. The shutdown value is
> > > set at 110C, as tested by the vendor.
> > > 
> > > Signed-off-by: Ezequiel Garcia <ezequiel@collabora.com>
> > > ---
> > >  arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi | 7 +++++++
> > >  1 file changed, 7 insertions(+)
> > > 
> > > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi index
> > > d64d5ac0804a..599c9752ed4d 100644
> > > --- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
> > > @@ -634,3 +634,10 @@
> > >          mali-supply = <&vdd_gpu>;
> > >          status = "okay";
> > >  };
> > 
> > doesn't apply against my 5.1/dts64 branch and our rock960.dtsi
> > also does not have a mali node yet (especially also not one with
> > space-indentation ;-) ).
> > 
> > 
> 
> Sorry about that, it was based on your for-next branch,
> but a mali patch slipped through.

I've fixed that up now and applied the fixed version for 5.1.
I've also moved the &tsadc to the correct position - alphabetically
between sdmmc and uart0. Please keep sorting in mind for future
additions ;-) .


Thanks
Heiko
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
index d64d5ac0804a..599c9752ed4d 100644
--- a/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
+++ b/arch/arm64/boot/dts/rockchip/rk3399-rock960.dtsi
@@ -634,3 +634,10 @@ 
         mali-supply = <&vdd_gpu>;
         status = "okay";
 };
+
+&tsadc {
+	rockchip,hw-tshut-mode = <1>;
+	rockchip,hw-tshut-polarity = <1>;
+	rockchip,hw-tshut-temp = <110000>;
+	status = "okay";
+};