diff mbox series

[1/2] pwm: rockchip: Don't update the state for the caller of pwm_apply_state()

Message ID 20190312083537.23748-2-u.kleine-koenig@pengutronix.de (mailing list archive)
State New, archived
Headers show
Series pwm: ensure pwm_apply_state() doesn't modify the state argument | expand

Commit Message

Uwe Kleine-König March 12, 2019, 8:35 a.m. UTC
The pwm-rockchip driver is the only PWM driver which updates the state
for the caller of pwm_apply_state(). This might have surprising results
if the caller reuses the values expecting them to still represent the
same state. Also note that this feedback was incomplete as the matching
struct pwm_device::state wasn't updated and so pwm_get_state still
returned the originally requested state.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
 drivers/pwm/pwm-rockchip.c | 6 ------
 1 file changed, 6 deletions(-)
diff mbox series


diff --git a/drivers/pwm/pwm-rockchip.c b/drivers/pwm/pwm-rockchip.c
index 4d99d468df09..16186bcd99e0 100644
--- a/drivers/pwm/pwm-rockchip.c
+++ b/drivers/pwm/pwm-rockchip.c
@@ -215,12 +215,6 @@  static int rockchip_pwm_apply(struct pwm_chip *chip, struct pwm_device *pwm,
 			goto out;
-	/*
-	 * Update the state with the real hardware, which can differ a bit
-	 * because of period/duty_cycle approximation.
-	 */
-	rockchip_pwm_get_state(chip, pwm, state);