From patchwork Thu Mar 28 17:17:10 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10875541 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 367331669 for ; Thu, 28 Mar 2019 17:18:42 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 0F67128B49 for ; Thu, 28 Mar 2019 17:18:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 0381428BE7; Thu, 28 Mar 2019 17:18:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 92CC128B49 for ; Thu, 28 Mar 2019 17:18:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=VDPGmcnVCuHFnrzEHLsVDYFL1htXLtxyH29f2Yyz3I8=; b=EbeIkIeqIuEXms kAwEeaNZRGsjQ91Ua4afNvWRyNbx+z7H1y9224AmLxtQUX7cae8VIYpCHB5i8fS0IvxusQwUazHfg v+UgYh3DbR9JTc5aR4DrAFVmggCpcoUx86eZPM+UgLYyER9RxzxhUznqUupL1YqzbdD3Tss57tzm4 KLHb61mHalQB4TzfOE8ds048SV19IR2O62GzswOqw9ibQC2kJ3CM4Uf9N3v1DKUosNv/9C4xBqrCz yOfdnxQEFjVfkWQB2r688vSuMigo7+ADeUmJ5ImJV1RUH/RDkj8nSkSoo3IR94o4jyLFHTFjNhSeK MRCyuQo1+g7HgyguGTmQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9Yfm-00084T-4R; Thu, 28 Mar 2019 17:18:38 +0000 Received: from mail-pl1-x641.google.com ([2607:f8b0:4864:20::641]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9YfE-0007Rg-QA for linux-rockchip@lists.infradead.org; Thu, 28 Mar 2019 17:18:10 +0000 Received: by mail-pl1-x641.google.com with SMTP id k2so5258287plt.3 for ; Thu, 28 Mar 2019 10:18:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=9vt45JTo9+c6j8dWNrO0OHz+tpId79deEfwrm9YqjVA=; b=C0sXUDY310SL/SQYeRt4iQe5a7IZUNKd2ajEsEMma+zuySpcP46oeny6KE9+HvqCCb fN8X9jGjPYtVY98XypzXk7M779imEhiwyHtsPbCogehzomsLOXt5a0NgUr3tZU+p50UY GsxEaaAIt0s/GZv1v0PtUwNUIWSAb8nqrs8FM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=9vt45JTo9+c6j8dWNrO0OHz+tpId79deEfwrm9YqjVA=; b=Ble+rifaezOtqak5u069Dm1Qjw2syC6WSHAC/cYVBdhfX+Ypw5L3aPOw4twXDsfchI COyT1I9z6chEV5lM7qcbOgTDsXiGOd1roYxgg9yP5H1RQ0TMWSWcV+/FQAC6cZ1079Uq JRVK+vktK4seBPIBjeQalIH9H4GIDarRn7h2OPq1lvYq8/1W6E4j2fSCxgEykHZDfiQH nGU/Y6yzkRH79S0NZJtMGge+hiBEgFjRY5c7KepS1lww4ytKGKUZMUURjAwCfmxUXiJ9 OZF4er35waU5lTsVTBix/WCAiKcrZtY5vUD90RsQkBBTvqCV0AqG0GWGvivzhflXtorI k4JA== X-Gm-Message-State: APjAAAWnvbL4quNC/6x3cX6kHpf23ThCX1Fc8wO6TPbq/01NbMN6ZYIz AJC3oLTRlLiNFW3EVt4G740XZQ== X-Google-Smtp-Source: APXvYqy6oeccNYbpih420nJpkiSJvEecbt9/dnOQ+Wdy7u1wEm70eNYUBkQD9q8fhTg2nXIVeJ/zvQ== X-Received: by 2002:a17:902:7587:: with SMTP id j7mr25505653pll.304.1553793483508; Thu, 28 Mar 2019 10:18:03 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id r10sm31699414pfn.188.2019.03.28.10.18.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 28 Mar 2019 10:18:02 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Subject: [PATCH v4 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings Date: Thu, 28 Mar 2019 10:17:10 -0700 Message-Id: <20190328171710.31949-8-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190328171710.31949-1-dianders@chromium.org> References: <20190328171710.31949-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190328_101805_272213_408BA685 X-CRM114-Status: GOOD ( 15.89 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , =?utf-8?q?Enric_Balle?= =?utf-8?q?tb=C3=B2?= , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Just like rk3288-veyron-jerry, we want to be able to use one of the fixed PLLs in the system to make the pixel clock for minnie. Specifying these timings matches us with how the display is used on the downstream Chrome OS kernel. See https://crrev.com/c/323211. Unlike jerry, this CL actually changes the timings (though not the pixel clock) that is used when using the upstream kernel. Booting up a minnie shows that it ended up with a 66.67 MHz pixel clock but it was still using the porches/blankings it would have wanted for a 72.5 MHz pixel clock. NOTE: compared to the downstream kernel, this seems to cause a slightly different result reported in the 'modetest' command on a Chromebook. The downstream kernel shows: 1280x800 60 1280 1298 1330 1351 800 804 822 830 66667 With this patch we have: 1280x800 59 1280 1298 1330 1351 800 804 822 830 66666 Specifically modetest was reporting 60 Hz on the downstream kernel but the upstream kernel does the math and comesup with 59 (because we actually achieve 59.45 Hz). Also upstream doesn't round the Hz up when converting to kHz--it seems to truncate. ALSO NOTE: when I look at the EDID from the datasheet, I see: -hsync -vsync ...but it seems like we've never actually run with that so I've continued leaving that out. Signed-off-by: Douglas Anderson --- Changes in v4: - rk3288-veyron-minnie patch new for v4. Changes in v3: None Changes in v2: None arch/arm/boot/dts/rk3288-veyron-minnie.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index ca7512ade222..8179cf9f6e98 100644 --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts @@ -144,6 +144,18 @@ power-supply= <&panel_regulator>; /delete-node/ panel-timing; + + panel-timing { + clock-frequency = <66666667>; + hactive = <1280>; + hfront-porch = <18>; + hback-porch = <21>; + hsync-len = <32>; + vactive = <800>; + vfront-porch = <4>; + vback-porch = <8>; + vsync-len = <18>; + }; }; &rk808 {