From patchwork Mon Apr 1 17:17:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10880401 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 23C54184E for ; Mon, 1 Apr 2019 17:18:43 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id F0D97287F2 for ; Mon, 1 Apr 2019 17:18:42 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id EEB6C288AC; Mon, 1 Apr 2019 17:18:42 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.0 required=2.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 883CC287F2 for ; Mon, 1 Apr 2019 17:18:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=gEIP4Pe8WMZqjyNqrWuz8lLj6mOgzXVyQGlu9/OCL80=; b=idK1Gu4ikFGX1d 5Mw8//OyCQSQLYzRdoEcab6DFs1jO+S0sO23eNTEf6dvCAhhxyYx+niRSdU6pwCcp2UJttieNm4c8 3ZUCt/nP94m/U+b9UCAdKb55y+Qc3VB4fRA/aURzBQUx2H7/nv/qJlKNxc3DL7Pip5XfnnNR88a25 wl3L8mylNtdtLrx1TFlEgTOkiKZYvs632KV468fdPUiQlkXQFmyKcIccFzKDYcUyLb81OZjmNTo5o Qcs4xTto/w8w51OqL801fUSHHjnQ+WD6huE1tqs61kV3yXLffIJIPvp3igXMJaa20IEjZpKxVXkms 5PbTS5rrTjBmjtRZrgNg==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0Zy-000577-C9; Mon, 01 Apr 2019 17:18:38 +0000 Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB0ZN-0004H7-Na for linux-rockchip@lists.infradead.org; Mon, 01 Apr 2019 17:18:09 +0000 Received: by mail-pl1-x642.google.com with SMTP id w23so1863911ply.4 for ; Mon, 01 Apr 2019 10:18:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=92at8vUta2fC2XN1pKFFPCkHFJWYYJixqtIuh16qRd8=; b=PuwiY+gDlXPS2BRq9eoaWfWDB2j1H9/9kFlbWKpKuyv8x775CHcSkF9PtohFS4L/AN MebDQWa6TzOmQI9Eube6euAXCCKTMrw6qMGxcM5K/N5P4sbK1MUGLtfvv7yQniVwylxv 55ROovHraJqtpI0gXazttyeJFmpeBD8bAjIVo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=92at8vUta2fC2XN1pKFFPCkHFJWYYJixqtIuh16qRd8=; b=r5SWMCNa2fsFSev+GmT6yOQfKuOQ1nfLu2G2D2ij20BHM9z0AyT/dJxXKy50v5sALU DeZ/rl0BpBRlAuRLU8+Z9sjEmTZQmIsSK8vjCWf4KMNo+Gfva2Vr/h0NhL8LzFiJ0jZI HcnK/8PUOx+d0X00njTBbY4SU7K6aPdROibt8KGwWZEA0Gdg4U6Ki7gIvnuuUKmZYvfN zGGtbv4PbeqhTQ8UB1OCcrgjIMj1TxBUPKmaG5WSE14XShq0mLuzQNHm6+4WWzdiFHWK 5c6WO74iKSZEghbNsAIfIscwinpL3aGnh95Gw//E+xsO20dyKuWVX+zSde7VzfCl3NK+ AsUw== X-Gm-Message-State: APjAAAWgzWHrKkEG/uCz5YkkQVLhMmqNUj/tKyBo1ZF6IGxrCOVZ3z2N bUyXo7gT6yldP9b5XiG2ZXWLYA== X-Google-Smtp-Source: APXvYqwXPIDZF3EjTK+apAxCXhBFSTWfuVlSfZa4zc0Zr6UCqPiw0E8+9YtFgMTzXnmJco5r2/Nunw== X-Received: by 2002:a17:902:b217:: with SMTP id t23mr66226168plr.184.1554139081162; Mon, 01 Apr 2019 10:18:01 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y12sm31370112pgq.64.2019.04.01.10.17.59 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 10:18:00 -0700 (PDT) From: Douglas Anderson To: Thierry Reding , Heiko Stuebner , Sean Paul Subject: [PATCH v5 7/7] ARM: dts: rockchip: Specify rk3288-veyron-minnie's display timings Date: Mon, 1 Apr 2019 10:17:24 -0700 Message-Id: <20190401171724.215780-8-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190401171724.215780-1-dianders@chromium.org> References: <20190401171724.215780-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_101802_177289_6B12CFF2 X-CRM114-Status: GOOD ( 16.50 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, Rob Herring , Douglas Anderson , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Boris Brezillon , Laurent Pinchart , =?utf-8?q?Enric_Balle?= =?utf-8?q?tb=C3=B2?= , Ezequiel Garcia , mka@chromium.org, linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP Just like we did for rk3288-veyron-chromebook, we want to be able to use one of the fixed PLLs in the system to make the pixel clock for minnie. Specifying these timings matches us with how the display is used on the downstream Chrome OS kernel. See https://crrev.com/c/323211. Unlike what we did for rk3288-veyron-chromebook, this CL actually changes the timings (though not the pixel clock) that is used when using the upstream kernel. Booting up a minnie shows that it ended up with a 66.67 MHz pixel clock but it was still using the porches/blankings it would have wanted for a 72.5 MHz pixel clock. NOTE: compared to the downstream kernel, this seems to cause a slightly different result reported in the 'modetest' command on a Chromebook. The downstream kernel shows: 1280x800 60 1280 1298 1330 1351 800 804 822 830 66667 With this patch we have: 1280x800 59 1280 1298 1330 1351 800 804 822 830 66666 Specifically modetest was reporting 60 Hz on the downstream kernel but the upstream kernel does the math and comesup with 59 (because we actually achieve 59.45 Hz). Also upstream doesn't round the Hz up when converting to kHz--it seems to truncate. ALSO NOTE: when I look at the EDID from the datasheet, I see: -hsync -vsync ...but it seems like we've never actually run with that so I've continued leaving that out. Signed-off-by: Douglas Anderson --- Changes in v5: - It's not just jerry, it's most rk3288 Chromebooks (Heiko) Changes in v4: - rk3288-veyron-minnie patch new for v4. Changes in v3: None Changes in v2: None arch/arm/boot/dts/rk3288-veyron-minnie.dts | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/rk3288-veyron-minnie.dts b/arch/arm/boot/dts/rk3288-veyron-minnie.dts index ca7512ade222..8179cf9f6e98 100644 --- a/arch/arm/boot/dts/rk3288-veyron-minnie.dts +++ b/arch/arm/boot/dts/rk3288-veyron-minnie.dts @@ -144,6 +144,18 @@ power-supply= <&panel_regulator>; /delete-node/ panel-timing; + + panel-timing { + clock-frequency = <66666667>; + hactive = <1280>; + hfront-porch = <18>; + hback-porch = <21>; + hsync-len = <32>; + vactive = <800>; + vfront-porch = <4>; + vback-porch = <8>; + vsync-len = <18>; + }; }; &rk808 {