From patchwork Mon Apr 1 18:20:29 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "Leonidas P. Papadakos" X-Patchwork-Id: 10880485 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BF5321669 for ; Mon, 1 Apr 2019 18:21:02 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A45D628820 for ; Mon, 1 Apr 2019 18:21:02 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A240E283BD; Mon, 1 Apr 2019 18:21:02 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED,DKIM_VALID,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=unavailable version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 561F3288B3 for ; Mon, 1 Apr 2019 18:21:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-Id:Date:Subject:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Dwl6f3g0tTx7u6oiPHMsqBdvw+8mVXhfExC4Zr0LIJc=; b=BdO7NGcop48o3F +UDRRgny/C/fA6FPxijONchAl6FQxAChUn1lBG3QYMfP2uOAjp+Ak94xK+3mI981TXMoXY1E7zfAK yrnONd10xSj9zPwEdYtWiDh7eiBnVN5fedu7kurlUvuTSrdpT/ohsk3c+CP26yp8S3f1u2RjajQ0N Fff0sPKOolSBjxIT+gYizeb+19JeP9zXifh98DQc40dLfJkNL43ykVlzPd6Jw/O6B7J8zoxGu6hJD BPX07ySmyVQM4p2aWOmCjJPA2Y/Hxp8DwUeglrwPfXgqYSOYug1OOi3pgGNWLc5MWPlnuuCELz9MD w9hPxeIHM4TD109Pq0KQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1YG-0000aQ-VS; Mon, 01 Apr 2019 18:20:56 +0000 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hB1Y7-0000RV-Ky; Mon, 01 Apr 2019 18:20:48 +0000 Received: by mail-wm1-x344.google.com with SMTP id r186so573993wmf.1; Mon, 01 Apr 2019 11:20:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rSh5VVkG9WipijbhAmyfU9722WPS5gvQw5koNSuFkG0=; b=GYU6vlIcs5FpHcGpqJxeul7ekQGSiEZ7VXOdwyXb0idZrG2JOVbgtju4qj6U1sDp87 95cjAv3oUhfC8aw1Ae8UacYGOOoSMBLiw50ppzcLVU+Igslr0j0dPRYGzwmTnv+WXpAA BdI/kRI+4nPdg/a3A6w6f7EPcn8vgmVdhbTmdzI1WPqxd03FD+0rS7XavIWzmhphlH50 fgronN4aYU3U+9RjF5HH1jYL4Fh7iPJWiUyX+4iN/4hHHEV80TjRfSS4S3lPRk/jlWsI AFVr85takNEhloZPPgU3IdYvfi9SFEkg/Ghkbpm41twdkPzlKDzUigD9/9w59XzZjDbC raWw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rSh5VVkG9WipijbhAmyfU9722WPS5gvQw5koNSuFkG0=; b=uFLiSoc6gKMp2oAs3BnHWnSJpEsMrgzOA7ORSaNQl7zj3/p1hUR6aRuL7iPaCpHyFY N7/wEn0YTiJ+ZptSUgZ9IY7ic49UBXAMdw/S7oXo7KRcdo4LJ+/+4dxcwRcaAz/xPcuU IJpkONqJjnG/jNIXyfOjEtaQ/DARDe8nFOqLBNRI07E8qi557unahqNv64Kp547wWENG QrjAogh8qrOIvYgdJFKWVVfGep/lVrUGa7M+EyNO60r7m0MbZk1ExreXT0Ep0v97Mwy/ jIu7sh1jus+Hldgh9qqEJuMDHhm+kklF4Y4vLOh4KBpYm9AWlcUOGAgbogZhRobOB6U2 WS+Q== X-Gm-Message-State: APjAAAVhprm5ZbtH5zB+UHS9DXKtJR4G49hS/yeUSihBq11gCkwqwMvH /dSJF6A11Vy8jnm9/yt3g8s= X-Google-Smtp-Source: APXvYqwqYh96HPZKMNxmRjyjD/n4AOfKDED/5Q2kVgud1+sGD68OWaS1ARWKzIACEEh9OYFpK6mK3w== X-Received: by 2002:a1c:a8d3:: with SMTP id r202mr670490wme.106.1554142843173; Mon, 01 Apr 2019 11:20:43 -0700 (PDT) Received: from X555LD.home ([2a02:85f:510:b900:c095:2934:58ba:cfa6]) by smtp.gmail.com with ESMTPSA id t15sm16353558wmt.2.2019.04.01.11.20.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 01 Apr 2019 11:20:42 -0700 (PDT) From: "Leonidas P. Papadakos" To: Maxime Coquelin , Alexandre Torgue , Heiko Stuebner Subject: [PATCH 2/2] arm64: dts: rockchip: disable TX offload for mtu bigger than 1498 for some SoCs Date: Mon, 1 Apr 2019 21:20:29 +0300 Message-Id: <20190401182029.31362-1-papadakospan@gmail.com> X-Mailer: git-send-email 2.21.0 MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190401_112047_691704_DA3BCC94 X-CRM114-Status: GOOD ( 12.08 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Leonidas P. Papadakos" , linux-rockchip@lists.infradead.org, Rob Herring , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP From: =?UTF-8?q?Kamil=20Trzci=C5=84ski?= Some rockchip boards (like the rock64, and the renegade) exhibit an issue where tx checksuming does not work with packets larger than 1498. This is bad for network stability. The previous approach was using force_thresh_dma_mode, which does more than disable TX offload, something we do not need this patch depends on patch: stmmac: introduce flag to dynamically disable TX offload for rockchip devices Signed-off-by: Leonidas P. Papadakos --- arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3328-rock64.dts | 2 +- arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 1 + 3 files changed, 3 insertions(+), 2 deletions(-) diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts index c213ad74d..16ced107d 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts @@ -136,7 +136,7 @@ phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&rgmiim1_pins>; - snps,force_thresh_dma_mode; + rockchip,bugged_tx_coe; snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; snps,reset-active-low; snps,reset-delays-us = <0 10000 50000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts index 7cfd5ca6c..cab2e1da6 100644 --- a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts @@ -150,7 +150,7 @@ phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&rgmiim1_pins>; - snps,force_thresh_dma_mode; + rockchip,bugged_tx_coe; snps,reset-gpio = <&gpio1 RK_PC2 GPIO_ACTIVE_LOW>; snps,reset-active-low; snps,reset-delays-us = <0 10000 50000>; diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts index 791fb0ee9..a1221dca1 100644 --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts @@ -207,6 +207,7 @@ phy-mode = "rgmii"; pinctrl-names = "default"; pinctrl-0 = <&rgmii_pins>; + rockchip,bugged_tx_coe; snps,reset-gpio = <&gpio3 RK_PB7 GPIO_ACTIVE_LOW>; snps,reset-active-low; snps,reset-delays-us = <0 10000 50000>;