diff mbox series

arm64: dts: rockchip: eMMC additions for rk3328-roc-cc

Message ID 20190403215051.29536-1-papadakospan@gmail.com (mailing list archive)
State New, archived
Headers show
Series arm64: dts: rockchip: eMMC additions for rk3328-roc-cc | expand

Commit Message

Leonidas P. Papadakos April 3, 2019, 9:50 p.m. UTC
The eMMC 5.x that Libre Computer provide for their boards supports HS200 mode.
The support is already included in the dts for their newest board:

La Frite (AML-S805X-AC)
dts: arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dts

That same eMMC is supported in the ROC-RK3328-CC:
https://www.loverpi.com/products/libre-computer-board-emmc-5-x-module

This increases the speed of the eMMC significantly.

Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com>
---
 arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 4 ++++
 1 file changed, 4 insertions(+)

Comments

Shawn Lin April 4, 2019, 1:54 a.m. UTC | #1
On 2019/4/4 5:50, Leonidas P. Papadakos wrote:
> The eMMC 5.x that Libre Computer provide for their boards supports HS200 mode.
> The support is already included in the dts for their newest board:
> 
> La Frite (AML-S805X-AC)
> dts: arch/arm64/boot/dts/amlogic/meson-gxl-s805x-libretech-ac.dts
> 
> That same eMMC is supported in the ROC-RK3328-CC:
> https://www.loverpi.com/products/libre-computer-board-emmc-5-x-module
> 
> This increases the speed of the eMMC significantly.
> 
> Signed-off-by: Leonidas P. Papadakos <papadakospan@gmail.com>
> ---
>   arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts | 4 ++++
>   1 file changed, 4 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> index c213ad74d..c3cf56107 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
> @@ -122,6 +122,10 @@
>   &emmc {
>   	bus-width = <8>;
>   	cap-mmc-highspeed;
> +	disable-wp;

disable-wp isn't needed.

> +	max-frequency = <200000000>;

AFAIK, the 200Mhz eMMC SI for rk3328 is not so good for MP,
so I suggest you to limit it to 150MHz.:)

> +	mmc-ddr-1_8v;
> +	mmc-hs200-1_8v;
>   	non-removable;
>   	pinctrl-names = "default";
>   	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>;
>
diff mbox series

Patch

diff --git a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
index c213ad74d..c3cf56107 100644
--- a/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
+++ b/arch/arm64/boot/dts/rockchip/rk3328-roc-cc.dts
@@ -122,6 +122,10 @@ 
 &emmc {
 	bus-width = <8>;
 	cap-mmc-highspeed;
+	disable-wp;
+	max-frequency = <200000000>;
+	mmc-ddr-1_8v;
+	mmc-hs200-1_8v;
 	non-removable;
 	pinctrl-names = "default";
 	pinctrl-0 = <&emmc_clk &emmc_cmd &emmc_bus8>;