From patchwork Thu Apr 11 23:21:56 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Doug Anderson X-Patchwork-Id: 10897073 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id CF69317EF for ; Thu, 11 Apr 2019 23:23:39 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id B4ABD28B02 for ; Thu, 11 Apr 2019 23:23:39 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id A815328E1E; Thu, 11 Apr 2019 23:23:39 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,MAILING_LIST_MULTI,RCVD_IN_DNSWL_MED autolearn=ham version=3.3.1 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id 4EA5528B02 for ; Thu, 11 Apr 2019 23:23:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=/ZHLGKNyYn4RUq7ol+Lu6NFpLNkbPQUvTsTJ3lz/eAU=; b=IhbPAbpdGjMcjz USJFpzSj7QWAHFHBF7bMjHNdWSaoL7iAkts6ZZjRQWykpBWBs+NWehhdT8f1M6C/YFl150dut2JdS zY8BTThL8OKB/AKHN8wZ0kJIIkCUkLPRMyM6z5SjwbR5z2Nb7PZOBrZ3FbP6o5oZGDqu4BRCYWoo5 Ykyj3pUSLdYL7Jcg/cA11+xAVif65/CWfb9sJ/G/Mqst+qbMxqcj+v93kJCnCxBjXCpGR1JDzR9Tj LmyaiFKGaawRTpnf6Deq0GBsEO9+j/k1vVFQCTL4SPA5xEOV8YqxkD7mNCMHo1p2EbJ4CdfG5yfSm DE5uY2EqlI7Y54oLnUSQ==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj2e-0007Fz-BY; Thu, 11 Apr 2019 23:23:36 +0000 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1hEj1w-0006ER-IY for linux-rockchip@lists.infradead.org; Thu, 11 Apr 2019 23:22:55 +0000 Received: by mail-pf1-x442.google.com with SMTP id b3so4185695pfd.1 for ; Thu, 11 Apr 2019 16:22:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wyUtO6FBL1xGO1LJ/Cb0qrWJLFLRp1Daf+h1sPg+o68=; b=TPS/dpoQuEcPL74mFmY5Uu60oJSHdAOiKPcubSb51l+oOx9K6r+U5YweUjegwXEhNk Ak+ZDNB5BJbm2Dwp5VgYogWw3aqICJd/kHSUrL/fEc0SKuJbzjOtBFUEJ+kiljE4vK5e FMpSlLeSusSGvEg82D+uwsy5EklfJ/Gm9EAJo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wyUtO6FBL1xGO1LJ/Cb0qrWJLFLRp1Daf+h1sPg+o68=; b=kQ6WxDrjsk0Ap0OBSdicJc3IICuFBWg3Id8Y4h7eV5lFFtTglP7RmQqpLAeLUCcEPx dIsS+5KvIaKWfjzRHC2n0P905UYtS5CW1Mktg1NSFwNDTKQhxPD5O3MJCHKLSWBKSyRp cnoc0VkMU0x1V2gb3ThE4QyleXXzBC6/Tud995tAyELl2r0PyTT7ZPGiHkmI38rS12li TPCHbynK+teQ9BC/iLIcbxkqd/RWOVRK2FtsZozO0+IKEyYzBRbgoqYGk+5poXWGaDGl MhlEVXMMA7TlL9bRhHsTw560UceN2MWXKZItO+xLRwgbjAiDmX1qSADD+qI40QdYf0Fu oklA== X-Gm-Message-State: APjAAAW2kQ1op13NK58OemDNX0m1yXTSiBbcU7i9ZX+86+SkVo/VoTMv xUyEP9Vk3XLZwgDqrpYBOjIhZA== X-Google-Smtp-Source: APXvYqzs4AKfNFevOdhKmdg8KcOTyRngwms5IiA0+9tyh468oqtIH4NxO2YYemeRS8vq4ZNVmBoUdQ== X-Received: by 2002:a62:2fc7:: with SMTP id v190mr51345536pfv.10.1555024972090; Thu, 11 Apr 2019 16:22:52 -0700 (PDT) Received: from tictac2.mtv.corp.google.com ([2620:15c:202:1:24fa:e766:52c9:e3b2]) by smtp.gmail.com with ESMTPSA id y20sm37288903pfe.188.2019.04.11.16.22.51 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 11 Apr 2019 16:22:51 -0700 (PDT) From: Douglas Anderson To: Heiko Stuebner , Elaine Zhang Subject: [PATCH 4/5] ARM: dts: rockchip: vcc33_ccd off in suspend for rk3288-veyron-chromebook Date: Thu, 11 Apr 2019 16:21:56 -0700 Message-Id: <20190411232157.55125-4-dianders@chromium.org> X-Mailer: git-send-email 2.21.0.392.gf8f6787159e-goog In-Reply-To: <20190411232157.55125-1-dianders@chromium.org> References: <20190411232157.55125-1-dianders@chromium.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20190411_162252_758156_5136AADD X-CRM114-Status: GOOD ( 15.07 ) X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Mark Rutland , devicetree@vger.kernel.org, briannorris@chromium.org, amstan@chromium.org, dbasehore@chromium.org, Douglas Anderson , Rob Herring , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, mka@chromium.org, ryandcase@chromium.org, Chris Zhong , linux-arm-kernel@lists.infradead.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org X-Virus-Scanned: ClamAV using ClamSMTP As per my comments when the device tree for rk3288-veyron-chromebook first landed: > Technically I think vcc33_ccd can be off since we have > 'needs-reset-on-resume' down in the EHCI port (this regulator is for > the USB webcam that's connected to the EHCI port). > > ...but leaving it on for now seems fine until we get suspend/resume > more solid. It's probably about time to do it right. [1] https://lore.kernel.org/linux-arm-kernel/CAD=FV=U37Yx8Mqk75_x05zxonvdc3qRMhqp8TyTDPWGHqSuRqg@mail.gmail.com/ Signed-off-by: Douglas Anderson Reviewed-by: Elaine Zhang --- arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi index b9cc90f0f25c..fbef34578100 100644 --- a/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron-chromebook.dtsi @@ -176,8 +176,7 @@ regulator-min-microvolt = <3300000>; regulator-max-microvolt = <3300000>; regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <3300000>; + regulator-off-in-suspend; }; }; };