| Message ID | 20190411232157.55125-5-dianders@chromium.org (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | [1/5] clk: rockchip: Turn on "aclk_dmac1" for suspend | expand |
hi, 在 2019/4/12 上午7:21, Douglas Anderson 写道: > At some point long long ago the downstream GPU driver would crash if > we turned the GPU off during suspend. For some context you can see: > > https://chromium-review.googlesource.com/#/c/215780/5..6/arch/arm/boot/dts/rk3288-pinky-rev2.dts > > At some point in time not too long after that got fixed. > > It's unclear why the GPU is left enabled during suspend on the > mainline kernel. Everything seems fine if I turn this off, so let's > do it. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> > --- > > arch/arm/boot/dts/rk3288-veyron.dtsi | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi > index 279d7f4ecce0..1252522392c7 100644 > --- a/arch/arm/boot/dts/rk3288-veyron.dtsi > +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi > @@ -217,8 +217,7 @@ > regulator-max-microvolt = <1250000>; > regulator-ramp-delay = <6001>; > regulator-state-mem { > - regulator-on-in-suspend; > - regulator-suspend-microvolt = <1000000>; > + regulator-off-in-suspend; > }; > }; > Reviewed-by: Elaine Zhang<zhangqing@rock-chips.com>
Am Freitag, 12. April 2019, 01:21:57 CEST schrieb Douglas Anderson: > At some point long long ago the downstream GPU driver would crash if > we turned the GPU off during suspend. For some context you can see: > > https://chromium-review.googlesource.com/#/c/215780/5..6/arch/arm/boot/dts/rk3288-pinky-rev2.dts > > At some point in time not too long after that got fixed. > > It's unclear why the GPU is left enabled during suspend on the > mainline kernel. Everything seems fine if I turn this off, so let's > do it. > > Signed-off-by: Douglas Anderson <dianders@chromium.org> applied for 5.2 Thanks Heiko
diff --git a/arch/arm/boot/dts/rk3288-veyron.dtsi b/arch/arm/boot/dts/rk3288-veyron.dtsi index 279d7f4ecce0..1252522392c7 100644 --- a/arch/arm/boot/dts/rk3288-veyron.dtsi +++ b/arch/arm/boot/dts/rk3288-veyron.dtsi @@ -217,8 +217,7 @@ regulator-max-microvolt = <1250000>; regulator-ramp-delay = <6001>; regulator-state-mem { - regulator-on-in-suspend; - regulator-suspend-microvolt = <1000000>; + regulator-off-in-suspend; }; };
At some point long long ago the downstream GPU driver would crash if we turned the GPU off during suspend. For some context you can see: https://chromium-review.googlesource.com/#/c/215780/5..6/arch/arm/boot/dts/rk3288-pinky-rev2.dts At some point in time not too long after that got fixed. It's unclear why the GPU is left enabled during suspend on the mainline kernel. Everything seems fine if I turn this off, so let's do it. Signed-off-by: Douglas Anderson <dianders@chromium.org> --- arch/arm/boot/dts/rk3288-veyron.dtsi | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)