| Message ID | 20191213181051.25983-11-miquel.raynal@bootlin.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
| Series | Add PX30 LVDS support | expand |
Hi Miquel, Am Freitag, 13. Dezember 2019, 19:10:49 CET schrieb Miquel Raynal: > Add the display subsystem routes with the two available CRTCs: vopb > and vopl (big and little). For each CRTC, add the LVDS endpoints. MIPI > DSI endpoints will come later. > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > --- > arch/arm64/boot/dts/rockchip/px30.dtsi | 20 ++++++++++++++++++++ > 1 file changed, 20 insertions(+) > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > index b2af0f02ecbe..1c96ba556daf 100644 > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > @@ -190,6 +190,16 @@ > compatible = "rockchip,display-subsystem"; > ports = <&vopb_out>, <&vopl_out>; > status = "disabled"; > + > + route { > + route_vopb_lvds: route-vopb-lvds { > + connect = <&vopb_out_lvds>; > + }; > + > + route_vopl_lvds: route-vopl-lvds { > + connect = <&vopl_out_lvds>; > + }; > + }; where does this route-stuff come from? The vendor tree? Because so far I've not seen this in mainline-drm in general nor the Rockchip drm driver itself. > }; > > gmac_clkin: external-gmac-clock { > @@ -976,6 +986,11 @@ > vopb_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopb_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopb_in>; > + }; This (and the one below) would create dangling phandle references and compile errors, because the referenced phandles only get introduced in patch12. So ideally merge this into the last patch. Heiko > }; > }; > > @@ -1008,6 +1023,11 @@ > vopl_out: port { > #address-cells = <1>; > #size-cells = <0>; > + > + vopl_out_lvds: endpoint@0 { > + reg = <0>; > + remote-endpoint = <&lvds_vopl_in>; > + }; > }; > }; > >
Hi Heiko, Heiko Stübner <heiko@sntech.de> wrote on Fri, 13 Dec 2019 19:28:21 +0100: > Hi Miquel, > > Am Freitag, 13. Dezember 2019, 19:10:49 CET schrieb Miquel Raynal: > > Add the display subsystem routes with the two available CRTCs: vopb > > and vopl (big and little). For each CRTC, add the LVDS endpoints. MIPI > > DSI endpoints will come later. > > > > Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> > > --- > > arch/arm64/boot/dts/rockchip/px30.dtsi | 20 ++++++++++++++++++++ > > 1 file changed, 20 insertions(+) > > > > diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi > > index b2af0f02ecbe..1c96ba556daf 100644 > > --- a/arch/arm64/boot/dts/rockchip/px30.dtsi > > +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi > > @@ -190,6 +190,16 @@ > > compatible = "rockchip,display-subsystem"; > > ports = <&vopb_out>, <&vopl_out>; > > status = "disabled"; > > + > > + route { > > + route_vopb_lvds: route-vopb-lvds { > > + connect = <&vopb_out_lvds>; > > + }; > > + > > + route_vopl_lvds: route-vopl-lvds { > > + connect = <&vopl_out_lvds>; > > + }; > > + }; > > where does this route-stuff come from? > The vendor tree? Because so far I've not seen this in mainline-drm > in general nor the Rockchip drm driver itself. Yes it comes from the vendor tree, I added a few things from the vendor tree in the "I really want this panel to work" phase and I forgot to check if it could be removed, I'll probably drop this. > > > > }; > > > > gmac_clkin: external-gmac-clock { > > @@ -976,6 +986,11 @@ > > vopb_out: port { > > #address-cells = <1>; > > #size-cells = <0>; > > + > > + vopb_out_lvds: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&lvds_vopb_in>; > > + }; > > This (and the one below) would create dangling phandle references > and compile errors, because the referenced phandles only get introduced > in patch12. So ideally merge this into the last patch. Actually patch 12 also references these nodes so I should merge them. > > > Heiko > > > }; > > }; > > > > @@ -1008,6 +1023,11 @@ > > vopl_out: port { > > #address-cells = <1>; > > #size-cells = <0>; > > + > > + vopl_out_lvds: endpoint@0 { > > + reg = <0>; > > + remote-endpoint = <&lvds_vopl_in>; > > + }; > > }; > > }; > > > > > > > > Thanks for the review! Miquèl
diff --git a/arch/arm64/boot/dts/rockchip/px30.dtsi b/arch/arm64/boot/dts/rockchip/px30.dtsi index b2af0f02ecbe..1c96ba556daf 100644 --- a/arch/arm64/boot/dts/rockchip/px30.dtsi +++ b/arch/arm64/boot/dts/rockchip/px30.dtsi @@ -190,6 +190,16 @@ compatible = "rockchip,display-subsystem"; ports = <&vopb_out>, <&vopl_out>; status = "disabled"; + + route { + route_vopb_lvds: route-vopb-lvds { + connect = <&vopb_out_lvds>; + }; + + route_vopl_lvds: route-vopl-lvds { + connect = <&vopl_out_lvds>; + }; + }; }; gmac_clkin: external-gmac-clock { @@ -976,6 +986,11 @@ vopb_out: port { #address-cells = <1>; #size-cells = <0>; + + vopb_out_lvds: endpoint@0 { + reg = <0>; + remote-endpoint = <&lvds_vopb_in>; + }; }; }; @@ -1008,6 +1023,11 @@ vopl_out: port { #address-cells = <1>; #size-cells = <0>; + + vopl_out_lvds: endpoint@0 { + reg = <0>; + remote-endpoint = <&lvds_vopl_in>; + }; }; };
Add the display subsystem routes with the two available CRTCs: vopb and vopl (big and little). For each CRTC, add the LVDS endpoints. MIPI DSI endpoints will come later. Signed-off-by: Miquel Raynal <miquel.raynal@bootlin.com> --- arch/arm64/boot/dts/rockchip/px30.dtsi | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+)