From patchwork Thu Feb 6 22:07:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Helen Koike X-Patchwork-Id: 11369311 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 0A482921 for ; Thu, 6 Feb 2020 22:07:39 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id DCCEE20658 for ; Thu, 6 Feb 2020 22:07:38 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="O3qnC0zl" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DCCEE20658 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=collabora.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mgKZGuo4u8L4C9WBkPaueszUKWis1I3vRDsfyeNWrKE=; b=O3qnC0zlJjSSjT iwHPK+F4oEl4rMibJZ9z/RbzDSA6AGhYca4+fjME9SyCAD1J0IXB/LfosPt0adxZxWQBDvNVp03/1 8IMC1psnsll3Xfm0hG1881P/DfB0/O6ct6DTyibnbSkPqNFUR2a6kzS6K18D8NOqPzGPDG6exnXwE eDPe06pWd8JjOdsjmcVwXVn2+ak4DBSHOOfx33zMThRAw2vJIcIu34syk6MlMS389u7sVY7J0cRi8 asrsHayj0kgeR13ISh1MH8RRN54/inY66VKbY8PiAcB+DFI0n11qOnRrehl9oTmFVHwCmlZmRgf5a KCFFYH2DjyEODZNGEojA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1izpJ9-00037I-Qq; Thu, 06 Feb 2020 22:07:35 +0000 Received: from bhuna.collabora.co.uk ([46.235.227.227]) by bombadil.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1izpJ7-00034Q-Oc for linux-rockchip@lists.infradead.org; Thu, 06 Feb 2020 22:07:35 +0000 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: koike) with ESMTPSA id 80441294421 From: Helen Koike To: linux-media@vger.kernel.org Subject: [PATCH] media: staging: rkisp1: rsz: return to userspace the crop value in bayer mainpath Date: Thu, 6 Feb 2020 19:07:11 -0300 Message-Id: <20200206220712.1243438-4-helen.koike@collabora.com> X-Mailer: git-send-email 2.24.0 In-Reply-To: <20200206220712.1243438-1-helen.koike@collabora.com> References: <20200206220712.1243438-1-helen.koike@collabora.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200206_140733_938688_1446EACD X-CRM114-Status: UNSURE ( 7.03 ) X-CRM114-Notice: Please train this message. X-Spam-Score: -0.0 (/) X-Spam-Report: SpamAssassin version 3.4.3 on bombadil.infradead.org summary: Content analysis details: (-0.0 points) pts rule name description ---- ---------------------- -------------------------------------------------- -0.0 RCVD_IN_DNSWL_NONE RBL: Sender listed at https://www.dnswl.org/, no trust [46.235.227.227 listed in list.dnswl.org] -0.0 SPF_HELO_PASS SPF: HELO matches SPF record -0.0 SPF_PASS SPF: sender matches SPF record 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: kernel@collabora.com, dafna.hirschfeld@collabora.com, linux-kernel@vger.kernel.org, hverkuil@xs4all.nl, linux-rockchip@lists.infradead.org, Helen Koike , mchehab@kernel.org Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+patchwork-linux-rockchip=patchwork.kernel.org@lists.infradead.org If bayer format is set in mainpath, then crop is not supported. The core was just reseting crop but wasn't returning the values back to user space. Return values taken in consideration by the driver to userpace. Signed-off-by: Helen Koike --- drivers/staging/media/rkisp1/rkisp1-resizer.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/staging/media/rkisp1/rkisp1-resizer.c b/drivers/staging/media/rkisp1/rkisp1-resizer.c index d986953d268b..9de6744f0900 100644 --- a/drivers/staging/media/rkisp1/rkisp1-resizer.c +++ b/drivers/staging/media/rkisp1/rkisp1-resizer.c @@ -503,6 +503,8 @@ static void rkisp1_rsz_set_sink_crop(struct rkisp1_resizer *rsz, sink_crop->top = 0; sink_crop->width = sink_fmt->width; sink_crop->height = sink_fmt->height; + + *r = *sink_crop; return; }